openstack/tripleo-heat-templates
Code Issues Proposed changes

Set correct default NovaLibvirtCPUMode

Browse Source 
https://review.opendev.org/q/I8df21d5d171976cbb8670dc5aef744b5fae657b2
introduced THT parameters to set libvirt/cpu_mode. The patch sets the
NovaLibvirtCPUMode wrong to 'none' string which results in puppet-nova
not to handle the default cases correct and sets libvirt/cpu_mode to
none which results in 'qemu64' CPU model, which is highly buggy and
undesirable for production usage.  This changes the default to the
recommended CPU mode 'host-model', for various benefits documented
elsewhere.

Closes-Bug: #1905544

Change-Id: Iea8cccd77caac4b84764d84a213918ed57bd4e3e
This commit is contained in:
Martin Schuppert
2020-11-25 13:07:52 +01:00
parent 1015c3d4c3
commit c290a5e3a1
2 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
deployment/nova/nova-compute-container-puppet.yaml
View File

@@ -467,7 +467,7 @@ parameters:
description: > description: >
The libvirt CPU mode to configure. Defaults to 'host-model' if virt_type is The libvirt CPU mode to configure. Defaults to 'host-model' if virt_type is
set to kvm, otherwise defaults to 'none' set to kvm, otherwise defaults to 'none'
default: 'none' default: 'host-model'
constraints: constraints:
- allowed_values: - allowed_values:
- custom - custom

11
releasenotes/notes/nova_compute_default_cpu_mode-cda2bb3e56463b3a.yaml Normal file
View File

@@ -0,0 +1,11 @@
---
fixes:
- |
https://review.opendev.org/q/I8df21d5d171976cbb8670dc5aef744b5fae657b2
introduced THT parameters to set libvirt/cpu_mode. The patch sets the
NovaLibvirtCPUMode wrong to 'none' string which results in puppet-nova
not to handle the default cases correct and sets libvirt/cpu_mode to
none which results in 'qemu64' CPU model, which is highly buggy and
undesirable for production usage. This changes the default to the
recommended CPU mode 'host-model', for various benefits documented
elsewhere.