Convert ipv4 nic-config templates

The ipv4 nic-config templates in tripleo-heat-templates were never
updated to use "group: script" and were still using the deprecated
"group: os-apply-config".

This commit updates the templates. Doing so means they will also work
with the config-download deploy mechanism which only supports the
"group: script" method. This update allows us to move forward with
converting ci jobs that use these templates (such as ovb-ha) to use
config-download.

Change-Id: If3cc2749c070a9e88a33b8b0643aeef8a97dd181

ci/environments/network/multiple-nics/nic-configs/ceph-storage.yaml

@@ -79,9 +79,15 @@ parameters:
 
 resources:
   OsNetConfigImpl:
+    type: OS::Heat::SoftwareConfig
     properties:
+      group: script
       config:
-        os_net_config:
+        str_replace:
+          template:
+            get_file: ../../../../../network/scripts/run-os-net-config.sh
+          params:
+            $network_config:
               network_config:
               - type: interface
                 name: nic1
@@ -110,8 +116,6 @@ resources:
                 use_dhcp: false
                 addresses:
                 - ip_netmask: {get_param: StorageMgmtIpSubnet}
-      group: os-apply-config
-    type: OS::Heat::StructuredConfig
 
 outputs:
   OS::stack_id:

ci/environments/network/multiple-nics/nic-configs/cinder-storage.yaml

@@ -79,12 +79,16 @@ parameters:
 
 resources:
   OsNetConfigImpl:
+    type: OS::Heat::SoftwareConfig
     properties:
+      group: script
       config:
-        os_net_config:
+        str_replace:
+          template:
+            get_file: ../../../../../network/scripts/run-os-net-config.sh
+          params:
+            $network_config:
               network_config: []
-      group: os-apply-config
-    type: OS::Heat::StructuredConfig
 
 outputs:
   OS::stack_id:

ci/environments/network/multiple-nics/nic-configs/compute.yaml

@@ -79,9 +79,15 @@ parameters:
 
 resources:
   OsNetConfigImpl:
+    type: OS::Heat::SoftwareConfig
     properties:
+      group: script
       config:
-        os_net_config:
+        str_replace:
+          template:
+            get_file: ../../../../../network/scripts/run-os-net-config.sh
+          params:
+            $network_config:
               network_config:
               - type: interface
                 name: nic1
@@ -127,8 +133,6 @@ resources:
                 use_dhcp: false
                 addresses:
                 - ip_netmask: {get_param: StorageMgmtIpSubnet}
-      group: os-apply-config
-    type: OS::Heat::StructuredConfig
 
 outputs:
   OS::stack_id:

ci/environments/network/multiple-nics/nic-configs/controller.yaml

@@ -79,9 +79,15 @@ parameters:
 
 resources:
   OsNetConfigImpl:
+    type: OS::Heat::SoftwareConfig
     properties:
+      group: script
       config:
-        os_net_config:
+        str_replace:
+          template:
+            get_file: ../../../../../network/scripts/run-os-net-config.sh
+          params:
+            $network_config:
               network_config:
               - type: interface
                 name: nic1
@@ -139,8 +145,6 @@ resources:
                   name: nic6
                   mtu: 1350
                   primary: true
-      group: os-apply-config
-    type: OS::Heat::StructuredConfig
 
 outputs:
   OS::stack_id:

ci/environments/network/multiple-nics/nic-configs/swift-storage.yaml

@@ -79,12 +79,16 @@ parameters:
 
 resources:
   OsNetConfigImpl:
+    type: OS::Heat::SoftwareConfig
     properties:
+      group: script
       config:
-        os_net_config:
+        str_replace:
+          template:
+            get_file: ../../../../../network/scripts/run-os-net-config.sh
+          params:
+            $network_config:
               network_config: []
-      group: os-apply-config
-    type: OS::Heat::StructuredConfig
 
 outputs:
   OS::stack_id: