flatten the iscsid service

This change combines the previous puppet and docker files into a single
file that performs the docker service installation and configuration
for the iscsid service.

Related-Blueprint: services-yaml-flattening

Change-Id: I4a06c86da88618f9c88c5a9161dab771a82cc7d3

deployment/iscsid/iscsid-container-puppet.yaml

@@ -40,30 +40,21 @@ parameters:
 resources:
 
   ContainersCommon:
-    type: ./containers-common.yaml
+    type: ../../docker/services/containers-common.yaml
-
-  IscsidBase:
-    type: ../../puppet/services/iscsid.yaml
-    properties:
-      EndpointMap: {get_param: EndpointMap}
-      ServiceNetMap: {get_param: ServiceNetMap}
-      DefaultPasswords: {get_param: DefaultPasswords}
-      RoleName: {get_param: RoleName}
-      RoleParameters: {get_param: RoleParameters}
 
 outputs:
   role_data:
     description: Role data for the Iscsid role.
     value:
-      service_name: {get_attr: [IscsidBase, role_data, service_name]}
+      service_name: iscsid
-      config_settings: {get_attr: [IscsidBase, role_data, config_settings]}
+      config_settings: {}
-      service_config_settings: {get_attr: [IscsidBase, role_data, service_config_settings]}
+      service_config_settings: {}
       # BEGIN DOCKER SETTINGS
       puppet_config:
         config_volume: iscsid
         puppet_tags: iscsid_config
-        step_config:
+        step_config: |
-          {get_attr: [IscsidBase, role_data, step_config]}
+          include ::tripleo::profile::base::iscsid
         config_image: {get_param: DockerIscsidConfigImage}
         volumes:
           # NOTE(bogdando) Containerized or running on baremetal services

environments/baremetal-services.yaml

@@ -25,7 +25,7 @@ resource_registry:
   OS::TripleO::Services::HeatApiCfn: ../deployment/heat/heat-api-cfn-container-puppet.yaml
   OS::TripleO::Services::HeatEngine: ../deployment/heat/heat-engine-container-puppet.yaml
   OS::TripleO::Services::Horizon: ../puppet/services/horizon.yaml
-  OS::TripleO::Services::Iscsid: ../puppet/services/iscsid.yaml
+  OS::TripleO::Services::Iscsid: ../deployment/iscsid/iscsid-container-puppet.yaml
   OS::TripleO::Services::Keystone: ../deployment/keystone/keystone-container-puppet.yaml
   OS::TripleO::Services::Memcached: ../deployment/memcached/memcached-container-puppet.yaml
   OS::TripleO::Services::Multipathd: OS::Heat::None

environments/computealt.yaml

@@ -7,7 +7,7 @@ resource_registry:
   OS::TripleO::Services::FluentdAlt: OS::Heat::None
   # If enabling fluentd you'll need provide the following in a specific resource_registry
   # OS::TripleO::Services::FluentdAlt: ../puppet/services/logging/fluentd.yaml
-  OS::TripleO::Services::IscsidAlt: ../puppet/services/iscsid.yaml
+  OS::TripleO::Services::IscsidAlt: ../deployment/iscsid/iscsid-container-puppet.yaml
   OS::TripleO::Services::NovaComputeAlt: ../puppet/services/nova-compute.yaml
   OS::TripleO::Services::NovaLibvirtAlt: ../puppet/services/nova-libvirt.yaml
   OS::TripleO::Services::NovaMigrationTargetAlt: ../puppet/services/nova-migration-target.yaml

overcloud-resource-registry-puppet.j2.yaml

@@ -179,7 +179,7 @@ resource_registry:
   OS::TripleO::Services::HAproxy: docker/services/haproxy.yaml
   OS::TripleO::Services::HAProxyPublicTLS: puppet/services/haproxy-public-tls-inject.yaml
   OS::TripleO::Services::HAProxyInternalTLS: OS::Heat::None
-  OS::TripleO::Services::Iscsid: docker/services/iscsid.yaml
+  OS::TripleO::Services::Iscsid: deployment/iscsid/iscsid-container-puppet.yaml
   OS::TripleO::Services::Keepalived: deployment/keepalived/keepalived-container-puppet.yaml
   OS::TripleO::Services::Memcached: deployment/memcached/memcached-container-puppet.yaml
   OS::TripleO::Services::SaharaApi: OS::Heat::None

puppet/services/iscsid.yaml

@@ -1,41 +0,0 @@
-heat_template_version: rocky
-
-description: >
-  Configure iscsid
-
-parameters:
-  ServiceData:
-    default: {}
-    description: Dictionary packing service data
-    type: json
-  ServiceNetMap:
-    default: {}
-    description: Mapping of service_name -> network name. Typically set
-                 via parameter_defaults in the resource registry.  This
-                 mapping overrides those in ServiceNetMapDefaults.
-    type: json
-  DefaultPasswords:
-    default: {}
-    type: json
-  RoleName:
-    default: ''
-    description: Role name on which the service is applied
-    type: string
-  RoleParameters:
-    default: {}
-    description: Parameters specific to the role
-    type: json
-  EndpointMap:
-    default: {}
-    description: Mapping of service endpoint -> protocol. Typically set
-                 via parameter_defaults in the resource registry.
-    type: json
-
-outputs:
-  role_data:
-    description: Role data for iscsid
-    value:
-      service_name: iscsid
-      config_settings: {}
-      step_config: |
-        include ::tripleo::profile::base::iscsid