ControlPlaneDefaultRoute using get_attr

Use get_attr on the server resource to resolve attribute
value from the subnet(s) and pass it to the parameter
'ControlPlaneDefaultRoute' used in the THT/network/config/*
templates.

Changes the default for 'ControlPlaneDefaultRoute' to ''
as well as the comment that the value should be overriden
in parameters_defaults. It also removes the parameter from
network-environment templates.

A conditinal is used in  puppet/role.role.j2.yaml so that
the parameter value is used whenever it is not '' (the
default) to provide backwards compatibility in case the
user set a different value (different from the one used in
undercloud.conf) for this parameter in
network-environment.yaml.

When deploying a routed control plane the network config
templates would previously need to be updated to carry
'ControlPlaneXDefaultRoute' parameters for each leaf. With
8 Leafs in addition to the network local to the undercloud
that is 8 parameters less to place in the configuration.
By getting the value to pass from the server resource this
change reduces the required nic-config template
customisation (reduces the risk of user error).

Partial: blueprint tripleo-routed-networks-templates
Change-Id: I5139249d55e9ac01761c270b8c0f31ef35595940

ci/common/net-config-multinode-os-net-config.yaml

@@ -43,6 +43,11 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
+    type: string
   OvSBridgeMtu:
     default: 1300
     description: The mtu of the OvS bridge

ci/common/net-config-multinode.yaml

@@ -43,6 +43,11 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
+    type: string
 
 resources:
   OsNetConfigImpl:

ci/common/net-config-simple-bridge.yaml

@@ -12,6 +12,11 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
+    type: string
   ExternalIpSubnet:
     default: ''
     description: IP address/subnet on the external network

ci/environments/network/multiple-nics-ipv6/network-environment.yaml

@@ -7,7 +7,6 @@ resource_registry:
   OS::TripleO::CephStorage::Net::SoftwareConfig: nic-configs/ceph-storage.yaml
 
 parameter_defaults:
-  ControlPlaneDefaultRoute: 192.168.24.1
   EC2MetadataIp: 192.168.24.1
   ExternalNetCidr: 2001:db8:fd00:1000::/64
   ExternalAllocationPools: [{"start": "2001:db8:fd00:1000::10", "end": "2001:db8:fd00:1000:ffff:ffff:ffff:fffe"}]

ci/environments/network/multiple-nics-ipv6/nic-configs/ceph-storage.yaml

@@ -68,8 +68,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
   DnsServers: # Override this via parameter_defaults
     default: []

ci/environments/network/multiple-nics-ipv6/nic-configs/cinder-storage.yaml

@@ -68,8 +68,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
   DnsServers: # Override this via parameter_defaults
     default: []

ci/environments/network/multiple-nics-ipv6/nic-configs/compute.yaml

@@ -68,8 +68,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
   DnsServers: # Override this via parameter_defaults
     default: []

ci/environments/network/multiple-nics-ipv6/nic-configs/controller.yaml

@@ -68,8 +68,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
   DnsServers: # Override this via parameter_defaults
     default: []

ci/environments/network/multiple-nics-ipv6/nic-configs/swift-storage.yaml

@@ -68,8 +68,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
   DnsServers: # Override this via parameter_defaults
     default: []

ci/environments/network/multiple-nics/network-environment.yaml

@@ -7,7 +7,6 @@ resource_registry:
   OS::TripleO::CephStorage::Net::SoftwareConfig: nic-configs/ceph-storage.yaml
 
 parameter_defaults:
-  ControlPlaneDefaultRoute: 192.168.24.1
   EC2MetadataIp: 192.168.24.1
   ExternalNetCidr: 10.0.0.0/24
   ExternalAllocationPools: [{"start": "10.0.0.10", "end": "10.0.0.50"}]

ci/environments/network/multiple-nics/nic-configs/ceph-storage.yaml

@@ -68,8 +68,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
   DnsServers: # Override this via parameter_defaults
     default: []

ci/environments/network/multiple-nics/nic-configs/cinder-storage.yaml

@@ -68,8 +68,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
   DnsServers: # Override this via parameter_defaults
     default: []

ci/environments/network/multiple-nics/nic-configs/compute.yaml

@@ -68,8 +68,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
   DnsServers: # Override this via parameter_defaults
     default: []

ci/environments/network/multiple-nics/nic-configs/controller.yaml

@@ -68,8 +68,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
   DnsServers: # Override this via parameter_defaults
     default: []

ci/environments/network/multiple-nics/nic-configs/swift-storage.yaml

@@ -68,8 +68,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
   DnsServers: # Override this via parameter_defaults
     default: []

ci/environments/network/public-bond/network-environment.yaml

@@ -7,7 +7,6 @@ resource_registry:
   OS::TripleO::CephStorage::Net::SoftwareConfig: nic-configs/ceph-storage.yaml
 
 parameter_defaults:
-  ControlPlaneDefaultRoute: 192.168.24.1
   EC2MetadataIp: 192.168.24.1
   ExternalNetCidr: 10.0.0.0/24
   ExternalAllocationPools: [{"start": "10.0.0.10", "end": "10.0.0.50"}]

ci/environments/network/public-bond/nic-configs/ceph-storage.yaml

@@ -68,8 +68,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
   DnsServers: # Override this via parameter_defaults
     default: []

ci/environments/network/public-bond/nic-configs/cinder-storage.yaml

@@ -68,8 +68,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
   DnsServers: # Override this via parameter_defaults
     default: []

ci/environments/network/public-bond/nic-configs/compute.yaml

@@ -68,8 +68,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
   DnsServers: # Override this via parameter_defaults
     default: []

ci/environments/network/public-bond/nic-configs/controller.yaml

@@ -68,8 +68,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
   DnsServers: # Override this via parameter_defaults
     default: []

ci/environments/network/public-bond/nic-configs/swift-storage.yaml

@@ -68,8 +68,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
   DnsServers: # Override this via parameter_defaults
     default: []

environments/network-environment-v6.j2.yaml

@@ -21,9 +21,10 @@ parameter_defaults:
   # ControlPlaneSubnetCidr: It is no longer a requirement to provide this
   #                         parameter. The attribute is resolved from the
   #                         ctlplane subnet(s).
+  # ControlPlaneDefaultRoute: It is no longer a requirement to provide this
+  #                           parameter. The attribute is resolved from the
+  #                           ctlplane subnet(s).
   #
-  # Gateway router for the provisioning network (or Undercloud IP)
-  ControlPlaneDefaultRoute: 192.168.24.254
   EC2MetadataIp: 192.168.24.1  # Generally the IP of the Undercloud
 {% for network in networks if network.enabled|default(true) %}
 {%-     if network.name != 'Tenant' %}

environments/network-environment.j2.yaml

@@ -17,9 +17,10 @@ parameter_defaults:
   # ControlPlaneSubnetCidr: It is no longer a requirement to provide the
   #                         parameter. The attribute is resolved from the
   #                         ctlplane subnet(s).
+  # ControlPlaneDefaultRoute: It is no longer a requirement to provide this
+  #                           parameter. The attribute is resolved from the
+  #                           ctlplane subnet(s).
   #
-  # Gateway router for the provisioning network (or Undercloud IP)
-  ControlPlaneDefaultRoute: 192.168.24.254
   EC2MetadataIp: 192.168.24.1  # Generally the IP of the Undercloud
 {% for network in networks if network.enabled|default(true) %}
   # Customize the IP subnet to match the local environment

net-config-bond.j2.yaml

@@ -22,6 +22,11 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
+    type: string
   {%- for network in networks %}
   {{network.name}}IpSubnet:
     default: ''

net-config-bridge.j2.yaml

@@ -12,6 +12,11 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
+    type: string
   {%- for network in networks %}
   {{network.name}}IpSubnet:
     default: ''

net-config-linux-bridge.j2.yaml

@@ -12,8 +12,9 @@ parameters:
     description: IP address/subnet on the {{network.name_lower}} network
     type: string
   {%- endfor %}
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
     default: 192.168.24.1
   ControlPlaneSubnetCidr:

net-config-noop.j2.yaml

@@ -15,6 +15,11 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
+    type: string
   {%- for network in networks %}
   {{network.name}}IpSubnet:
     default: ''

net-config-standalone.j2.yaml

@@ -19,6 +19,11 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
+    type: string
   ControlPlaneStaticRoutes:
     default: []
     description: A list of static routes

net-config-static-bridge-with-external-dhcp.j2.yaml

@@ -19,8 +19,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
   DnsServers: # Override this via parameter_defaults
     default: []

net-config-static-bridge.j2.yaml

@@ -19,8 +19,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
   DnsServers: # Override this via parameter_defaults
     default: []

net-config-static.j2.yaml

@@ -18,8 +18,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
   DnsServers: # Override this via parameter_defaults
     default: []

net-config-undercloud.j2.yaml

@@ -19,6 +19,11 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
+    type: string
   ControlPlaneStaticRoutes:
     default: []
     description: A list of static routes

network/config/bond-with-vlans/controller-no-external.j2.yaml

@@ -16,8 +16,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
 {%- for network in networks %}
   {{network.name}}IpSubnet:

network/config/bond-with-vlans/controller-v6.j2.yaml

@@ -14,8 +14,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
 {%- for network in networks %}
   {{network.name}}IpSubnet:

network/config/bond-with-vlans/role.role.j2.yaml

@@ -12,8 +12,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
 {%- for network in networks %}
   {{network.name}}IpSubnet:

network/config/multiple-nics/compute-dvr.j2.yaml

@@ -14,8 +14,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
 {%- for network in networks %}
   {{network.name}}IpSubnet:

network/config/multiple-nics/controller-v6.j2.yaml

@@ -13,8 +13,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
 {%- for network in networks %}
   {{network.name}}IpSubnet:

network/config/multiple-nics/role.role.j2.yaml

@@ -12,8 +12,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
 {%- for network in networks %}
   {{network.name}}IpSubnet:

network/config/single-nic-linux-bridge-vlans/controller-v6.j2.yaml

@@ -13,8 +13,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
 {%- for network in networks %}
   {{network.name}}IpSubnet:

network/config/single-nic-linux-bridge-vlans/role.role.j2.yaml

@@ -12,8 +12,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
 {%- for network in networks %}
   {{network.name}}IpSubnet:

network/config/single-nic-vlans/controller-no-external.j2.yaml

@@ -16,8 +16,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
 {%- for network in networks %}
   {{network.name}}IpSubnet:

network/config/single-nic-vlans/controller-v6.j2.yaml

@@ -13,8 +13,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
 {%- for network in networks %}
   {{network.name}}IpSubnet:

network/config/single-nic-vlans/role.role.j2.yaml

@@ -12,8 +12,10 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
-  ControlPlaneDefaultRoute: # Override this via parameter_defaults
-    description: The default route of the control plane network.
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
     type: string
 {%- for network in networks %}
   {{network.name}}IpSubnet:

puppet/role.role.j2.yaml

@@ -250,6 +250,11 @@ parameters:
       The subnet CIDR of the control plane network. (The parameter is
       automatically resolved from the ctlplane subnet's cidr attribute.)
     type: string
+  ControlPlaneDefaultRoute:
+    default: ''
+    description: The default route of the control plane network. (The parameter
+      is automatically resolved from the ctlplane subnet's gateway_ip attribute.)
+    type: string
 
   ServerDeletionPolicy:
     description: Whether to retain or delete servers on deletion of the stack
@@ -324,6 +329,9 @@ conditions:
   ctlplane_subnet_cidr_set:
     not:
       equals: [{get_param: ControlPlaneSubnetCidr}, '']
+  ctlplane_default_route_set:
+    not:
+      equals: [{get_param: ControlPlaneDefaultRoute}, '']
 
 resources:
   {{server_resource_name}}:
@@ -449,6 +457,11 @@ resources:
           - ctlplane_subnet_cidr_set
           - {get_param: ControlPlaneSubnetCidr}
           - {str_split: ['/', {get_attr: [{{server_resource_name}}, addresses, ctlplane, 0, subnets, 0, cidr]}, 1]}
+      ControlPlaneDefaultRoute:
+        if:
+          - ctlplane_default_route_set
+          - {get_param: ControlPlaneDefaultRoute}
+          - {get_attr: [{{server_resource_name}}, addresses, ctlplane, 0, subnets, 0, gateway_ip]}
   {%- for network in networks %}
       {{network.name}}IpSubnet: {get_attr: [{{network.name}}Port, ip_subnet]}
   {%- endfor %}

releasenotes/notes/use-subnet-attrs-ctlplane-default-route-625ef5e414a65f2e.yaml

@@ -0,0 +1,25 @@
+---
+features:
+  - |
+    It is no longer a requirement to provide the parameter:
+    ``ControlPlaneDefaultRoute``  in the environment when deploying. Now
+    ``get_attr`` on the server resource is used to resolve the value from the
+    ``ctlplane`` subnet's ``gateway_ip`` attribute. A conditional is used to
+    determine if the user provided the parameter in the environment. If the
+    user provided the parameter, the user provided value is used.
+upgrade:
+  - |
+    Since the the ``ControlPlaneDefaultRoute`` can now be resolved from the
+    ``ctlplane`` subnet(s) this parameter can be removed from the environment
+    (``network-environment.yaml``).
+
+    .. Note:: Prior to removing the parameter ensure that the property of
+              the ``ctlplane`` subnet(s) is correct. In case it is not, update
+              ``undercloud.conf`` with the correct configuration and re-run the
+              ``openstack undercloud install`` command to ensure the property
+              is set correctly.
+
+    .. Note:: ``ControlPlaneDefaultRoute`` is now passed to the network config
+              template when the resource is created. Because of this the
+              parameter must be defined in the network config template, even if
+              it is not used.