Wait for first healthcheck before running validation tasks

The systemd healthcheck timer first triggers 120s after activation.
The initial value for ExecMainStatus is 0, resulting in false positives if we
check this too early.
This changes waits (up to 5 mins) for ExecMainPID to be set and the service to
return to an inactive/failed state.

Change-Id: Iad4ebb283a7a6559b6fffead4145cc9bbad45e4e
Depends-On: Ia2897a6be3e000a9594103502b716431baa615b1
Related-bug: #1843555

deployment/nova/nova-api-container-puppet.yaml

@@ -442,6 +442,11 @@ outputs:
               register: nova_api_healthcheck_state
               systemd:
                 name: tripleo_nova_api_healthcheck
+              retries: 10
+              delay: 30
+              until: nova_api_healthcheck_state.status.ExecMainPID != '0' and
+                nova_api_healthcheck_state.status.ActiveState in ['inactive', 'failed']
+              ignore_errors: yes
             - name: Fail if nova-api healthcheck report failed status
               fail:
                 msg: nova-api isn't working (healthcheck failed)

deployment/nova/nova-compute-container-puppet.yaml

@@ -954,6 +954,11 @@ outputs:
                 register: nova_compute_healthcheck_state
                 systemd:
                   name: tripleo_nova_compute_healthcheck
+                retries: 10
+                delay: 30
+                until: nova_compute_healthcheck_state.status.ExecMainPID != '0' and
+                  nova_compute_healthcheck_state.status.ActiveState in ['inactive', 'failed']
+                ignore_errors: yes
               - name: Fail if nova-compute healthcheck report failed status
                 fail:
                   msg: nova-compute isn't working (healthcheck failed)

deployment/nova/nova-conductor-container-puppet.yaml

@@ -202,6 +202,11 @@ outputs:
               register: nova_conductor_healthcheck_state
               systemd:
                 name: tripleo_nova_conductor_healthcheck
+              retries: 10
+              delay: 30
+              until: nova_conductor_healthcheck_state.status.ExecMainPID != '0' and
+                nova_conductor_healthcheck_state.status.ActiveState in ['inactive', 'failed']
+              ignore_errors: yes
             - name: Fail if nova-conductor healthcheck report failed status
               fail:
                 msg: nova-conductor isn't working (healthcheck failed)

deployment/nova/nova-libvirt-container-puppet.yaml

@@ -813,6 +813,11 @@ outputs:
               register: nova_libvirt_healthcheck_state
               systemd:
                 name: tripleo_nova_libvirt_healthcheck
+              retries: 10
+              delay: 30
+              until: nova_libvirt_healthcheck_state.status.ExecMainPID != '0' and
+                nova_libvirt_healthcheck_state.status.ActiveState in ['inactive', 'failed']
+              ignore_errors: yes
             - name: Fail if nova-libvirt healthcheck report failed status
               fail:
                 msg: nova-libvirt isn't working (healtcheck failed)

deployment/nova/nova-metadata-container-puppet.yaml

@@ -260,6 +260,11 @@ outputs:
               register: nova_metadata_healthcheck_state
               systemd:
                 name: tripleo_nova_metadata_healthcheck
+              retries: 10
+              delay: 30
+              until: nova_metadata_healthcheck_state.status.ExecMainPID != '0' and
+                nova_metadata_healthcheck_state.status.ActiveState in ['inactive', 'failed']
+              ignore_errors: yes
             - name: Fail if nova-metadata healthcheck report failed status
               fail:
                 msg: nova-metadata isn't working (healthcheck failed)

deployment/nova/nova-migration-target-container-puppet.yaml

@@ -185,6 +185,11 @@ outputs:
               register: nova_migration_target_healthcheck_state
               systemd:
                 name: tripleo_nova_migration_target_healthcheck
+              retries: 10
+              delay: 30
+              until: nova_migration_target_healthcheck_state.status.ExecMainPID != '0' and
+                nova_migration_target_healthcheck_state.status.ActiveState in ['inactive', 'failed']
+              ignore_errors: yes
             - name: Fail if nova-migration-target healthcheck report failed status
               fail:
                 msg: nova-migration-target isn't working (healtcheck failed)

deployment/nova/nova-scheduler-container-puppet.yaml

@@ -200,6 +200,11 @@ outputs:
               register: nova_scheduler_healthcheck_state
               systemd:
                 name: tripleo_nova_scheduler_healthcheck
+              retries: 10
+              delay: 30
+              until: nova_scheduler_healthcheck_state.status.ExecMainPID != '0' and
+                nova_scheduler_healthcheck_state.status.ActiveState in ['inactive', 'failed']
+              ignore_errors: yes
             - name: Fail if nova-scheduler healthcheck report failed status
               fail:
                 msg: nova-scheduler isn't working (healthcheck failed)

deployment/nova/nova-vnc-proxy-container-puppet.yaml

@@ -296,6 +296,11 @@ outputs:
               register: nova_vnc_proxy_healthcheck_state
               systemd:
                 name: tripleo_nova_vnc_proxy_healthcheck
+              retries: 10
+              delay: 30
+              until: nova_vnc_proxy_healthcheck_state.status.ExecMainPID != '0' and
+                nova_vnc_proxy_healthcheck_state.status.ActiveState in ['inactive', 'failed']
+              ignore_errors: yes
             - name: Fail if nova-vnc-proxy healtcheck report failed status
               fail:
                 msg: nova-vnc-proxy isn't working (healthcheck failed)