Ensure Debug is a boolean

Oslo does not like it when Debug is not a proper python boolean Closes-Bug: 1719929 Change-Id: Ib6c3969d4dd75d5fb2cc274266c060acff8d5571
2017-09-27 13:04:49 -04:00 · 2017-09-27 13:04:49 -04:00 · c9b7091536
commit c9b7091536
parent 5dbe1121e9
27 changed files with 58 additions and 52 deletions
--- a/ci/environments/multinode-core.yaml
+++ b/ci/environments/multinode-core.yaml
@ -19,8 +19,8 @@ parameters:
                 via parameter_defaults in the resource registry.
    type: json
  Debug:
-    type: string
-    default: ''
+    type: boolean
+    default: false
    description: Set to True to enable debugging on all services.

 resources:
--- a/puppet/services/aodh-base.yaml
+++ b/puppet/services/aodh-base.yaml
@ -57,9 +57,9 @@ parameters:
    description: Set rabbit subscriber port, change this if using SSL
    type: number
  Debug:
-    default: ''
+    default: false
    description: Set to True to enable debugging on all services.
-    type: string
+    type: boolean
  AodhDebug:
    default: ''
    description: Set to True to enable debugging Aodh services.
--- a/puppet/services/barbican-api.yaml
+++ b/puppet/services/barbican-api.yaml
@ -39,9 +39,9 @@ parameters:
    default: '%{::processorcount}'
    type: string
  Debug:
-    default: ''
+    default: false
    description: Set to True to enable debugging on all services.
-    type: string
+    type: boolean
  BarbicanDebug:
    default: ''
    description: Set to True to enable debugging Barbican service.
--- a/puppet/services/ceilometer-base.yaml
+++ b/puppet/services/ceilometer-base.yaml
@ -67,9 +67,9 @@ parameters:
        Set ManagePipeline to true for override to take effect.
    type: comma_delimited_list
  Debug:
-    default: ''
+    default: false
    description: Set to True to enable debugging on all services.
-    type: string
+    type: boolean
  CeilometerDebug:
    default: ''
    description: Set to True to enable debugging Ceilometer services.
--- a/puppet/services/cinder-base.yaml
+++ b/puppet/services/cinder-base.yaml
@ -9,9 +9,9 @@ parameters:
    type: string
    hidden: true
  Debug:
-    default: ''
+    default: false
    description: Set to True to enable debugging on all services.
-    type: string
+    type: boolean
  CinderDebug:
    default: ''
    description: Set to True to enable debugging on Cinder services.
--- a/puppet/services/congress.yaml
+++ b/puppet/services/congress.yaml
@ -35,8 +35,8 @@ parameters:
    type: string
    hidden: true
  Debug:
-    type: string
-    default: ''
+    type: boolean
+    default: false
    description: Set to True to enable debugging on all services.
  CongressDebug:
    default: ''
--- a/puppet/services/glance-api.yaml
+++ b/puppet/services/glance-api.yaml
@ -31,9 +31,9 @@ parameters:
                 via parameter_defaults in the resource registry.
    type: json
  Debug:
-    default: ''
+    default: false
    description: Set to True to enable debugging on all services.
-    type: string
+    type: boolean
  GlanceDebug:
    default: ''
    description: Set to True to enable debugging Glance service.
--- a/puppet/services/gnocchi-base.yaml
+++ b/puppet/services/gnocchi-base.yaml
@ -57,8 +57,8 @@ parameters:
    type: string
    hidden: true
  Debug:
-    type: string
-    default: ''
+    type: boolean
+    default: false
    description: Set to True to enable debugging on all services.
  GnocchiDebug:
    default: ''
--- a/puppet/services/heat-base.yaml
+++ b/puppet/services/heat-base.yaml
@ -5,9 +5,9 @@ description: >

 parameters:
  Debug:
-    default: ''
+    default: false
    description: Set to True to enable debugging on all services.
-    type: string
+    type: boolean
  HeatDebug:
    default: ''
    description: Set to True to enable debugging Heat services.
--- a/puppet/services/horizon.yaml
+++ b/puppet/services/horizon.yaml
@ -15,9 +15,9 @@ parameters:
                 mapping overrides those in ServiceNetMapDefaults.
    type: json
  Debug:
-    default: ''
+    default: false
    description: Set to True to enable debugging on all services.
-    type: string
+    type: boolean
  HorizonDebug:
    default: false
    description: Set to True to enable debugging Horizon service.
--- a/puppet/services/ironic-base.yaml
+++ b/puppet/services/ironic-base.yaml
@ -31,9 +31,9 @@ parameters:
                 via parameter_defaults in the resource registry.
    type: json
  Debug:
-    default: ''
+    default: false
    description: Set to True to enable debugging on all services.
-    type: string
+    type: boolean
  IronicDebug:
    default: ''
    description: Set to True to enable debugging Ironic services.
--- a/puppet/services/ironic-inspector.yaml
+++ b/puppet/services/ironic-inspector.yaml
@ -38,9 +38,9 @@ parameters:
    default: 'regionOne'
    description: Keystone region for endpoint
  Debug:
-    default: ''
+    default: false
    description: Set to True to enable debugging on all services.
-    type: string
+    type: boolean
  IronicInspectorInterface:
    default: br-ex
    description: |
--- a/puppet/services/keystone.yaml
+++ b/puppet/services/keystone.yaml
@ -65,8 +65,8 @@ parameters:
                 via parameter_defaults in the resource registry.
    type: json
  Debug:
-    type: string
-    default: ''
+    type: boolean
+    default: false
    description: Set to True to enable debugging on all services.
  KeystoneDebug:
    default: ''
--- a/puppet/services/manila-base.yaml
+++ b/puppet/services/manila-base.yaml
@ -31,9 +31,9 @@ parameters:
                 via parameter_defaults in the resource registry.
    type: json
  Debug:
-    default: ''
+    default: false
    description: Set to True to enable debugging on all services.
-    type: string
+    type: boolean
  ManilaDebug:
    default: ''
    description: Set to True to enable debugging Manila services.
--- a/puppet/services/mistral-base.yaml
+++ b/puppet/services/mistral-base.yaml
@ -32,9 +32,9 @@ parameters:
    type: json

  Debug:
-    default: ''
+    default: false
    description: Set to True to enable debugging on all services.
-    type: string
+    type: boolean
  MistralDebug:
    default: ''
    description: Set to True to enable debugging Mistral services.
--- a/puppet/services/neutron-base.yaml
+++ b/puppet/services/neutron-base.yaml
@ -51,8 +51,8 @@ parameters:
        neutron.service_plugins namespace.
    type: comma_delimited_list
  Debug:
-    type: string
-    default: ''
+    type: boolean
+    default: false
    description: Set to True to enable debugging on all services.
  NeutronDebug:
    default: ''
--- a/puppet/services/neutron-l3-compute-dvr.yaml
+++ b/puppet/services/neutron-l3-compute-dvr.yaml
@ -32,8 +32,8 @@ parameters:
                 via parameter_defaults in the resource registry.
    type: json
  Debug:
-    type: string
-    default: ''
+    type: boolean
+    default: false
    description: Set to True to enable debugging on all services.
  MonitoringSubscriptionNeutronL3Dvr:
    default: 'overcloud-neutron-l3-dvr'
--- a/puppet/services/neutron-l3.yaml
+++ b/puppet/services/neutron-l3.yaml
@ -31,8 +31,8 @@ parameters:
                 via parameter_defaults in the resource registry.
    type: json
  Debug:
-    type: string
-    default: ''
+    type: boolean
+    default: false
    description: Set to True to enable debugging on all services.
  NeutronL3AgentMode:
    description: |
--- a/puppet/services/nova-base.yaml
+++ b/puppet/services/nova-base.yaml
@ -75,8 +75,8 @@ parameters:
    description: DB Sync Timeout default
    type: number
  Debug:
-    type: string
-    default: ''
+    type: boolean
+    default: false
    description: Set to True to enable debugging on all services.
  NovaDebug:
    default: ''
--- a/puppet/services/octavia-base.yaml
+++ b/puppet/services/octavia-base.yaml
@ -31,8 +31,8 @@ parameters:
                 via parameter_defaults in the resource registry.
    type: json
  Debug:
-    type: string
-    default: ''
+    type: boolean
+    default: false
    description: Set to True to enable debugging on all services.
  OctaviaDebug:
    default: ''
--- a/puppet/services/panko-base.yaml
+++ b/puppet/services/panko-base.yaml
@ -35,9 +35,9 @@ parameters:
    type: string
    hidden: true
  Debug:
-    default: ''
+    default: false
    description: Set to True to enable debugging on all services.
-    type: string
+    type: boolean
  PankoDebug:
    default: ''
    description: Set to True to enable debugging Panko services.
--- a/puppet/services/sahara-base.yaml
+++ b/puppet/services/sahara-base.yaml
@ -53,8 +53,8 @@ parameters:
    type: string
    hidden: true
  Debug:
-    type: string
-    default: ''
+    type: boolean
+    default: false
    description: Set to True to enable debugging on all services.
  SaharaDebug:
    default: ''
--- a/puppet/services/swift-proxy.yaml
+++ b/puppet/services/swift-proxy.yaml
@ -31,9 +31,9 @@ parameters:
                 via parameter_defaults in the resource registry.
    type: json
  Debug:
-    default: ''
+    default: false
    description: Set to True to enable debugging on all services.
-    type: string
+    type: boolean
  SwiftPassword:
    description: The password for the swift service account
    type: string
--- a/puppet/services/swift-storage.yaml
+++ b/puppet/services/swift-storage.yaml
@ -31,9 +31,9 @@ parameters:
                 via parameter_defaults in the resource registry.
    type: json
  Debug:
-    default: ''
+    default: false
    description: Set to True to enable debugging on all services.
-    type: string
+    type: boolean
  SwiftMountCheck:
    default: false
    description: Value of mount_check in Swift account/container/object -server.conf
--- a/puppet/services/tacker.yaml
+++ b/puppet/services/tacker.yaml
@ -35,8 +35,8 @@ parameters:
    type: string
    hidden: true
  Debug:
-    type: string
-    default: ''
+    type: boolean
+    default: false
    description: Set to True to enable debugging on all services.
  TackerDebug:
    default: ''
--- a/puppet/services/zaqar-api.yaml
+++ b/puppet/services/zaqar-api.yaml
@ -31,9 +31,9 @@ parameters:
    description: Parameters specific to the role
    type: json
  Debug:
-    default: ''
+    default: false
    description: Set to True to enable debugging on all services.
-    type: string
+    type: boolean
  ZaqarDebug:
    default: ''
    description: Set to True to enable debugging Zaqar service.
--- a/releasenotes/notes/ensure-debug-is-boolean-aecc8fbb6c8fd368.yaml
+++ b/releasenotes/notes/ensure-debug-is-boolean-aecc8fbb6c8fd368.yaml
@ -0,0 +1,6 @@
+---
+fixes:
+  - |
+    Ensure Debug is a boolean
+    Oslo has trouble when Debug is not a proper python boolean.  See
+    https://bugs.launchpad.net/tripleo/+bug/1719929