Retry container pull 3 times

Pulling images over internet is not considered as very stable operation
as there can be a lot of issues (DNS, HTTP rate limit, route change or
interface restart ...) This patch retries "pull" 3 times to mitigate
possible networking issues

Change-Id: I03643576c9f8444d6db36364a73bccce244c8446
Closes-Bug: 1899057

deployment/cinder/cinder-backup-pacemaker-puppet.yaml

@@ -236,6 +236,10 @@ outputs:
                 cinder_backup_image_latest: *cinder_backup_image_pcmklatest
             - name: Pull latest cinder_backup images
               command: "{{container_cli}} pull {{cinder_backup_image}}"
+              register: result
+              retries: 3
+              delay: 3
+              until: result.rc == 0
             - name: Get previous cinder_backup image id
               shell: "{{container_cli}} inspect --format '{{'{{'}}.Id{{'}}'}}' {{cinder_backup_image_latest}}"
               register: old_cinder_backup_image_id

deployment/cinder/cinder-volume-pacemaker-puppet.yaml

@@ -217,6 +217,10 @@ outputs:
                 cinder_volume_image_latest: *cinder_volume_image_pcmklatest
             - name: Pull latest cinder_volume images
               command: "{{container_cli}} pull {{cinder_volume_image}}"
+              register: result
+              retries: 3
+              delay: 3
+              until: result.rc == 0
             - name: Get previous cinder_volume image id
               shell: "{{container_cli}} inspect --format '{{'{{'}}.Id{{'}}'}}' {{cinder_volume_image_latest}}"
               register: old_cinder_volume_image_id

deployment/database/mysql-pacemaker-puppet.yaml

@@ -373,6 +373,10 @@ outputs:
                 galera_image_latest: *mysql_image_pcmklatest
             - name: Pull latest galera images
               command: "{{container_cli}} pull {{galera_image}}"
+              register: result
+              retries: 3
+              delay: 3
+              until: result.rc == 0
             - name: Get previous galera image id
               shell: "{{container_cli}} inspect --format '{{'{{'}}.Id{{'}}'}}' {{galera_image_latest}}"
               register: old_galera_image_id

deployment/database/redis-pacemaker-puppet.yaml

@@ -295,6 +295,10 @@ outputs:
                 redis_image_latest: *redis_image_pcmklatest
             - name: Pull latest redis images
               command: "{{container_cli}} pull {{redis_image}}"
+              register: result
+              retries: 3
+              delay: 3
+              until: result.rc == 0
             - name: Get previous redis image id
               shell: "{{container_cli}} inspect --format '{{'{{'}}.Id{{'}}'}}' {{redis_image_latest}}"
               register: old_redis_image_id

deployment/haproxy/haproxy-pacemaker-puppet.yaml

@@ -394,6 +394,10 @@ outputs:
                 haproxy_image_latest: *haproxy_image_pcmklatest
             - name: Pull latest haproxy images
               command: "{{container_cli}} pull {{haproxy_image}}"
+              register: result
+              retries: 3
+              delay: 3
+              until: result.rc == 0
             - name: Get previous haproxy image id
               shell: "{{container_cli}} inspect --format '{{'{{'}}.Id{{'}}'}}' {{haproxy_image_latest}}"
               register: old_haproxy_image_id

deployment/manila/manila-share-pacemaker-puppet.yaml

@@ -197,6 +197,10 @@ outputs:
                 manila_share_image_latest: *manila_share_image_pcmklatest
             - name: Pull latest manila_share images
               command: "{{container_cli}} pull {{manila_share_image}}"
+              register: result
+              retries: 3
+              delay: 3
+              until: result.rc == 0
             - name: Get previous manila_share image id
               shell: "{{container_cli}} inspect --format '{{'{{'}}.Id{{'}}'}}' {{manila_share_image_latest}}"
               register: old_manila_share_image_id

deployment/ovn/ovn-dbs-pacemaker-puppet.yaml

@@ -319,6 +319,10 @@ outputs:
           block: &ovn_dbs_fetch_retag_container_tasks
             - name: Pull latest ovn-dbs images
               command: "{{container_cli}} pull {{ovn_dbs_image}}"
+              register: result
+              retries: 3
+              delay: 3
+              until: result.rc == 0
             - name: Get previous ovn_dbs image id
               shell: "{{container_cli}} inspect --format '{{'{{'}}.Id{{'}}'}}' {{ovn_dbs_image_latest}}"
               register: old_ovn_dbs_image_id

deployment/rabbitmq/rabbitmq-messaging-notify-pacemaker-puppet.yaml

@@ -285,6 +285,10 @@ outputs:
                 rabbitmq_image_latest: *rabbitmq_image_pcmklatest
             - name: Pull latest rabbitmq images
               command: "{{container_cli}} pull {{rabbitmq_image}}"
+              register: result
+              retries: 3
+              delay: 3
+              until: result.rc == 0
             - name: Get previous rabbitmq image id
               shell: "{{container_cli}} inspect --format '{{'{{'}}.Id{{'}}'}}' {{rabbitmq_image_latest}}"
               register: old_rabbitmq_image_id

deployment/rabbitmq/rabbitmq-messaging-pacemaker-puppet.yaml

@@ -285,6 +285,10 @@ outputs:
                 rabbitmq_image_latest: *rabbitmq_image_pcmklatest
             - name: Pull latest rabbitmq images
               command: "{{container_cli}} pull {{rabbitmq_image}}"
+              register: result
+              retries: 3
+              delay: 3
+              until: result.rc == 0
             - name: Get previous rabbitmq image id
               shell: "{{container_cli}} inspect --format '{{'{{'}}.Id{{'}}'}}' {{rabbitmq_image_latest}}"
               register: old_rabbitmq_image_id

deployment/rabbitmq/rabbitmq-messaging-rpc-pacemaker-puppet.yaml

@@ -289,6 +289,10 @@ outputs:
                 rabbitmq_image_latest: *rabbitmq_image_pcmklatest
             - name: Pull latest rabbitmq images
               command: "{{container_cli}} pull {{rabbitmq_image}}"
+              register: result
+              retries: 3
+              delay: 3
+              until: result.rc == 0
             - name: Get previous rabbitmq image id
               shell: "{{container_cli}} inspect --format '{{'{{'}}.Id{{'}}'}}' {{rabbitmq_image_latest}}"
               register: old_rabbitmq_image_id