openstack
/
tripleo-heat-templates
Code Issues Proposed changes

Change --start-at-task for plays using tripleo_free 

With tripleo_free strategy a playbook run fails only after the
end of the play. In case a task failure for a node, the other nodes
keep continuing till the end of play. Therefore, --start-at-task
should be always at the beginning of the play as different nodes
can fail at different tasks and we need to always start from the
start of play.

Change-Id: I79ff5d3babd05c7d1ba5195f372c1348d6692e2b
This commit is contained in:
Takashi Kajinami 2022-08-03 12:30:18 +09:00 committed by Rabi Mishra
parent e728e8cc8e
commit dd6e887833
1 changed files with 19 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
common/deploy-steps.j2
View File

@ -565,12 +565,12 @@ outputs:
deploy_source_host: "DEPLOY_SOURCE_HOST"
tasks:
{% raw %}
- import_tasks: hiera_steps_tasks.yaml
- name: Server pre-network deployments
delegate_to: localhost
run_once: true
debug:
msg: Use --start-at-task 'Server pre-network deployments' to resume from this task
- import_tasks: hiera_steps_tasks.yaml
- include_tasks: deployments.yaml
vars:
force: false
@ -651,13 +651,13 @@ outputs:
gather_facts: "{% raw %}{{ gather_facts | default(false) }}{% endraw %}"
any_errors_fatal: true
tasks:
{% raw %}
- import_tasks: hiera_steps_tasks.yaml
- name: Server deployments
- name: Server pre deployments
delegate_to: localhost
run_once: true
debug:
msg: Use --start-at-task 'Server deployments' to resume from this task
msg: Use --start-at-task 'Server pre deployments' to resume from this task
{% raw %}
- import_tasks: hiera_steps_tasks.yaml
- include_tasks: deployments.yaml
vars:
force: false
@ -687,6 +687,11 @@ outputs:
docker_puppet_process_count: DOCKER_PUPPET_PROCESS_COUNT
docker_puppet_mount_host_puppet: DOCKER_PUPPET_MOUNT_HOST_PUPPET
tasks:
- name: Host prep steps
delegate_to: localhost
run_once: true
debug:
msg: Use --start-at-task 'Host prep steps' to resume from this task
{% raw %}
- name: Deploy Artifacts
tripleo_push_artifacts:
@ -697,19 +702,10 @@ outputs:
((deploy_artifact_files | default([]) | length) > 0)
{% endraw %}
{%- for role in roles %}
- name: {{role.name}} Host prep block
block:
- name: {{role.name}} Host prep steps
delegate_to: localhost
run_once: true
debug:
msg: Use --start-at-task '{{role.name}} Host prep steps' to resume from this task
when:
- tripleo_role_name == '{{role.name}}'
- name: {{role.name}} Host prep tasks
include_tasks: {{role.name}}/host_prep_tasks.yaml
when:
- tripleo_role_name == '{{role.name}}'
- name: {{role.name}} Host prep tasks
include_tasks: {{role.name}}/host_prep_tasks.yaml
when:
- tripleo_role_name == '{{role.name}}'
{%- endfor %}
tags:
- overcloud
@ -840,6 +836,11 @@ outputs:
docker_puppet_process_count: DOCKER_PUPPET_PROCESS_COUNT
docker_puppet_mount_host_puppet: DOCKER_PUPPET_MOUNT_HOST_PUPPET
tasks:
- name: Deploy step tasks for {{step}}
delegate_to: localhost
run_once: true
debug:
msg: Use --start-at-task 'Deploy step tasks for {{step}}' to resume from this task
- name: Write the config_step hieradata for the deploy step {{step}} tasks
{% raw %}
copy:
@ -851,11 +852,6 @@ outputs:
{% if step == 1 %}
- name: Overcloud common bootstrap tasks for step 1
block:
- name: Overcloud common bootstrap tasks for step 1
delegate_to: localhost
run_once: true
debug:
msg: Use --start-at-task 'Overcloud common bootstrap tasks for step 1' to resume from this task
- name: "Check if /var/lib/tripleo-config/container-startup-config/step_{{step}} already exists"
stat:
path: "/var/lib/tripleo-config/container-startup-config/step_{{step}}"
@ -866,11 +862,6 @@ outputs:
- ((deploy_identifier is defined and deploy_identifier != "" and deploy_identifier is not none) or
not container_startup_configs_json_stat.stat.exists)
{% endif %}
- name: Deploy step tasks for {{step}}
delegate_to: localhost
run_once: true
debug:
msg: Use --start-at-task 'Deploy step tasks for {{step}}' to resume from this task
{%- for role in roles %}
- include_tasks: "{{role.name}}/deploy_steps_tasks_step{{step}}.yaml"
when:
@ -879,11 +870,6 @@ outputs:
{%- endfor %}
- name: Overcloud common deploy step tasks {{step}}
block:
- name: Overcloud common deploy step tasks {{step}}
delegate_to: localhost
run_once: true
debug:
msg: Use --start-at-task 'Overcloud common deploy step tasks {{step}}' to resume from this task
- name: "Check if /var/lib/tripleo-config/container-startup-config/step_{{step}} already exists"
stat:
path: "/var/lib/tripleo-config/container-startup-config/step_{{step}}"