From 1eb954241bb4988e9ab6a9a74f0d277fe33726d6 Mon Sep 17 00:00:00 2001
From: Gregory Thiemonge <gthiemon@redhat.com>
Date: Wed, 25 Mar 2020 17:11:11 +0100
Subject: [PATCH] Update octavia playbooks parameters

StackAction no longer conditions generate_certs.
Forward OctaviaGenerateCerts to the playbooks and add StackAction value
as parameter, the need of creating certificates is now handled in the
ansible playbook.

Change-Id: I9aaeec1d9f8623cbd99b2f83254dda038651f0a2
Related-Bug: #1849548
(cherry picked from commit 648cde501eb31766ed333f48ac1f6a4854b26c41)
(cherry picked from commit 5f336195f622c0191eb7cc432ff49a81a9d97e3b)
---
 deployment/octavia/octavia-deployment-config.j2.yaml | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/deployment/octavia/octavia-deployment-config.j2.yaml b/deployment/octavia/octavia-deployment-config.j2.yaml
index 53e4422cbe..1315cfc1f2 100644
--- a/deployment/octavia/octavia-deployment-config.j2.yaml
+++ b/deployment/octavia/octavia-deployment-config.j2.yaml
@@ -204,13 +204,6 @@ conditions:
       - raw
     - get_param: NovaEnableRbdBackend
 
-  generate_certs:
-      and:
-      - get_param: OctaviaGenerateCerts
-      - equals:
-        - get_param: StackAction
-        - CREATE
-
 resources:
 {% if not octavia_standalone %}
   default_key_pair:
@@ -251,7 +244,7 @@ resources:
           server_certs_key_passphrase: {get_param: OctaviaServerCertsKeyPassphrase}
           ca_passphrase: { get_param: OctaviaCaKeyPassphrase }
           client_cert_path: { get_param: OctaviaClientCertFile }
-          generate_certs: {if: [generate_certs, true, false]}
+          generate_certs: { get_param: OctaviaGenerateCerts }
           mgmt_port_dev: { get_param: OctaviaMgmtPortDevName }
           os_password: { get_param: AdminPassword }
           os_project_name: 'admin'
@@ -263,6 +256,7 @@ resources:
           octavia_group_vars_dir: "{{playbook_dir}}/octavia-ansible/group_vars"
           container_cli: { get_param: ContainerCli }
           enable_log_offloading: { get_param: OctaviaLogOffload }
+          stack_action: { get_param: StackAction }
 
 outputs:
   role_data: