Add OVS-DPDK parameter as part of roles file

Adding mandatory OVS-DPDK parameter to the roles file instead of
environment file, as it requires to be added for each custom role.

Closes-Bug: #1780932
Change-Id: I33fa198228e3e3adcb8e93146d9a9caa46a28895
(cherry picked from commit e7d39847bc)

environments/ovs-dpdk-permissions.yaml

@@ -1,3 +1,7 @@
+# DEPRECATED, this parameter is added as part of the roles/ComputeOvsDpdk.yaml
+# to include it by default for all OvS-DPDK roles. This environment file is
+# obsolete and will be removed in S release.
+#
 # This permission changes should be applied only on the fresh deployment of
 # queens, minor updates in queens (and future) and then upgrades from queens
 # to future versions.

releasenotes/notes/ovs-dpdk-perms-deprecate-cfddb148fce9656d.yaml

@@ -0,0 +1,7 @@
+---
+deprecations:
+  - |
+    Environment file ``ovs-dpdk-permissions.yaml`` is deprecated and the
+    mandatory parameter ``VhostuserSocketGroup`` is added to the roles data
+    file of the missing OvS-DPDK role. Using this environment file is
+    redundant and it will be removed in S-release.

roles/ComputeOvsDpdk.yaml

@@ -13,6 +13,7 @@
   disable_upgrade_deployment: True
   deprecated_nic_config_name: 'compute-dpdk.yaml'
   RoleParametersDefault:
+    VhostuserSocketGroup: "hugetlbfs"
     TunedProfileName: "cpu-partitioning"
   ServicesDefault:
     - OS::TripleO::Services::Aide