Zaqar was deprecated in Wallaby and is no longer in use on the
undercloud and it hasn't been officially supported in the
overcloud for some time.
Change-Id: I3bdcc72d6127ec96ff2307cafbf57f6178c3ef5c
Mistral was deprecated in Wallaby and is no longer in use on the
undercloud and it hasn't been officially supported in the overcloud for
some time.
Change-Id: I6963453f53cb554ca8fdb58706f04838bbd11ba0
Manila's wallaby release [1] made it possible for the v2 endpoint to
not include a tenant_id (project_id). This change was made to
accommodate interactions by system scoped users.
System scoped users cannot interact with an endpoint that needs
the "tenant_id" templating, because system scoped tokens cannot be
resolved to a particular tenant_id by definition. More information
regarding this change is captured in the release notes for
the project [2] and the API reference [3].
[1] https://review.opendev.org/c/openstack/manila/+/773709
[2] https://docs.openstack.org/releasenotes/manila/wallaby.html#prelude
[3] https://docs.openstack.org/api-ref/shared-file-system/#shared-file-systems-api
Co-Authored-By: Goutham Pacha Ravi <gouthampravi@gmail.com>
Change-Id: I85aec373e86ab587ead389852730bcf833311ae4
In I08fa1ee947574e6fac24885b17706a22054fcba9 we added sync of
NovaLibvirtNetwork and NovaVncProxyNetwork. This just adds a
comment for this.
Change-Id: If8c74d5c00fb6b31de98917b984a376fc192ff53
In Icef2481b65b41b524ad44eeecfbee4451006e1d2 we moved to use
NovaLibvirtNetwork as the single network to configure instance console
components.
Due to how hieradata is being rendered via tripleo-hieradata, the
removed NovaVncProxyNetwork resulted in no-vnc-proxy service to
fall back to the control plane network because NovaVncProxyNetwork
was removed.
NovaVncProxyNetwork was then reintroduced with
I595294956a4a7a0e2280c685ac1d2543edbc32f2 but as a side effect
again introduced the inconsistency on the console configuration.
This patch removes the NovaVncProxyNetwork from ServiceNetMap
but set it as part of service_net_map.j2.yaml and keep it in
sync with NovaLibvirtNetwork.
Change-Id: I08fa1ee947574e6fac24885b17706a22054fcba9
Closes-Bug: #1917719
Jinja2 rendering failed when using network-v2 format
because the network_data yaml does not include the
ip_subnet key at the network level.
Default network.ip_subnet to "" in the places were it
does not have a the default already.
These templates are not used with network-v2.
Closes-Bug: #1929835
Change-Id: Ib4d0551d99afd55fbb513f8c5050fb835dc332b4
The legacy parameters (e.g InternalApiNetCidr) default to the new
network_data.yaml values.
When ManageNetworks: true the value of these parameters is then used to
create the network resources. The cidr attribute of the resources are
then used to build the network_cidrs output value resulting in the
correct list of cidrs.
However when Managenetworks: false the resources are not created so an
alternative approach is required. Currently only the values from
network_data.yaml are used. If the legacy parameters are being used in
a deployment this will result in the cidrs from the default
t-h-t/network_data.yaml instead of the values from the heat parameters.
This can result in live migration failure as the firewall subnet is
incorrect on compute nodes.
To resolve this we can just use the value from the legacy params to
build the cidr list when ManageNetworks: false. There is also an
unnecessary list_concat which can be removed.
Closes-bug: 1929470
Change-Id: Ibe5f9ec4dc32a6e8277e95032e608209a035cad5
This simplifies the ServiceNetMap/VipSubnetMap interfaces
to use parameter merge strategy and removes the *Defaults
interfaces.
Change-Id: Ic73628a596e9051b5c02435b712643f9ef7425e3
Icef2481b65b41b524ad44eeecfbee4451006e1d2 removed the NovaVncProxyNetwork
from network/service_net_map.j2.yaml, but due to how hieradata is
being rendered via tripleo-hieradata, the hieradata for the no-vnc-proxy
service falls back to the control plane network.
Change-Id: I595294956a4a7a0e2280c685ac1d2543edbc32f2
Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1960401
Adds a tag tripleo_role=$ROLE to neutron ports
created by heat.
Related: blueprint network-data-v2-ports
Change-Id: I238572444e2931546d44864b2de497dd2825c2dc
Commit cea78ad4fd added DefaultRoute as a
property of the port resources, but it was missed adding it as a
parameter of deployed_port.j2.
Change-Id: I8235220cc0d1d699ac2abf993d6c49494613bdac
Signed-off-by: James Slagle <jslagle@redhat.com>
This change introduces the new RabbitmqEnableManagementAccess parameter
so that operators can expose management plugin to specific network to
monitor status over network.
Change-Id: I09c62af87481e131c26c9d5f9faa16be349347b0
With change I20d48b3a29193dbcb70ec5cb13daf153bb0aeff2
we need to define the DefaultRoute parameter in the
noop.yaml port template.
Change-Id: I0df6116e41e5c9932ec5876dbde409f6fdd5de13
With change I603521bd00dc100e03c765c25503b5e01f3383e4
the ManageNetworks == False use case was overlooked.
When ManageNetworks is set to False and networks are
not created we need to build network_attrs and
subnet_attrs from the data present in network_data.yaml
and parameters.
Closes-Bug: #1920050
Change-Id: I98a3d582add0d6881cd39433ddb25515f0e0dc31
The ansible module to manage networks sets the name
upper as a tag hint on the neutron network resources.
tripleo_ansible/ansible_plugins/modules/tripleo_composable_network.py#L124
This change adds this tag for Heat managed networks as
well.
Change-Id: I717b06a0578dccca0e2152f6d454ad7a96cff8fb
Partial-Implements: blueprint network-data-v2-ports
Set up tag hints on all OS::Neutron::Port resources.
The network-data-v2 work uses tags on neutron resources
to find existing resources so that we update instead
of create. Also for generating environment files info
in the neutron tag field is utilized.
Partial-Implements: blueprint network-data-v2-ports
Change-Id: I3d43ae22cc45e5528ecfb1a6b2cb8602faa162a0
With I57047682cfa82ba6ca4affff54fab5216e9ba51c Heat has added
a new template version for wallaby. This would allow us to use
2-argument variant of the ``if`` function that would allow for
e.g. conditional definition of resource properties and help
cleanup templates. If only two arguments are passed to ``if``
function, the entire enclosing item is removed when the condition
is false.
Change-Id: I25f981b60c6a66b39919adc38c02a051b6c51269
Adds a tag tripleo_default_route=$BOOL to neutron ports
created by heat indicating if the ports interface is
used for the default route.
The value is controlled by the 'default_route_networks'
in roles data.
With network-data-v2 the same tag will be used to
set up ansible vars appropriately. Having the heat driven
process add the tag can be useful for upgrade/migration
automation.
Related: blueprint network-data-v2-ports
Change-Id: I20d48b3a29193dbcb70ec5cb13daf153bb0aeff2
The tags field in neutron has a max length of
60 characters. A hostname can be longer, and in
the case it is longer adding the tag will cause
a "Invalid input exceeds maximum length of 60"
error will be raised.
Related-Bug: #1921713
Change-Id: I72fd4a9575482389900145a03a6142cccd1111ba
This patch addes TripleO support for the Unbound DNS resolver service.
This service will initially be used by the Designate service.
Change-Id: I8135ce4f344aeb7c0cf7521e0ba42335c4c7bbc8
Nova vnc configuration right now uses NovaVncProxyNetwork,
NovaLibvirtNetwork and NovaApiNetwork to configure the different
components (novnc proxy, nova-compute and libvirt) for vnc.
If one of the networks get changed from internal_api, the service
configuration between libvirt, nova-compute and novnc proxy gets
inconsistent and the console is broken.
This changed to just use NovaLibvirtNetwork for configuring the vnc
endpoints and removes NovaVncProxyNetwork completely.
Change-Id: Icef2481b65b41b524ad44eeecfbee4451006e1d2
Closes-Bug: #1917719
Add a new deployed_vip_port template which will replace
the current neutron port templates when vip ports are
managed outside of the heat stack.
Change-Id: Ia1f7e344ccebb2291f1574fdb69c05f00f4c3dc9
Partial-Implements: blueprint network-data-v2-ports
The current jinja2 code results in the same value no matter
what is in _service_nets so it really has no effect. We can
just as well hard-code the values, which is what this change
does.
Change-Id: I2b212bec170cc93c40f81050d11f696275d8b1ea
When using the multiple nic-config templates in THT
and in tripleo-ansible the ordering of networks in
the network_data file matters.
Add a a tag 'tripleo_net_idx' to neutron resources
to keep track of the ordering.
Depends-On: https://review.opendev.org/772795
Partial-Implements: blueprint network-data-v2-ports
Change-Id: I0d39ea713ce1201b60f3def69f453792e402eb33
Add a new deployed_port template which will replace
the current neutron port templates when ports are
managed outside of the heat stack.
Partial-Implements: blueprint network-data-v2-ports
Change-Id: Ia71b74e80122e6a12d4f88a90ede02d39763914e
Tag was added to neutron port resources in:
https://review.opendev.org/c/openstack/tripleo-heat-templates/+/761845
Tag's previously added was pefixed with 'tripleo_'. This
change adds the 'tripleo_' prefix to the tags on neutron
port resources as well.
Partial-Implements: blueprint network-data-v2-ports
Change-Id: I0fa2230ae4f8ff4fdc6fc4b79e7bdcf3bdff342f
In perparation for trainsition from composable network
ports managed by heat, to composable network ports
managed with other tooling.
The upgrade prepare step need to set ``PortDeletionPolicy``
to 'retain', so that network ports are not deleted when
running converge.
Change-Id: I16281faefdf68fcaee4c51caa47516ea7084418b
Partial-Implements: blueprint network-data-v2-ports
Add a template for deployed networks, pre-deployed
network info in DeployedNetworkEnvironment parameter.
Use templates for 'OS::TripleO::Network' in resource
registry.
Depends-On: https://review.opendev.org/753195
Depends-On: https://review.opendev.org/751875
Change-Id: Id42486b513bef74525c1aa7204de979704e06ace
Set tag's with the stack name and the hostname
on composable network node ports. The tags will
be used by network-data-v2 with port management
handled outside of heat.
Change-Id: I23c600c1754d463028259a7dc2c6e5538c512ca4
This removes all in-tree nic config templates as we've migrated
them. Users can still use copy of those (modified/un-modified).
Change-Id: Ie0be19e416058d33dbe758ebb2a06e55c651a7e9
Sahara support was deprecated during previous Ussuri cycle[1], so we
can remove it completely now.
[1] f1d9b15c85
Change-Id: Id047221cb912c09984cc3bf864196a26fd36736f
Role names can be customized, yet in THT jinja2 we
have several places where conditions are based on
the role name. By using tag's such as 'storage',
'ceph' and 'ovsdpdk' we the role names become truly
customizable.
The depends-on change in TripleO common will
dynamically add tag's to role's based on role.name
for backward compatibility during deprecation
period.
Depends-On: https://review.opendev.org/758124
Change-Id: I5ab4e4a220294245f95d328391bfffec87781a09
In https://review.opendev.org/722241 the service net map
HostnameResolveNetwor was fixed for roles that don't have
the InternalApi network. This follows up and fixes the
same issue for MetricsQdrNetwork and Ceph roles as well.
Also re-factor the jinja2 to iterate only once over the
roles.
Related-Bug: #1874330
Change-Id: Iff0e30a6c52fea75449dbd228dec45f708036f9f
Previoously the default route was concatenated with the
host_routes in the NetworkConfig. This change moves that
concatenation to overcloud.yaml.
GroupVars {{network.name_lower}}_host_routes and
ctlplane_host_routes will have the default route appended
based on role.default_route_networks setting.
For heat base NetworkConfig the parameters
ControlPlaneStaticRoutes and {{network.name}}InterfaceRoutes
will have the default route appropriately appended.
Doing the concatenation in overcloud.yaml enable simplified
user-facing NetworkConfig templates.
For standalone and undercloud define the default_route_networks
with an empty list. Cannot leave it undefined as this will
default the default route to the ctlplane's gateway. Undercloud
and Standalone uses the management interface as the gateway by
default, so we should not set a default gateway for these roles.
Change-Id: I3a35c4b46536fa2916d9fa387278077884adaf68
We changed in https://review.opendev.org/#/c/752922/ to expose
network and subnet attributes for GroupVars. However,
heat does not expose all atrributes for network/subnet ie. tags
for subnets. Use the 'show' base attributes to get all attributes
from neutron.
Change-Id: Idc14ac2ce77904ed182385d248047e7afe2ad0ab
In preparation for trainsition from composable networks
managed by heat, to composable networks managed with other
tooling.
The upgrade prepare step need to set this to 'retain', so
that networks are not deleted when running converge.
Change-Id: Ib65d74a2005fbc13cbc7916e646da65d99410adb
* Clean up port resoures outputs that is no longer
required since we get it of the network attributes
map instead. The removed outputs are mtu, host_routes,
gateway_ip, cidr
* Drop usage of parameter ``ControlPlaneSubnetCidr`` in
overcloud.yaml, get it from net_attributes_map instead,
* Remove old notes regarding parameters we don't need to
set in network-environment files.
* Remove DnsServers from network-environment files.
Nameservers should be defined in undercloud.conf, either
globally with undercloud_nameservers, or per-control plane
subnet using the dns_nameservers option in the subnet group.
(I don't think we can deprecate the param entirely, cause
standalone ...)
Change-Id: I31154448603ccbba692282c44511d963ca9b6d0e
Both Grafana and the Ceph Dashboard when deployed by ceph-ansible
will be always listening on the storage frontend network.
Change-Id: I3481ddfeeb5603e0e31e4afd26e4218df5defd11
Add the attributes of ctlplane network and subnets to
the output of the Networks resource.
Also, set 'ctlplane_mtu' in group_vars. Follow-up changes
will add other ctlplane subnet attributes to group_vars.
The ctlplane attributes are added to the plan environment
by the depends-on tripleoclient change.
Depends-On: https://review.opendev.org/753195
Change-Id: Ic1772b384ad5b2003563b4e3d41a4a2f0e82f8e6
The new ansible os_net_config does not replace the interface_name
and bridge_name variables in net config. This replaces those
variables beforehand.
Though it would have been good to handle it in module itself, in
the proposed way to generate these configs with ansible would
allow us to replace them with group_vars.
Change-Id: I2049d3ce2ad10507fd846d3876e20cc3ec4b9fbe
Closes-Bug: #1896829
In the Networks resource tempaltes add the full resource
attributes to net_attributes_map.
Use the attributes to build per-role GroupVars.
Change-Id: I603521bd00dc100e03c765c25503b5e01f3383e4
Move the OVNMacAddressNetwork resource out of the
Networks resource. This is a special network that
we want to create internally.
Having this network nested in the Networks resource
interfer with the work related to creating composable
networks with non-heat tooling.
Change-Id: I5551af42bc87fb8489edbfbd2abadba3dca30b0b
This removes the run-os-net-config.sh script and uses
OS::Heat::Value for the NetworkConfig resources.
Depends-On: https://review.opendev.org/#/c/751713/
Change-Id: Ic3a0234d36525cdd6f415c77733d05a39bbeb3c2
This uses the new ansible module for network configuration
on the nodes. Aso, converts the net-config-multinode.yaml to
use os-net-config.
Next patch in this series would change the NetworkConfig
resource type to OS::Heat::Value and drop run-os-net-config.sh.
Depends-On: https://review.opendev.org/748754
Change-Id: Ie48da5cfffe21eee6060a6d22045d09524283138
Working on a tool to extract deployed networks from an existing
heat stack, adding this information so that it's available for
export.
Also when (if) we remove OS::Neutron::Net, OS::Neutron::Subnet
resources from THT storing this state in the neutron networks
will make it possible to recreate network_data in case the file
is deleted.
Depends-On: https://review.opendev.org/750662
Change-Id: I696afb8f24cc2fdeb17aaef1d3bc3a5fc22a8dcd
This should not be needed, other jobs use the net-config-multinode.yaml
file, let's get rid of net-config-multinode-os-net-config.yaml for
consistency and also in order to ger rid of the network_config_hook()
function that should not be needed anymore.
Change-Id: Ic95d84e611164dc5e28bc182b92991a317bae567
A network used to allocate MAC addresses for OVN chassis.
Ports without and IP allocation will be created on this
network, the MAC addresses of the ports will by used to
configure the ovn-chassis-mac-mappings.
NOTE, we may want to change the 'base_mac' option of the
undercloud, so that we don't have collissions with the
overcloud 'base_mac'.
Related-Bug: #1881593
Change-Id: If495b5d5c1e6beff02b48507051cccfb70fd995c
The Ceph dashboard net was statically mapped to ctlplane which is
a sane default except when storage_dashboard is set precisely to
customize the listening network.
This change ensures we consume storage_dashboard when set instead
of using always ctlplane.
Change-Id: If293b20c29b74158ecdee4e47e97535baefde72c
Alex Schultz
Takashi Kajinami
Martin Schuppert
ramishra
Harald Jensås
Oliver Walsh
James Slagle
Michael Johnson
Giulio Fidente
Emilien Macchi