tripleo-heat-templates/9565da0ed79cbfe76132b58aca3eda2333a6624b

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "2d160acd_67bf8dcf",
        "filename": "ci/environments/standalone-ipa.yaml",
        "patchSetId": 2
      },
      "lineNbr": 19,
      "author": {
        "id": 6926
      },
      "writtenOn": "2022-04-13T13:05:07Z",
      "side": 1,
      "message": "is this ok to remove dnsservers config options but keep dns search domains?",
      "revId": "9565da0ed79cbfe76132b58aca3eda2333a6624b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "402c59ce_842818b5",
        "filename": "ci/environments/standalone-ipa.yaml",
        "patchSetId": 2
      },
      "lineNbr": 19,
      "author": {
        "id": 30073
      },
      "writtenOn": "2022-05-11T06:23:53Z",
      "side": 1,
      "message": "I also second this. Are we going to hit the same issues with this param? If so, we should be deprecating and removing both of them?",
      "parentUuid": "2d160acd_67bf8dcf",
      "revId": "9565da0ed79cbfe76132b58aca3eda2333a6624b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "61cfe768_c54cab15",
        "filename": "ci/environments/standalone-ipa.yaml",
        "patchSetId": 2
      },
      "lineNbr": 19,
      "author": {
        "id": 24245
      },
      "writtenOn": "2022-06-02T09:35:34Z",
      "side": 1,
      "message": "DnsSearchDomains will kind of hit the same issue, only if `dns_search_domains` is defined in baremetal deployment YAML definitions[1] `network_config` section.\n\nWhen the inventory is generated, we do it in stages:\n\n  #1 From information in neutron, as well as some files on the filesystem.\n  #2 From the ephemeral heat stack.\n\nThe code uses setdefault(), so in the case the value for a variable is available in the stage #1 this value is used in the inventory. In the case that `dns_search_domains` are defined in the baremetal deployment YAML definition[1] the `DnsSearchDomains` will be ignored. If `dns_search_domains` is not defined in the bm-deploy YAML `DnsSearchDomains` will be in the used to set the value in the inventory.\n\n\nNOTE: If you don\u0027t set `dns_search_domains` in bm-deploy YAML the flag to enable network config update must be enabled to ensure the search domain is updated when config-download run the playbooks.\n\n[1] https://docs.openstack.org/project-deploy-guide/tripleo-docs/latest/provisioning/baremetal_provision.html#network-config-properties",
      "parentUuid": "402c59ce_842818b5",
      "revId": "9565da0ed79cbfe76132b58aca3eda2333a6624b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "24b99126_f4fc5a4d",
        "filename": "ci/environments/standalone-ipa.yaml",
        "patchSetId": 2
      },
      "lineNbr": 19,
      "author": {
        "id": 6926
      },
      "writtenOn": "2022-06-03T13:11:36Z",
      "side": 1,
      "message": "Ack",
      "parentUuid": "61cfe768_c54cab15",
      "revId": "9565da0ed79cbfe76132b58aca3eda2333a6624b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "6dfb09cb_12405aee",
        "filename": "environments/standalone/standalone-tripleo.yaml",
        "patchSetId": 2
      },
      "lineNbr": 28,
      "author": {
        "id": 6926
      },
      "writtenOn": "2022-04-13T13:04:04Z",
      "side": 1,
      "message": "I believe this remains to be a boolean?",
      "revId": "9565da0ed79cbfe76132b58aca3eda2333a6624b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "c62c480c_c691486f",
        "filename": "environments/standalone/standalone-tripleo.yaml",
        "patchSetId": 2
      },
      "lineNbr": 28,
      "author": {
        "id": 6926
      },
      "writtenOn": "2022-06-03T13:11:36Z",
      "side": 1,
      "message": "what about this one?",
      "parentUuid": "6dfb09cb_12405aee",
      "revId": "9565da0ed79cbfe76132b58aca3eda2333a6624b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "ba15ecae_792ac575",
        "filename": "environments/standalone/standalone-tripleo.yaml",
        "patchSetId": 2
      },
      "lineNbr": 28,
      "author": {
        "id": 24245
      },
      "writtenOn": "2022-06-03T17:25:56Z",
      "side": 1,
      "message": "yes, it does. Done.",
      "parentUuid": "c62c480c_c691486f",
      "revId": "9565da0ed79cbfe76132b58aca3eda2333a6624b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}