To follow on from I2e88dc34fa59624523de4c52a1873438c78e972f we now
normalise all the resource upgrade tasks to improve idempotency and
speed up the process of verifying and upgrading images as necessary.
In doing so we clean up a few things as well:
1. There were some unnecessary blocks present without conditions
or any shared properties for the tasks.
2. Use 'failed_when: false' rather than 'ignore_errors: true'
because ignoring errors shows a failed task which is confusing
to users.
3. Some tasks had an empty conditional.
This patch includes the backport of https://review.opendev.org/691837
Conflicts below are due to stable/stein missing
https://review.opendev.org/651550:
>------deployment/cinder/cinder-backup-pacemaker-puppet.yaml
>------deployment/manila/manila-share-pacemaker-puppet.yaml
>------deployment/ovn/ovn-dbs-pacemaker-puppet.yaml
Change-Id: I8b5b25d03b86b2c44b2d47e5a0624e7dd13873da
Related-Bug: #1838971
Closes: rhbz#1758578
(cherry picked from commit dfd8b73004)
165036cee3