The best effort pre-upgrade online data migrations were an attempt to
mitigate possible user errors if users forget to run the online data
migrations explicitly during the previous upgrade. However, they ended
up causing more problems than good:
* If user follows docs, they are unnecessary.
* If the containers for the services aren't running, they will get
silently ignored already. This was done to facilitate re-runs of
failed upgrade steps and prevent false failures. If the upgrade
includes an operating system change, the pre-upgrade migrations will
simply not run.
* However, if the containers for the services are running but the
database is not running or is not functional for some reason, the
migration will be attempted and the upgrade will get stuck. This
leads to confusing errors not really related to the root cause of
the problem, and non-straightforward breakages where the fix might
otherwise be just to re-run the upgrade.
For the above reasons this commit removes the pre-upgrade just-in-case
online data migrations. We should be running them only as documented
in the upgrade workflow.
Change-Id: I5d3cc863f138d4f1a915e8a2060dd9ed1d577f37
Closes-Bug: #1841590
cd23d2054e