add some missing “set -ue” declarations

Since 79ab95b16e78d563c473b5acada62cb3e22d4eb1 dib-lint ensure
every element shell scripts have “set -e” activated.

Even if dib-lint doesn't test it yet, the set -u is already widely
used.

As pointed out by Jiri Stransky, elements/tripleo-cd/configs/* files
are sourced by deploy-testenv. There is no reason to enable “set -ue”
manually. The patch just disable the dib-lint “sete” check on these files.

Change-Id: I118c8c80ec50b265c22577b075d15f56389b7a47

elements/bm-dnsmasq/install.d/75-filter-bootps-cronjob

@@ -1,4 +1,6 @@
 #!/bin/bash
+set -ue
+
 install -m 0755 -o root -g root $(dirname $0)/../bin/filter-bootps /usr/local/bin/filter-bootps
 cat > /etc/cron.d/filter-bootps <<EOF
 # Ensure we don't answer BOOTP for bare metal nodes not registered with nova.

elements/glance/os-refresh-config/configure.d/10-glance-state

@@ -1,4 +1,6 @@
 #!/bin/bash
+set -ue
+
 [ -d /mnt/state/var/lib/glance ] || install -d -D -m 0770 -o glance -g glance /mnt/state/var/lib/glance
 [ -d /mnt/state/var/lib/glance/images ] || install -d -D -m 0770 -o glance -g glance /mnt/state/var/lib/glance/images
 [ -d /mnt/state/var/log/glance ] || install -d -D -m 0755 -o glance -g glance /mnt/state/var/log/glance

elements/heat-api/os-refresh-config/post-configure.d/79-heat-api

@@ -1,4 +1,5 @@
 #!/bin/bash
+set -ue
 
 os-svc-enable -n heat-api
 os-svc-enable -n heat-api-cfn

elements/heat-engine/install.d/20-heat-crontab

@@ -1,4 +1,6 @@
 #!/bin/bash
+set -ue
+
 # If https://bugs.launchpad.net/heat/+bug/1239377 is ever fixed we can
 # configure heat to purge automatically and remove this.
 cat <<EOF > /etc/cron.d/heat

elements/mariadb-dev/environment.d/20-mariadb

@@ -1,4 +1,5 @@
 #!/bin/bash
+set -ue
 
 # The mariadb download url arch values are not the same as ours
 if [ $ARCH = "i386" ]; then

elements/mysql/environment.d/20-percona

@@ -1,4 +1,5 @@
 #!/bin/bash
+set -ue
 
 # The percona download url arch values are not the same as ours
 if [ $ARCH = "amd64" ]; then

elements/neutron-openvswitch-agent/install.d/90-disable-upstart-network-interface-logging

@@ -1,4 +1,6 @@
 #!/bin/bash
+set -ue
+
 # potentially thousands of network interfaces on the system, we don't
 # want to overwhelm upstart with log pipes. This sends all of it to the
 # system console.

elements/neutron-ovs-cleanup/install.d/neutron-source-install/81-neutron-ovs-cleanup

@@ -1,4 +1,5 @@
 #!/bin/bash
+set -ue
 set -x
 
 SCRIPTDIR=$(dirname $0)

elements/neutron-server/install.d/neutron-source-install/80-neutron-server

@@ -1,3 +1,5 @@
 #!/bin/bash
+set -ue
+
 os-svc-daemon -i "$NEUTRON_VENV_DIR" neutron-server neutron neutron-server \
     "--config-file /etc/neutron/neutron.conf  --config-file /etc/neutron/plugins/ml2/ml2_conf.ini --config-dir /etc/neutron"

elements/nova/os-refresh-config/configure.d/10-nova-state

@@ -1,4 +1,6 @@
 #!/bin/bash
+set -ue
+
 [ -d /mnt/state/var/lib/nova ] && exit 0
 install -D -d -o nova -g nova -m 0775 /mnt/state/var/lib/nova
 [ -d /mnt/state/var/log/nova ] && exit 0

elements/ntp/install.d/50-ntp

@@ -1,3 +1,5 @@
 #!/bin/bash
+set -ue
+
 # ntpdate is used when the network is brought up to correct any large time skew
 install-packages ntp ntpdate

elements/openstack-clients/environment.d/10-openstack-clients-venv-dir.bash

@@ -1,4 +1,5 @@
 #!/bin/bash
+set -ue
 
 # ceilometerclient
 if [ -z "${CEILOMETERCLIENT_VENV_DIR:-}" ]; then

elements/os-apply-config/os-refresh-config/configure.d/50-os-config-applier

@@ -1,2 +1,4 @@
 #!/bin/bash
+set -ue
+
 exec os-apply-config

elements/qpidd/install.d/20-qpidd

@@ -1,4 +1,5 @@
 #!/bin/bash
+set -ue
 
 install-packages qpidd qpid-tools qpid-client
 

elements/tripleo-cd/configs/te_commonrc

@@ -1,4 +1,5 @@
 #!/bin/bash
+# dib-lint: disable=sete
 
 source $TRIPLEO_ROOT/tripleo-incubator/scripts/set-os-type
 if [ $TRIPLEO_OS_DISTRO = "fedora" ] ; then

elements/tripleo-cd/configs/te_hp1rc

@@ -1,4 +1,5 @@
 #!/bin/bash
+# dib-lint: disable=sete
 
 export TRIPLEO_ROOT="$(readlink -f $(dirname $0)/../../../..)"
 source $(dirname ${BASH_SOURCE})/te_commonrc

elements/tripleo-cd/configs/te_localrc

@@ -1,4 +1,5 @@
 #!/bin/bash
+# dib-lint: disable=sete
 
 export TRIPLEO_ROOT="$(readlink -f $(dirname $0)/../../../..)"
 source $(dirname ${BASH_SOURCE})/te_commonrc

elements/tripleo-cd/configs/te_rh1rc

@@ -1,4 +1,5 @@
 #!/bin/bash
+# dib-lint: disable=sete
 
 export TRIPLEO_ROOT="$(readlink -f $(dirname $0)/../../../..)"
 source $(dirname ${BASH_SOURCE})/te_commonrc