openstack/tripleo-ipsec
Code Issues Proposed changes

ansible-lint: Use shell only when shell functionality is required

Browse Source 
Switches the hiera calls to use command instead of shell.
This commit is contained in:
Juan Antonio Osorio Robles 2017-11-21 11:33:20 +00:00
parent 9368f27ee7
commit 5c5e2fe931
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tasks/hardcoded-network-discover.yml
View File

@ -46,27 +46,27 @@
# between nodes with these. We only need the VIP # between nodes with these. We only need the VIP
- name: Get the overcloud internal API VIP address - name: Get the overcloud internal API VIP address
shell: hiera -c /etc/puppet/hiera.yaml internal_api_virtual_ip command: hiera -c /etc/puppet/hiera.yaml internal_api_virtual_ip
register: internalapi_vip_register register: internalapi_vip_register
changed_when: false changed_when: false
- name: Get the overcloud redis VIP address - name: Get the overcloud redis VIP address
shell: hiera -c /etc/puppet/hiera.yaml redis_vip command: hiera -c /etc/puppet/hiera.yaml redis_vip
register: redis_vip_register register: redis_vip_register
changed_when: false changed_when: false
- name: Get the overcloud storage VIP address - name: Get the overcloud storage VIP address
shell: hiera -c /etc/puppet/hiera.yaml storage_virtual_ip command: hiera -c /etc/puppet/hiera.yaml storage_virtual_ip
register: storage_vip_register register: storage_vip_register
changed_when: false changed_when: false
- name: Get the overcloud storagemgmt VIP address - name: Get the overcloud storagemgmt VIP address
shell: hiera -c /etc/puppet/hiera.yaml storage_mgmt_virtual_ip command: hiera -c /etc/puppet/hiera.yaml storage_mgmt_virtual_ip
register: storagemgmt_vip_register register: storagemgmt_vip_register
changed_when: false changed_when: false
- name: Get the overcloud ctlplane VIP address - name: Get the overcloud ctlplane VIP address
shell: hiera -c /etc/puppet/hiera.yaml controller_virtual_ip command: hiera -c /etc/puppet/hiera.yaml controller_virtual_ip
register: ctlplane_vip_register register: ctlplane_vip_register
changed_when: false changed_when: false