Ensure that each role in extras has a dependency on extras-common

As more ansible variables are shared or reused across roles it is
important to define these variables in a role that is always
executed.  In this case that role is extras-common.

Note: This review is a blocker for https://review.openstack.org/#/c/418998/

Change-Id: I31fd13d7bcb98d73e7f16048c57c027d95faeec5

roles/baremetal-prep-overcloud/meta/main.yml

@@ -0,0 +1,3 @@
+dependencies:
+  - extras-common
+

roles/baremetal-prep-virthost/meta/main.yml

@@ -0,0 +1,3 @@
+dependencies:
+  - extras-common
+

roles/baremetal-undercloud/meta/main.yml

@@ -0,0 +1,3 @@
+dependencies:
+  - extras-common
+

roles/build-test-packages/meta/main.yml

@@ -0,0 +1,3 @@
+dependencies:
+  - extras-common
+

roles/collect-logs/meta/main.yml

@@ -0,0 +1,3 @@
+dependencies:
+  - extras-common
+

roles/extras-common/defaults/main.yml

@@ -2,3 +2,10 @@ overcloud_ipv6: false
 containerized_overcloud: false
 overcloud_templates_path: /usr/share/openstack-tripleo-heat-templates
 
+# TODO(hrybacki): remove after https://review.openstack.org/#/c/418998/ merges
+# The overcloud-deploy role had a dependency on the tripleo role (no longer
+# exists) which depdended on the common role which /has/ `enable_pacemaker`.
+# this workaround can be removed after https://review.openstack.org/#/c/413800/
+# is merged creating a dependency chain common<-extras-common<-overcloud-deploy
+enable_pacemaker: false
+

roles/gate-quickstart/meta/main.yml

@@ -0,0 +1,3 @@
+dependencies:
+  - extras-common
+

roles/ovb-manage-stack/meta/main.yml

@@ -0,0 +1,3 @@
+dependencies:
+  - extras-common
+

roles/overcloud-prep-config/meta/main.yml

@@ -1,2 +1,3 @@
 dependencies:
   - extras-common
+

roles/overcloud-prep-flavors/meta/main.yml

@@ -1,3 +1,2 @@
 dependencies:
-  - libvirt
-  - tripleo
+  - extras-common

roles/overcloud-prep-images/meta/main.yml

@@ -1,3 +1,2 @@
 dependencies:
-  - libvirt
-  - tripleo
+  - extras-common

roles/overcloud-prep-network/meta/main.yml

@@ -1,4 +1,2 @@
 dependencies:
-  - libvirt
-  - tripleo
   - extras-common

roles/overcloud-scale/meta/main.yml

@@ -0,0 +1,3 @@
+dependencies:
+  - extras-common
+

roles/overcloud-ssl/meta/main.yml

@@ -1,2 +1,3 @@
 dependencies:
   - extras-common
+

roles/overcloud-upgrade/meta/main.yml

@@ -1,31 +1,3 @@
----
-#   Copyright Red Hat, Inc. All Rights Reserved.
-#
-#   Licensed under the Apache License, Version 2.0 (the "License"); you may
-#   not use this file except in compliance with the License. You may obtain
-#   a copy of the License at
-#
-#       http://www.apache.org/licenses/LICENSE-2.0
-#
-#   Unless required by applicable law or agreed to in writing, software
-#   distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-#   WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-#   License for the specific language governing permissions and limitations
-#   under the License.
-#
+dependencies:
+  - extras-common
 
-galaxy_info:
-  author: redhat-openstack
-  description: Ansible set of tasks for upgrading Tripleo-Overcloud
-  company: Red Hat
-  license: Apache2
-  min_ansible_version: 2.0.0
-  platforms:
-    - name: EL
-      versions:
-        - all
-  categories:
-    - cloud
-    - python
-    - development
-    - openstack

roles/repo-setup/meta/main.yml

@@ -0,0 +1,3 @@
+dependencies:
+  - extras-common
+

roles/undercloud-deploy/meta/main.yml

@@ -1,3 +1,2 @@
 dependencies:
-  - libvirt
-  - tripleo
+  - extras-common

roles/validate-ha/meta/main.yml

@@ -0,0 +1,3 @@
+dependencies:
+  - extras-common
+

roles/validate-ipmi/meta/main.yml

@@ -0,0 +1,3 @@
+dependencies:
+  - extras-common
+

roles/validate-simple/meta/main.yml

@@ -0,0 +1,2 @@
+dependencies:
+  - extras-common

roles/validate-tempest/meta/main.yml

@@ -0,0 +1,3 @@
+dependencies:
+  - extras-common
+

roles/virthost-full-cleanup/meta/main.yml

@@ -0,0 +1,3 @@
+dependencies:
+  - extras-common
+