Set --ntp-server without having to edit extra_args

Even basic HA deployments require --ntp-server to be passed in, so
this is something that Quickstart should support more natively than by
editing extra_args.

Change-Id: I1359e9f4ff3e294e2e56f5eb4c676c3be63dbe95
Closes-Bug: #1729271

config/general_config/ovb-ha-multiple-nics.yml

@@ -78,8 +78,7 @@ images:
 
 # overcloud deployment settings
 validation_args: " "
-extra_args: " --control-flavor baremetal --compute-flavor baremetal --control-scale 3  \
---ntp-server {{ ntp_server }} "
+extra_args: " --control-flavor baremetal --compute-flavor baremetal --control-scale 3 "
 
 # This featureset is extremely resource intensive, so we disable telemetry
 # in order to reduce the overall memory footprint

config/general_config/ovb-minimal-pacemaker-public-bond.yml

@@ -79,8 +79,7 @@ images:
 
 # overcloud deployment settings
 validation_args: " "
-extra_args: " --control-flavor baremetal --compute-flavor baremetal \
- --ntp-server {{ ntp_server }} "
+extra_args: " --control-flavor baremetal --compute-flavor baremetal "
 
 # This featureset is extremely resource intensive, so we disable telemetry
 # in order to reduce the overall memory footprint

roles/overcloud-deploy/defaults/main.yml

@@ -74,6 +74,7 @@ set_overcloud_workers: true
 cloud_name_args: ""
 network_args: ""
 network_isolation_args: ""
+ntp_args: ""
 pacemaker_args: ""
 workers_args: ""
 backup_args: ""
@@ -105,6 +106,7 @@ deploy_args: >-
   {{ libvirt_args }}
   {{ flavor_args }}
   {{ timeout_args }}
+  {{ ntp_args }}
   {{ cloud_name_args }}
   {{ multinode_args }}
   {{ pacemaker_args }}

roles/overcloud-deploy/tasks/pre-deploy.yml

@@ -91,6 +91,13 @@
     - network_isolation|bool
     - enable_tls_everywhere|bool
 
+- name: set ntp_args
+  set_fact:
+    ntp_args: >-
+      --ntp-server {{ ntp_server }}
+  when:
+    - ntp_server|default('')
+
 - name: enable pacemaker
   set_fact:
     pacemaker_args: >-