This was added to reduce the CI wall time. As we're removing
overcloud plan, this won't work. We can skip the converge
step if required later if we want to reduce the time jobs
take.

Change-Id: Ifd0371274fcc42286217a5c47e3998aafa98ddcc

The variable run_tempest was used by validate-tempest. Since now we use
only os_tempest, this variable is no longer required, however, since
use_os_tempest is default to true, we must change it where the
run_tempest is false, like in the upgrade/update jobs, since we don't
run tempest on those.

Change-Id: Idb8166992976ce6303f95f72011aa65fe536931e

From rocky onwards, the file used to identify the containers parameters
passed to be containers-prepare-parameter.yaml. This file had a different
format than in previous releases. At that point, a new variable was
introuduced in tripleo-upgrade to identify this containers parameter file:
uc_containers_prepare_file. To allow a transition from pre-rocky jobs to
post-rocky, the container_registry_file parameter was left to know the
name of the old containers prepare file. This file was removed from the
appended overcloud_deploy.sh files to avoid issues during the upgrade/
update prepare step [0].

Updates/Upgrades jobs were still using the container_registry_file as
the parameter used to set up the containers, pointing at the post-rocky
file containers-prepare-parameter.yaml. The code in [0] then removed it
from the appended -e environmetn files, running the overcloud update
prepare without the right containers-prepare-parameter.yaml.

[0] - https://review.opendev.org/#/c/717698
Change-Id: I6816db7382e7db6d0ae644c9487b2c5ee595a441
Closes-Bug: #1887176

The tripleo-upgrade sets by default to true the launch_sanity_workload parameter
which runs a workload test after performing the overcloud upgrade. This check
does not make sense in upstream CI as we don't have compute node.

Change-Id: I1347e70f548ee5b708fc6bbd0697cbab10fd2f65

Currently, we are using zuul user as overcloud_ssh_user during overcloud
deployment. While for upgrades, we are still passing tripleo-admin. This
is causing the upgrade prepare command to fail.

Change-Id: If4bd02dad8d69ba4c818ba8d800423bcc8ecfea4
Closes-Bug: #1813564

This normalizes the formatting of files from ci-scripts and config
folders in order to allow further hardening of linting.

Fixing linting was too big to be made in a single commit as it would
involve too many files to review and could merge conflicts with
existing changes. Thus doing it in few chunks would makes it possible.

Original full change is at https://review.openstack.org/#/c/627545/ and
will be the one merging the last.

Change-Id: Ifb215c0e2ea0ef7115897721f75ba8489bd59b97

The output from the containers image prepare
step is not the containers-default-parameters.yaml
file with the list of containers, but another file
named containers-prepare-parameters.yaml which
contains the ContainerImagePrepare parameter. This
parameter is used during deployment-steps to get
the list of containers.

Co-Authored-By: Quique Llorente <ellorent@redhat.com>

Closes-Bug: #1789881
Depends-On: If0c7786059f1d0d91d2279f45c67525908633378
Depends-On: I96109c2452d7568da4a9374661a8ba8b9ba71458
Change-Id: I9bd21b67a9bf9254458351e8ba784ed66f9949f4

ceph-ansible does not support upgrading single nodes environments.
This change switches to use an environment without ceph services
for the fast forward job.

Change-Id: I50cc3e824020320c66ad5f04f434f20674de358e

In order to allow mistral running in the overcloud
we need to pass the 'tripleo-admin' user when calling
to ffwd-upgrade prepare and run.

Change-Id: I1aba03d1fa72593224900c2a5efa44df998aa178
Related-Bug: #1772121

We discovered we need to put back stack updates into the converge
operations. This increases the run time of the upgrade procedure
considerably, and e.g. our voting CI job for updates might go over the
time limit. We'll need to start passing --update-plan-only to the
converge operation to keep CI on previous run times.

Change-Id: Idc5dbebc116aba2420d275aab3981186511f298e
Related-Bug: #1768586

With the CLI workflow for fast forward upgrade we need to disable
the validations while running overcloud ffwd-upgrade prepare to
bypass errors of not available hosts caused by the CI job using
predeployed servers.

Change-Id: I0e5e7736c0ef43dfdc53d9a4dc71c9c803cb6bde

As part of the upgrades/updates playbook refactor
it has been removed the existence of a 'legacy'
and 'new' upgrades playbook, which was being
controlled by the 'use_tripleo_upgrade' variable
Iaf30244187d27909ab803175843056e0827d0b24.

Also, it's been moved the parameter container_registry_file
from the overcloud update's playbook into its
corresponding fs.

Related-Bug: #1749740

Depends-On: Iaf30244187d27909ab803175843056e0827d0b24
Depends-On: Iec42b574d697f3acfd668636e3dd11217a3ea25e
Change-Id: I27f13b164bb78619f8830b875ec9f04445ce1e26

* https://review.openstack.org/551441 introduced test_black_regex
  in order to skip test directly from featureset files. In order
  to avoid confusion between test_regex and test_black_regex, we
  are renaming test_regex to test_white_regex.
 * It will fix all the featuresets.

Depends-On: https://review.openstack.org/560006
Change-Id: If66225c2e2f8c571cc85aebacee01431e4f64dcc

We introduce a new featureset to be able to test Fast Forward Upgrade.

This is a upgrade from Newton to Queens.

As Queens has been released we need also to adjust the mixed release
file.

Related-Bug: #1742924

Depends-On: I4df06c8a0d5d8133ba64c38b90cef34793776422

Change-Id: I240c087941a25227382548136898cb3b172d2389