openstack
/
tripleo-specs
Code Issues Proposed changes

Update patch set 10 

Patch Set 10: Code-Review+1

(3 comments)

Patch-set: 10
Reviewer: Gerrit User 8449 <8449@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1
This commit is contained in:
Gerrit User 8449 2021-10-29 09:23:12 +00:00 committed by Gerrit Code Review
parent 9a995ec88c
commit 16c09be012
1 changed files with 69 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

69
4681e90d34982b82fa53c3a39c1c4974930eb11e
View File

@ -92,6 +92,29 @@
"revId": "4681e90d34982b82fa53c3a39c1c4974930eb11e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4c088626_f7b1e79d",
"filename": "specs/yoga/taskcore-directord.rst",
"patchSetId": 10
},
"lineNbr": 145,
"author": {
"id": 8449
},
"writtenOn": "2021-10-29T09:23:12Z",
"side": 1,
"message": "does that mean it will maintain some state? or discover the environment dynamically? or something else like it could tell you that your network config doesn\u0027t make sense for some other parameter you have specified.",
"range": {
"startLine": 144,
"startChar": 58,
"endLine": 145,
"endChar": 7
},
"revId": "4681e90d34982b82fa53c3a39c1c4974930eb11e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -138,6 +161,29 @@
"revId": "4681e90d34982b82fa53c3a39c1c4974930eb11e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "259eb01f_cc440828",
"filename": "specs/yoga/taskcore-directord.rst",
"patchSetId": 10
},
"lineNbr": 172,
"author": {
"id": 8449
},
"writtenOn": "2021-10-29T09:23:12Z",
"side": 1,
"message": "/? maybe give an example what does it mean exactly",
"range": {
"startLine": 172,
"startChar": 0,
"endLine": 172,
"endChar": 21
},
"revId": "4681e90d34982b82fa53c3a39c1c4974930eb11e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -161,6 +207,29 @@
"revId": "4681e90d34982b82fa53c3a39c1c4974930eb11e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a006da78_503176d9",
"filename": "specs/yoga/taskcore-directord.rst",
"patchSetId": 10
},
"lineNbr": 273,
"author": {
"id": 8449
},
"writtenOn": "2021-10-29T09:23:12Z",
"side": 1,
"message": "has or with",
"range": {
"startLine": 273,
"startChar": 7,
"endLine": 273,
"endChar": 55
},
"revId": "4681e90d34982b82fa53c3a39c1c4974930eb11e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {