Update patch set 10
Patch Set 10: Code-Review+1
(7 comments)
Patch-set: 10
Reviewer: Gerrit User 8833 <8833@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1
Attention: {"person_ident":"Gerrit User 14985 \u003c14985@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Rabi Mishra replied on the change"}
This commit is contained in:
Gerrit User 8833
Gerrit Code Review
parent
7e36d88e1b
commit
5356de11fa
|
|
@ -1,5 +1,143 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "31068717_79199798",
|
||||
"filename": "specs/yoga/taskcore-directord.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 104,
|
||||
"author": {
|
||||
"id": 8833
|
||||
},
|
||||
"writtenOn": "2021-10-29T06:12:56Z",
|
||||
"side": 1,
|
||||
"message": "sounds like a marketing statement.",
|
||||
"range": {
|
||||
"startLine": 103,
|
||||
"startChar": 65,
|
||||
"endLine": 104,
|
||||
"endChar": 25
|
||||
},
|
||||
"revId": "4681e90d34982b82fa53c3a39c1c4974930eb11e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "3a61c164_6a48e085",
|
||||
"filename": "specs/yoga/taskcore-directord.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 125,
|
||||
"author": {
|
||||
"id": 8833
|
||||
},
|
||||
"writtenOn": "2021-10-29T06:12:56Z",
|
||||
"side": 1,
|
||||
"message": "This is a major chunk of the work I guess and can create regressions and probably additional complexity in service templates?",
|
||||
"range": {
|
||||
"startLine": 124,
|
||||
"startChar": 2,
|
||||
"endLine": 125,
|
||||
"endChar": 23
|
||||
},
|
||||
"revId": "4681e90d34982b82fa53c3a39c1c4974930eb11e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "3776449c_1ef6c984",
|
||||
"filename": "specs/yoga/taskcore-directord.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 137,
|
||||
"author": {
|
||||
"id": 8833
|
||||
},
|
||||
"writtenOn": "2021-10-29T06:12:56Z",
|
||||
"side": 1,
|
||||
"message": "schema?",
|
||||
"range": {
|
||||
"startLine": 137,
|
||||
"startChar": 12,
|
||||
"endLine": 137,
|
||||
"endChar": 18
|
||||
},
|
||||
"revId": "4681e90d34982b82fa53c3a39c1c4974930eb11e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "2df07eff_cbc837cc",
|
||||
"filename": "specs/yoga/taskcore-directord.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 147,
|
||||
"author": {
|
||||
"id": 8833
|
||||
},
|
||||
"writtenOn": "2021-10-29T06:12:56Z",
|
||||
"side": 1,
|
||||
"message": "Have we decided on the default messaging driver for TripleO as there were some reservations around using 0mq?",
|
||||
"range": {
|
||||
"startLine": 147,
|
||||
"startChar": 27,
|
||||
"endLine": 147,
|
||||
"endChar": 64
|
||||
},
|
||||
"revId": "4681e90d34982b82fa53c3a39c1c4974930eb11e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "ccb7c824_fcec7df0",
|
||||
"filename": "specs/yoga/taskcore-directord.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 158,
|
||||
"author": {
|
||||
"id": 8833
|
||||
},
|
||||
"writtenOn": "2021-10-29T06:12:56Z",
|
||||
"side": 1,
|
||||
"message": "What about upgrade of directrod clients on nodes? Can it upgrade/update itself or has to be baked into the images?",
|
||||
"range": {
|
||||
"startLine": 158,
|
||||
"startChar": 23,
|
||||
"endLine": 158,
|
||||
"endChar": 46
|
||||
},
|
||||
"revId": "4681e90d34982b82fa53c3a39c1c4974930eb11e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "6da48214_b79ec723",
|
||||
"filename": "specs/yoga/taskcore-directord.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 181,
|
||||
"author": {
|
||||
"id": 8833
|
||||
},
|
||||
"writtenOn": "2021-10-29T06:12:56Z",
|
||||
"side": 1,
|
||||
"message": "What about the ansible workflows in tripleolclient? At times users/developers use those cli* playbooks directly? Are we going to migrate those or they are currently out of scope of this effort? L209 states that \u0027ansible would be removed\u0027(?)",
|
||||
"range": {
|
||||
"startLine": 181,
|
||||
"startChar": 0,
|
||||
"endLine": 181,
|
||||
"endChar": 28
|
||||
},
|
||||
"revId": "4681e90d34982b82fa53c3a39c1c4974930eb11e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -16,6 +154,24 @@
|
|||
"message": "@Rabi, I added this section to try and clarify the limits of execution improvements. We are limited to how effectively we can split up the work to run in parallel. In the deployment today that\u0027s limited to a given play execution. Please let me know if you feel that it would be beneficial to expand on this elsewhere or if this is good enough.",
|
||||
"revId": "4681e90d34982b82fa53c3a39c1c4974930eb11e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "32f13abb_bf769820",
|
||||
"filename": "specs/yoga/taskcore-directord.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 289,
|
||||
"author": {
|
||||
"id": 8833
|
||||
},
|
||||
"writtenOn": "2021-10-29T06:12:56Z",
|
||||
"side": 1,
|
||||
"message": "Thanks.",
|
||||
"parentUuid": "8a218e15_8d62c72b",
|
||||
"revId": "4681e90d34982b82fa53c3a39c1c4974930eb11e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue