Update patch set 2
Patch Set 2: Code-Review-1
(6 comments)
firstpass and some inline comments for your consideration
-1 cos I know its gonna get updated so no point wasting a +1 ;) 😄
Patch-set: 2
Reviewer: Gerrit User 8449 <8449@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 8449
Gerrit Code Review
parent
82010e5600
commit
5e9f86b21a
|
|
@ -35,6 +35,29 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "cc9f27d4_0134c122",
|
||||
"filename": "specs/xena/directord-orchestration.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 77,
|
||||
"author": {
|
||||
"id": 8449
|
||||
},
|
||||
"writtenOn": "2021-07-30T07:23:50Z",
|
||||
"side": 1,
|
||||
"message": "i think it is worth reworking that second sentence to more explicitly state what you are referring to here",
|
||||
"range": {
|
||||
"startLine": 74,
|
||||
"startChar": 37,
|
||||
"endLine": 77,
|
||||
"endChar": 48
|
||||
},
|
||||
"revId": "73a014c1e02e5c5e1a29c17e2ab6310863a1eea6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "26679bc8_75f00e02",
|
||||
|
|
@ -272,6 +295,53 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "27b11ca5_5ff59885",
|
||||
"filename": "specs/xena/directord-orchestration.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 124,
|
||||
"author": {
|
||||
"id": 8449
|
||||
},
|
||||
"writtenOn": "2021-07-30T07:23:50Z",
|
||||
"side": 1,
|
||||
"message": "I don\u0027t see taskflow mentioned anywhere in the spec and only know about its intended use here via Rabi comments. I assume it will be used by Task-Core - can you please add some information about it in the spec?",
|
||||
"parentUuid": "ddea5fb4_91434a5b",
|
||||
"range": {
|
||||
"startLine": 124,
|
||||
"startChar": 0,
|
||||
"endLine": 124,
|
||||
"endChar": 9
|
||||
},
|
||||
"revId": "73a014c1e02e5c5e1a29c17e2ab6310863a1eea6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "8d54105b_f8e71f51",
|
||||
"filename": "specs/xena/directord-orchestration.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 134,
|
||||
"author": {
|
||||
"id": 8449
|
||||
},
|
||||
"writtenOn": "2021-07-30T07:23:50Z",
|
||||
"side": 1,
|
||||
"message": "do we know what these look like yet? maybe add an example please?",
|
||||
"range": {
|
||||
"startLine": 134,
|
||||
"startChar": 2,
|
||||
"endLine": 134,
|
||||
"endChar": 23
|
||||
},
|
||||
"revId": "73a014c1e02e5c5e1a29c17e2ab6310863a1eea6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "97813703_3b17e222",
|
||||
|
|
@ -938,6 +1008,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "2e0125d3_cd91c4ef",
|
||||
"filename": "specs/xena/directord-orchestration.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 177,
|
||||
"author": {
|
||||
"id": 8449
|
||||
},
|
||||
"writtenOn": "2021-07-30T07:23:50Z",
|
||||
"side": 1,
|
||||
"message": "@David I don\u0027t think we can ever fully achieve that goal even though it is a fine goal to have and continue to work towards ; the main problem is that the config may be syntactically correct, so passes our validations etc, but is semantically wrong (for example, overwriting your network config with syntactically correct new config) so how will Directord protect against that. I guess it depends on what \"environmentally aware\" actually means or how it can be achieved.",
|
||||
"parentUuid": "bf249157_d5c82e50",
|
||||
"revId": "73a014c1e02e5c5e1a29c17e2ab6310863a1eea6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fcf35bef_6ecb78e6",
|
||||
|
|
@ -1080,6 +1168,29 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a72c26c_9a38f3ac",
|
||||
"filename": "specs/xena/directord-orchestration.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 237,
|
||||
"author": {
|
||||
"id": 8449
|
||||
},
|
||||
"writtenOn": "2021-07-30T07:23:50Z",
|
||||
"side": 1,
|
||||
"message": "i love the vision :) but can we have some more specifics or some examples here to better illustrate the possibilities please?",
|
||||
"range": {
|
||||
"startLine": 236,
|
||||
"startChar": 24,
|
||||
"endLine": 237,
|
||||
"endChar": 52
|
||||
},
|
||||
"revId": "73a014c1e02e5c5e1a29c17e2ab6310863a1eea6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "0eb609fb_9ce8131f",
|
||||
|
|
@ -1168,6 +1279,29 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "aef9a5ca_c9bf90c4",
|
||||
"filename": "specs/xena/directord-orchestration.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 296,
|
||||
"author": {
|
||||
"id": 8449
|
||||
},
|
||||
"writtenOn": "2021-07-30T07:23:50Z",
|
||||
"side": 1,
|
||||
"message": "this has been tested at scale?",
|
||||
"range": {
|
||||
"startLine": 296,
|
||||
"startChar": 10,
|
||||
"endLine": 296,
|
||||
"endChar": 21
|
||||
},
|
||||
"revId": "73a014c1e02e5c5e1a29c17e2ab6310863a1eea6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "11213ddb_c6309669",
|
||||
|
|
|
|||
Loading…
Reference in New Issue