Update patch set 1

Patch Set 1:

(3 comments)

Patch-set: 1

c70c9249249504b39cde5ea95caa86f2df921acb

@@ -23,6 +23,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": true
     },
+    {
+      "key": {
+        "uuid": "2cb112ef_be10c114",
+        "filename": "specs/xena/healthcheck-new-way.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 24,
+      "author": {
+        "id": 28223
+      },
+      "writtenOn": "2021-08-05T13:01:54Z",
+      "side": 1,
+      "message": "Ack",
+      "parentUuid": "c5bd49ad_d964738d",
+      "range": {
+        "startLine": 24,
+        "startChar": 43,
+        "endLine": 24,
+        "endChar": 56
+      },
+      "revId": "c70c9249249504b39cde5ea95caa86f2df921acb",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "d01a7a8d_1a9cc8e1",
@@ -40,6 +64,24 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": true
     },
+    {
+      "key": {
+        "uuid": "2fc853b0_ba539dcd",
+        "filename": "specs/xena/healthcheck-new-way.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 26,
+      "author": {
+        "id": 28223
+      },
+      "writtenOn": "2021-08-05T13:01:54Z",
+      "side": 1,
+      "message": "right, I\u0027ll mention it in a subsequent update",
+      "parentUuid": "d01a7a8d_1a9cc8e1",
+      "revId": "c70c9249249504b39cde5ea95caa86f2df921acb",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
     {
       "key": {
         "uuid": "40e1c444_2fa7f3a6",
@@ -62,6 +104,30 @@
       "revId": "c70c9249249504b39cde5ea95caa86f2df921acb",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "570af206_c2aa90f7",
+        "filename": "specs/xena/healthcheck-new-way.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 46,
+      "author": {
+        "id": 28223
+      },
+      "writtenOn": "2021-08-05T13:01:54Z",
+      "side": 1,
+      "message": "It depends, really: if ppl use the oslo.middleware.healthcheck helper, there is a way to actually describe the issue - being a backend service being unreachable, or an actual API issue.\n\nI\u0027d rather avoid getting anything hitting directly backend services such as rabbitMQ, DB or DNS, since it would NOT represent the actual use - and, well, usually, for such services, in order to *check* them, it would require an actual connection with some action (a dumb \"select\" on a table, a DNS query, a sending and getting a message through the queue, and so on).\n\nIf we want to actually check/verify if an API is working, that API has to test its own dependencies - maybe the DB is up, but for #reason the user used by the API is deactivated/blocked/others.. How would you detect that? Same goes for DNS, it might work from one side, but the API needing the DNS might be blocked due to network issue, delays, and so on.",
+      "parentUuid": "40e1c444_2fa7f3a6",
+      "range": {
+        "startLine": 45,
+        "startChar": 0,
+        "endLine": 46,
+        "endChar": 63
+      },
+      "revId": "c70c9249249504b39cde5ea95caa86f2df921acb",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
     }
   ]
 }