Update patch set 1

Patch Set 1: Code-Review-1

(5 comments)

I think this is a good change to do, and thank you for using the spec process to get design input.

I am enthusiastically in support of the idea, there are just some details to hammer out.

In particular I think we need to list all the variables (or at least broad groups like 'incubator managed passwords') and then we can separate those into 'heat-env.json should override' or 'should override heat-env.json'.

Patch-set: 1
Label: Code-Review=-1

bfa23ee329edbb1cdd7511ddc49e909ef5210dcc

@@ -1,5 +1,56 @@
 {
   "comments": [
+    {
+      "key": {
+        "uuid": "5adbc538_751723a4",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 1
+      },
+      "lineNbr": 12,
+      "author": {
+        "id": 4190
+      },
+      "writtenOn": "2014-05-26T03:44:19Z",
+      "side": 1,
+      "message": "Thanks for putting this up as a spec, its certainly nuanced enough that clear design discussion is useful.",
+      "revId": "bfa23ee329edbb1cdd7511ddc49e909ef5210dcc",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5adbc538_9583cfcb",
+        "filename": "specs/juno/promote-heat-env.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 24,
+      "author": {
+        "id": 4190
+      },
+      "writtenOn": "2014-05-26T03:44:19Z",
+      "side": 1,
+      "message": "I\u0027m a little confused. Here are my axioms:\n\nThe heat environment captures the state of the heat stack so we can stack-update without needing to know the prior command line.\n\nIncubator includes procedural code which determines the correct value for parameters we are passing to Heat.\n\nUsers want to pass additional things to heat, so need a way to supply those additional things.\n\nAnd here is my confusion: you say its a problem that that the user supplied heat environment is overridden on some parameters by the incubator procedural code. How is that a problem?\n\nI *think* you mean its a problem that users have to set environment variables to control aspects of the stack that are already under their control.",
+      "revId": "bfa23ee329edbb1cdd7511ddc49e909ef5210dcc",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5adbc538_f5509360",
+        "filename": "specs/juno/promote-heat-env.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 63,
+      "author": {
+        "id": 4190
+      },
+      "writtenOn": "2014-05-26T03:44:19Z",
+      "side": 1,
+      "message": "You are not considering D, which is calculated values that are expressed as environment variables - some local, some exported, but which have to override or we\u0027ll fail to configure the stack correctly. For instance, UNDERCLOUD_ID is one of those.",
+      "revId": "bfa23ee329edbb1cdd7511ddc49e909ef5210dcc",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "7adec928_0e1a0217",
@@ -34,6 +85,40 @@
       "revId": "bfa23ee329edbb1cdd7511ddc49e909ef5210dcc",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5adbc538_35f91b4e",
+        "filename": "specs/juno/promote-heat-env.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 80,
+      "author": {
+        "id": 4190
+      },
+      "writtenOn": "2014-05-26T03:44:19Z",
+      "side": 1,
+      "message": "Some things appear to be missing from this spec:\n - what about other code that currently consults the variables? \n  - how will such code find the heat env to consult? [argh variables argh]\n - backwards compatibility impact of the change (e.g. folk that set variables in devtestrc files - how will they be impacted)",
+      "revId": "bfa23ee329edbb1cdd7511ddc49e909ef5210dcc",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5adbc538_b5d60bc4",
+        "filename": "specs/juno/promote-heat-env.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 143,
+      "author": {
+        "id": 4190
+      },
+      "writtenOn": "2014-05-26T03:44:19Z",
+      "side": 1,
+      "message": "Please be more detailed here. In particular I think this needs to callout:\n - affects undercloud and overcloud\n - also affects any script that consults anything that is currently an environment variable.",
+      "revId": "bfa23ee329edbb1cdd7511ddc49e909ef5210dcc",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
     }
   ]
 }