Update patch set 3

Patch Set 3:

(4 comments)

Patch-set: 3
Reviewer: Gerrit User 7144 <7144@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 7144 2021-08-05 19:36:04 +00:00 committed by Gerrit Code Review
parent 423c4355dd
commit 96c4593d6e
1 changed files with 72 additions and 0 deletions

View File

@ -0,0 +1,72 @@
{
"comments": [
{
"key": {
"uuid": "d800eea8_1205c703",
"filename": "specs/xena/directord-orchestration.rst",
"patchSetId": 3
},
"lineNbr": 36,
"author": {
"id": 7144
},
"writtenOn": "2021-08-05T19:36:04Z",
"side": 1,
"message": "It does seem that there is some overlap between Heat and Task-core. Heat is also a declarative dependency graph. However, our service template framework interface does not lend itself to being expressed that way (no way to express dependencies between services, or ordering, etc). Instead we have rigid task lists.\n\nAs an alternative, we could look at how we would express this all using Heat templates. This:\nhttps://github.com/mwhahaha/task-core/blob/main/examples/directord/services/openstack-keystone.yaml\nis actually not all that different from the existing keystone service template from tripleo-heat-templates. We could evolve the t-h-t service framework interface into what we need as well, instead of building out all these task-core services.\n\nI\u0027d like to see a psuedo-code example of how this would all flow end to end. The line between Heat and task-core is not well understood. It feels like we\u0027re handing off from one dependency graph to another.\n\nIf we boil down what task-core does as \"figuring out the right order of all the directord executions\"...then couldn\u0027t Heat do that as well if we had a service template framework that expressed dependencies, and let Heat solve for those instead of passing it off to task-core?\n\nIt feels as if task-core is the answer to heat-as-a-library. I see a lot of overlap between the 2 tools intended functionality. Not necessarily in how we use them, because we don\u0027t fully take advantage of Heat\u0027s ability to order things and solve dependencies, instead we implemented rigid steps and ordering.",
"revId": "1c13b866955721f7542d43c6cfb514d80632b2ae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "aa1a6184_c8031e70",
"filename": "specs/xena/directord-orchestration.rst",
"patchSetId": 3
},
"lineNbr": 134,
"author": {
"id": 7144
},
"writtenOn": "2021-08-05T19:36:04Z",
"side": 1,
"message": "Can we see an example of this? Even if it\u0027s pseudo-code.\nI think it will help close the gaps on the big picture of the end to end flow.",
"revId": "1c13b866955721f7542d43c6cfb514d80632b2ae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "c6690ee1_52cdcc10",
"filename": "specs/xena/directord-orchestration.rst",
"patchSetId": 3
},
"lineNbr": 409,
"author": {
"id": 7144
},
"writtenOn": "2021-08-05T19:36:04Z",
"side": 1,
"message": "Heat would be between the TripleOClient and Task-Core boxes, correct? Can we add it to the diagram so that it\u0027s more clear that Heat is still part of the picture, and also articulate what it\u0027s still doing?\n\nI think it would help to clear up a lot of the questions around what exactly is targetted at being replaced by directord + task-core (it\u0027s Ansible, not Heat).",
"revId": "1c13b866955721f7542d43c6cfb514d80632b2ae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "b3a1a7c5_22eb5b67",
"filename": "specs/xena/directord-orchestration.rst",
"patchSetId": 3
},
"lineNbr": 439,
"author": {
"id": 7144
},
"writtenOn": "2021-08-05T19:36:04Z",
"side": 1,
"message": "slagle",
"revId": "1c13b866955721f7542d43c6cfb514d80632b2ae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}