Update patch set 2
Patch Set 2: (7 comments) Patch-set: 2
This commit is contained in:
Gerrit User 11628
Gerrit Code Review
parent
419af40b11
commit
a55184797c
|
|
@ -1,5 +1,74 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "9d94da39_548f8d4f",
|
||||
"filename": "specs/yoga/compact-wsgi-footprint.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 19,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2021-11-18T19:11:51Z",
|
||||
"side": 1,
|
||||
"message": "control",
|
||||
"range": {
|
||||
"startLine": 19,
|
||||
"startChar": 71,
|
||||
"endLine": 19,
|
||||
"endChar": 79
|
||||
},
|
||||
"revId": "587b36b7c7f3423e98fcb95eb32b8f71b36fe066",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "1a7c8264_b897ede2",
|
||||
"filename": "specs/yoga/compact-wsgi-footprint.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 36,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2021-11-18T19:11:51Z",
|
||||
"side": 1,
|
||||
"message": "Can you clarify what would be running in podman?\nAre you proposing running each service under python inside podman? Using the \"simpleserver\" implementation?\nIf so, note that simpleserver does not scale well and requires a lot of tuning.",
|
||||
"range": {
|
||||
"startLine": 34,
|
||||
"startChar": 65,
|
||||
"endLine": 36,
|
||||
"endChar": 58
|
||||
},
|
||||
"revId": "587b36b7c7f3423e98fcb95eb32b8f71b36fe066",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "9d3b029a_87c7bd27",
|
||||
"filename": "specs/yoga/compact-wsgi-footprint.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 42,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2021-11-18T19:11:51Z",
|
||||
"side": 1,
|
||||
"message": "WSGI?",
|
||||
"range": {
|
||||
"startLine": 42,
|
||||
"startChar": 19,
|
||||
"endLine": 42,
|
||||
"endChar": 23
|
||||
},
|
||||
"revId": "587b36b7c7f3423e98fcb95eb32b8f71b36fe066",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -51,6 +120,52 @@
|
|||
"revId": "587b36b7c7f3423e98fcb95eb32b8f71b36fe066",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "b6197e3d_7e296e34",
|
||||
"filename": "specs/yoga/compact-wsgi-footprint.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 76,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2021-11-18T19:11:51Z",
|
||||
"side": 1,
|
||||
"message": "I don\u0027t think we get any benefit out of moving to nginx.",
|
||||
"range": {
|
||||
"startLine": 76,
|
||||
"startChar": 12,
|
||||
"endLine": 76,
|
||||
"endChar": 17
|
||||
},
|
||||
"revId": "587b36b7c7f3423e98fcb95eb32b8f71b36fe066",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "08d41241_e07b9cb0",
|
||||
"filename": "specs/yoga/compact-wsgi-footprint.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 76,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2021-11-18T19:11:51Z",
|
||||
"side": 1,
|
||||
"message": "uWSGI behind Apache is how the upstream devstack is setup and has a proven track record in many production environments.\nThis solves the memory and scale issues mod_wsgi brings.",
|
||||
"range": {
|
||||
"startLine": 76,
|
||||
"startChar": 25,
|
||||
"endLine": 76,
|
||||
"endChar": 30
|
||||
},
|
||||
"revId": "587b36b7c7f3423e98fcb95eb32b8f71b36fe066",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -85,6 +200,40 @@
|
|||
"revId": "587b36b7c7f3423e98fcb95eb32b8f71b36fe066",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "6e987fff_3ab7b3c4",
|
||||
"filename": "specs/yoga/compact-wsgi-footprint.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 99,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2021-11-18T19:11:51Z",
|
||||
"side": 1,
|
||||
"message": "Performance could decrease, depending on the design, due to the NAT required at the pod boundary (i.e. exposing the port)",
|
||||
"revId": "587b36b7c7f3423e98fcb95eb32b8f71b36fe066",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "38db7b6c_73d7fd57",
|
||||
"filename": "specs/yoga/compact-wsgi-footprint.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 100,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2021-11-18T19:11:51Z",
|
||||
"side": 1,
|
||||
"message": "Also note, if you run all of the API WSGI applications under one WSGI framework and/or python instance, performance can degrade at scale due to the GIL. There is some benefit to having high-rate-of-change APIs get their own python instance.",
|
||||
"revId": "587b36b7c7f3423e98fcb95eb32b8f71b36fe066",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
|
|||
Loading…
Reference in New Issue