openstack
/
tripleo-specs
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(9 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 7144 \u003c7144@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"James Slagle replied on the change"}
Attention: {"person_ident":"Gerrit User 9914 \u003c9914@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"James Slagle replied on the change"}
Attention: {"person_ident":"Gerrit User 8042 \u003c8042@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"James Slagle replied on the change"}
This commit is contained in:
Gerrit User 7144 2022-04-12 20:46:17 +00:00 committed by Gerrit Code Review
parent 5d9a7a7df1
commit b2c131a29f
3 changed files with 197 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

65
558f63a521a119d42fb8260a966915c32e06b610
View File

@ -23,6 +23,30 @@
"revId": "558f63a521a119d42fb8260a966915c32e06b610",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e4f2e6c6_02f8f66e",
"filename": "specs/wallaby/mixed-operating-system-versions.rst",
"patchSetId": 3
},
"lineNbr": 118,
"author": {
"id": 7144
},
"writtenOn": "2022-04-12T20:46:17Z",
"side": 1,
"message": "right. and really all we need to keep this working is just be aware to not commit anything that would break deploying 8. I think that\u0027s reasonable.",
"parentUuid": "3b0f26a1_c2cbd54b",
"range": {
"startLine": 117,
"startChar": 0,
"endLine": 118,
"endChar": 35
},
"revId": "558f63a521a119d42fb8260a966915c32e06b610",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -45,6 +69,47 @@
},
"revId": "558f63a521a119d42fb8260a966915c32e06b610",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9b4166b9_d78c13b7",
"filename": "specs/wallaby/mixed-operating-system-versions.rst",
"patchSetId": 3
},
"lineNbr": 238,
"author": {
"id": 7144
},
"writtenOn": "2022-04-12T20:46:17Z",
"side": 1,
"message": "i would prefer tasks that just do the right thing. For one, wallaby already supports 8 and 9, so I don\u0027t think this is all that much different from what we have working today.\n\nupdate tasks might need to do different things depending on 8 or 9. maybe we could codify those tasks in a role?",
"parentUuid": "939e60f1_7821c2b3",
"range": {
"startLine": 238,
"startChar": 0,
"endLine": 238,
"endChar": 57
},
"revId": "558f63a521a119d42fb8260a966915c32e06b610",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "53009008_4a82cd59",
"filename": "specs/wallaby/mixed-operating-system-versions.rst",
"patchSetId": 3
},
"lineNbr": 256,
"author": {
"id": 7144
},
"writtenOn": "2022-04-12T20:46:17Z",
"side": 1,
"message": "add desired jobs",
"revId": "558f63a521a119d42fb8260a966915c32e06b610",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

84
b40657d9f588f50657955d7f1a307ae547d60456
View File

@ -167,6 +167,30 @@
"revId": "b40657d9f588f50657955d7f1a307ae547d60456",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c2006fa0_a839bf04",
"filename": "specs/wallaby/mixed-operating-system-versions.rst",
"patchSetId": 2
},
"lineNbr": 46,
"author": {
"id": 7144
},
"writtenOn": "2022-04-12T20:46:17Z",
"side": 1,
"message": "i can\u0027t follow these comments and what you are -2\u0027ing. We\u0027re moving forward with this support whether we merge this spec or not. If there is something specific you object to, enough to block the entire spec, please propose in a comment what language you would change and what you would want it to say.",
"parentUuid": "217fd8bc_460990f1",
"range": {
"startLine": 45,
"startChar": 45,
"endLine": 46,
"endChar": 44
},
"revId": "b40657d9f588f50657955d7f1a307ae547d60456",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -190,6 +214,30 @@
"revId": "b40657d9f588f50657955d7f1a307ae547d60456",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1bf49c5a_854f3058",
"filename": "specs/wallaby/mixed-operating-system-versions.rst",
"patchSetId": 2
},
"lineNbr": 81,
"author": {
"id": 7144
},
"writtenOn": "2022-04-12T20:46:17Z",
"side": 1,
"message": "Done",
"parentUuid": "2a78c6e0_a8d58e5e",
"range": {
"startLine": 81,
"startChar": 0,
"endLine": 81,
"endChar": 3
},
"revId": "b40657d9f588f50657955d7f1a307ae547d60456",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -332,6 +380,24 @@
"revId": "b40657d9f588f50657955d7f1a307ae547d60456",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1408e2ad_dc414be6",
"filename": "specs/wallaby/mixed-operating-system-versions.rst",
"patchSetId": 2
},
"lineNbr": 159,
"author": {
"id": 7144
},
"writtenOn": "2022-04-12T20:46:17Z",
"side": 1,
"message": "Some amount of mixing is the entire point. We already have mixed-mode support today.",
"parentUuid": "66d8097c_82948578",
"revId": "b40657d9f588f50657955d7f1a307ae547d60456",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -385,6 +451,24 @@
"revId": "b40657d9f588f50657955d7f1a307ae547d60456",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "7081660b_8bd06211",
"filename": "specs/wallaby/mixed-operating-system-versions.rst",
"patchSetId": 2
},
"lineNbr": 167,
"author": {
"id": 7144
},
"writtenOn": "2022-04-12T20:46:17Z",
"side": 1,
"message": "Done",
"parentUuid": "3484ea3d_00e9d296",
"revId": "b40657d9f588f50657955d7f1a307ae547d60456",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {

48
ff7171a6f782524f7b48c89fb91644d7165b0acc
View File

@ -88,6 +88,30 @@
"revId": "ff7171a6f782524f7b48c89fb91644d7165b0acc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b8aafcce_d49c7791",
"filename": "specs/wallaby/mixed-operating-system-versions.rst",
"patchSetId": 1
},
"lineNbr": 101,
"author": {
"id": 7144
},
"writtenOn": "2022-04-12T20:46:17Z",
"side": 1,
"message": "That\u0027s a service dependency issue, I don\u0027t think TripleO should address how that is solved. If the service can\u0027t run on ubi 8, but ubi 8 is required for some reason to run that service on RHEL 8, that service will need to be updated to fix that support (whether that means continuing to support python 3.6 or something else, just an example).",
"parentUuid": "9cbf429a_9de698bd",
"range": {
"startLine": 100,
"startChar": 17,
"endLine": 101,
"endChar": 16
},
"revId": "ff7171a6f782524f7b48c89fb91644d7165b0acc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -418,6 +442,30 @@
},
"revId": "ff7171a6f782524f7b48c89fb91644d7165b0acc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "25d362e5_e995d243",
"filename": "specs/wallaby/mixed-operating-system-versions.rst",
"patchSetId": 1
},
"lineNbr": 239,
"author": {
"id": 7144
},
"writtenOn": "2022-04-12T20:46:17Z",
"side": 1,
"message": "Done",
"parentUuid": "ac514324_eb621f90",
"range": {
"startLine": 239,
"startChar": 0,
"endLine": 239,
"endChar": 1
},
"revId": "ff7171a6f782524f7b48c89fb91644d7165b0acc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}