openstack
/
tripleo-specs
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(8 comments)

Patch-set: 5
This commit is contained in:
Gerrit User 8399 2014-05-28 15:08:48 +00:00 committed by Gerrit Code Review
parent 8afd0e448c
commit b6a672a68a
1 changed files with 144 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

144
e19645628b53601fe3803c2edb6296d03e8a811f
View File

@ -385,6 +385,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ae8d1ca_bdcebbb2",
"filename": "specs/juno/tuskar-rest-api.rst",
"patchSetId": 5
},
"lineNbr": 98,
"author": {
"id": 8399
},
"writtenOn": "2014-05-28T15:08:48Z",
"side": 1,
"message": "I need to revisit this area a bit today, so in the next iteration it will likely look a bit different.",
"parentUuid": "3ae8d1ca_c6c82877",
"revId": "e19645628b53601fe3803c2edb6296d03e8a811f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5adbc538_b02539ad",
@ -455,6 +473,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ae8d1ca_fd6da39a",
"filename": "specs/juno/tuskar-rest-api.rst",
"patchSetId": 5
},
"lineNbr": 124,
"author": {
"id": 8399
},
"writtenOn": "2014-05-28T15:08:48Z",
"side": 1,
"message": "There\u0027s a comment on this below with the different possibilities, I\u0027ll keep the discussion going there.",
"parentUuid": "3ae8d1ca_c1e572a9",
"revId": "e19645628b53601fe3803c2edb6296d03e8a811f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ae8d1ca_625e80eb",
@ -526,6 +562,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ae8d1ca_5d2db745",
"filename": "specs/juno/tuskar-rest-api.rst",
"patchSetId": 5
},
"lineNbr": 146,
"author": {
"id": 8399
},
"writtenOn": "2014-05-28T15:08:48Z",
"side": 1,
"message": "I like that approach, the relative paths and let keystone be consulted for the service endpoints.",
"parentUuid": "3ae8d1ca_6c2655b9",
"revId": "e19645628b53601fe3803c2edb6296d03e8a811f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ae8d1ca_8c41e13b",
@ -543,6 +597,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ae8d1ca_9db57ff0",
"filename": "specs/juno/tuskar-rest-api.rst",
"patchSetId": 5
},
"lineNbr": 170,
"author": {
"id": 8399
},
"writtenOn": "2014-05-28T15:08:48Z",
"side": 1,
"message": "The reason I added this is to prevent a bunch of lazy instantiation checks. If we don\u0027t do the stack create here, we\u0027ll have to do it in deploy but only if it doesn\u0027t already exist, and in delete we\u0027ll have to ensure it exists. It\u0027s not the worst thing in the world, but felt cleaner to tie it to the create process instead of checking each time.\n\nThe other reason this may be necessary is based on the feedback on the URLs that suggest using the stack ID as the cloud UUID. If we adopt that model, we have to have the stack successfully created at this point so we can later refer back to the cloud.",
"parentUuid": "3ae8d1ca_8c41e13b",
"revId": "e19645628b53601fe3803c2edb6296d03e8a811f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ae8d1ca_5455c21b",
@ -596,6 +668,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ae8d1ca_bdaf9b93",
"filename": "specs/juno/tuskar-rest-api.rst",
"patchSetId": 5
},
"lineNbr": 178,
"author": {
"id": 8399
},
"writtenOn": "2014-05-28T15:08:48Z",
"side": 1,
"message": "I answered the first question in my comment above.\n\nThat\u0027s a big assumption I made about Heat, but it does warrant more investigation.",
"parentUuid": "3ae8d1ca_4cac39a1",
"revId": "e19645628b53601fe3803c2edb6296d03e8a811f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ae8d1ca_ccc4c942",
@ -613,6 +703,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ae8d1ca_bdb4fbd1",
"filename": "specs/juno/tuskar-rest-api.rst",
"patchSetId": 5
},
"lineNbr": 182,
"author": {
"id": 8399
},
"writtenOn": "2014-05-28T15:08:48Z",
"side": 1,
"message": "I don\u0027t completely agree; I don\u0027t think the UI should overly influence the REST APIs. I think CI may also have a strong need for this, in which case it may rise in priority.",
"parentUuid": "3ae8d1ca_ccc4c942",
"revId": "e19645628b53601fe3803c2edb6296d03e8a811f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ae8d1ca_f71fb007",
@ -1088,6 +1196,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ae8d1ca_fd3a0333",
"filename": "specs/juno/tuskar-rest-api.rst",
"patchSetId": 5
},
"lineNbr": 365,
"author": {
"id": 8399
},
"writtenOn": "2014-05-28T15:08:48Z",
"side": 1,
"message": "Right, that\u0027s my intention. Heat carries the state of what\u0027s live and Tuskar simply tracks if there are any changes that need to be deployed. Ladislov\u0027s comments above talk about a more advanced way of saying what changes are outstanding and I agree with him that it\u0027s a (damn cool) future enhancement.",
"parentUuid": "3ae8d1ca_af1a0c15",
"revId": "e19645628b53601fe3803c2edb6296d03e8a811f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ae8d1ca_3d1d79be",
@ -1194,6 +1320,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ae8d1ca_7d16f3a8",
"filename": "specs/juno/tuskar-rest-api.rst",
"patchSetId": 5
},
"lineNbr": 434,
"author": {
"id": 8399
},
"writtenOn": "2014-05-28T15:08:48Z",
"side": 1,
"message": "That\u0027s next on my list to write up and I\u0027ll likely have something out while this is still open for discussion.",
"parentUuid": "3ae8d1ca_923e53b7",
"revId": "e19645628b53601fe3803c2edb6296d03e8a811f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5adbc538_907cbd74",