openstack
/
tripleo-specs
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review-1

(3 comments)

A couple of additional comments inline.

Patch-set: 2
Reviewer: Gerrit User 6928 <6928@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 6928 2014-05-08 21:17:23 +00:00 committed by Gerrit Code Review
parent 0dcb1c98e7
commit d18d7a205c
1 changed files with 52 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
a9afa5c7d037c6bc87fae5ac2e1f190cc1771d8d
View File

@ -314,6 +314,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7adec928_d8048e17",
"filename": "specs/juno/tripleo-systems-monitoring.rst",
"patchSetId": 2
},
"lineNbr": 62,
"author": {
"id": 6928
},
"writtenOn": "2014-05-08T21:17:23Z",
"side": 1,
"message": "This section feels like it belongs under the performance impact heading.",
"revId": "a9afa5c7d037c6bc87fae5ac2e1f190cc1771d8d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9ad9bd40_57443eb6",
@ -401,6 +418,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7adec928_383ad2cd",
"filename": "specs/juno/tripleo-systems-monitoring.rst",
"patchSetId": 2
},
"lineNbr": 78,
"author": {
"id": 6928
},
"writtenOn": "2014-05-08T21:17:23Z",
"side": 1,
"message": "grammar nit: \"...of the same sort as icinga.\"",
"revId": "a9afa5c7d037c6bc87fae5ac2e1f190cc1771d8d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9ad9bd40_3039a441",
@ -471,6 +505,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7adec928_586f9e92",
"filename": "specs/juno/tripleo-systems-monitoring.rst",
"patchSetId": 2
},
"lineNbr": 111,
"author": {
"id": 6928
},
"writtenOn": "2014-05-08T21:17:23Z",
"side": 1,
"message": "What user does check_mk run under? If I\u0027m understanding correctly, there are agents running on every node to report these details back, and I assume those aren\u0027t run as root. Maybe worth calling out here since it will be a user with permission to run somewhat arbitrary things on the nodes that would be a problem if it were compromised.",
"parentUuid": "9ad9bd40_ea6748b5",
"revId": "a9afa5c7d037c6bc87fae5ac2e1f190cc1771d8d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9ad9bd40_3010c4a7",