Update patch set 1

Patch Set 1:

(5 comments)

Thank you for starting a design discussion around this, I know your patches hit a wall and I hope we can resolve that through this process. I also realise that your spec is in WIP - but I thought you might like some early feedback.

Right now, the problem description needs significantly more exposition IMO - I don't understand what things like '3rd party tooling' are really referring to here.

Patch-set: 1
Label: Verified=0
This commit is contained in:
Gerrit User 4190 2014-05-27 07:54:00 +00:00 committed by Gerrit Code Review
parent 4a8637c09a
commit d1bb3ec836
1 changed files with 89 additions and 0 deletions

View File

@ -0,0 +1,89 @@
{
"comments": [
{
"key": {
"uuid": "3ae8d1ca_431275b5",
"filename": "specs/juno/tripleo-reusable-image-definition.rst",
"patchSetId": 1
},
"lineNbr": 18,
"author": {
"id": 4190
},
"writtenOn": "2014-05-27T07:54:00Z",
"side": 1,
"message": "There\u0027s a subtle misunderstanding here. The incubator scripts are referred to are *devtest* - they aren\u0027t end user production scripts. They might become so, but they would move out of incubator as part of doing that.\n\nI\u0027d like the summary here to capture the essence of the spec, I\u0027m not sure it does (yet) - -OTOH I haven\u0027t read to the bottom yet. We\u0027ll see :)",
"revId": "06dc03e6bce202997cfd4d94a4fed0ab57a70bf2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ae8d1ca_637e91e6",
"filename": "specs/juno/tripleo-reusable-image-definition.rst",
"patchSetId": 1
},
"lineNbr": 29,
"author": {
"id": 4190
},
"writtenOn": "2014-05-27T07:54:00Z",
"side": 1,
"message": "The definition of these images is something that is moving into tuskar - the devtest scripts are just that - devtest - while we build up the long term answer. I\u0027m not at all concerned that they are not particularly suitable for 3rd party tooling (whatever that means). They are however extensible today (using the horrid environment variables) - so the problem description is incomplete - it doesn\u0027t actually describe the problem in sufficient detail for reviewers to understand it - well, at least for me to understand it.",
"revId": "06dc03e6bce202997cfd4d94a4fed0ab57a70bf2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ae8d1ca_83839dcb",
"filename": "specs/juno/tripleo-reusable-image-definition.rst",
"patchSetId": 1
},
"lineNbr": 34,
"author": {
"id": 4190
},
"writtenOn": "2014-05-27T07:54:00Z",
"side": 1,
"message": "This is a solution, not part of the problem definition.",
"revId": "06dc03e6bce202997cfd4d94a4fed0ab57a70bf2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ae8d1ca_a38899e8",
"filename": "specs/juno/tripleo-reusable-image-definition.rst",
"patchSetId": 1
},
"lineNbr": 38,
"author": {
"id": 4190
},
"writtenOn": "2014-05-27T07:54:00Z",
"side": 1,
"message": "Ditto this, though you could rephrase it into a second related problem definition.",
"revId": "06dc03e6bce202997cfd4d94a4fed0ab57a70bf2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ae8d1ca_c353e56a",
"filename": "specs/juno/tripleo-reusable-image-definition.rst",
"patchSetId": 1
},
"lineNbr": 45,
"author": {
"id": 4190
},
"writtenOn": "2014-05-27T07:54:00Z",
"side": 1,
"message": "Thats not the intent of the dependency facility in diskimage-builder; reusing it for integrity checking has some nasty UI implications (which Debian and Ubuntu run into all the time). \u0027Provides\u0027, \u0027Enhances\u0027 and \u0027Suggests\u0027 are the current set of complexity resulting from that attempt there - lets not assume that that is the right answer before we\u0027ve clearly identified the problem.",
"revId": "06dc03e6bce202997cfd4d94a4fed0ab57a70bf2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}