From b5a1a76877a9b7e7238f337c2d178f4d7a9a8bac Mon Sep 17 00:00:00 2001 From: Gerrit User 20970 <20970@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Tue, 4 Dec 2018 17:59:17 +0000 Subject: [PATCH] Update patch set 4 Patch Set 4: Code-Review-1 (4 comments) Patch-set: 4 Label: Code-Review=-1 --- 8281cfc6faea50ee609cc8f01a397692ff7fa4e1 | 72 ++++++++++++++++++++++++ 1 file changed, 72 insertions(+) create mode 100644 8281cfc6faea50ee609cc8f01a397692ff7fa4e1 diff --git a/8281cfc6faea50ee609cc8f01a397692ff7fa4e1 b/8281cfc6faea50ee609cc8f01a397692ff7fa4e1 new file mode 100644 index 00000000..c595e426 --- /dev/null +++ b/8281cfc6faea50ee609cc8f01a397692ff7fa4e1 @@ -0,0 +1,72 @@ +{ + "comments": [ + { + "key": { + "uuid": "3f79a3b5_3b99747f", + "filename": "src/js/components/containerImages/ContainerImagePrepareParameterForm.js", + "patchSetId": 4 + }, + "lineNbr": 56, + "author": { + "id": 20970 + }, + "writtenOn": "2018-12-04T17:59:17Z", + "side": 1, + "message": "What\u0027s this magic number?", + "revId": "8281cfc6faea50ee609cc8f01a397692ff7fa4e1", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "3f79a3b5_bbc7c466", + "filename": "src/js/components/containerImages/ContainerImagePrepareParameterForm.js", + "patchSetId": 4 + }, + "lineNbr": 87, + "author": { + "id": 20970 + }, + "writtenOn": "2018-12-04T17:59:17Z", + "side": 1, + "message": "i18l, and maybe say \"Invalid YAML syntax\"", + "revId": "8281cfc6faea50ee609cc8f01a397692ff7fa4e1", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "3f79a3b5_7beb6ca4", + "filename": "src/js/components/ui/reduxForm/AceEditorInput.js", + "patchSetId": 4 + }, + "lineNbr": 45, + "author": { + "id": 20970 + }, + "writtenOn": "2018-12-04T17:59:17Z", + "side": 1, + "message": "Could we move this to a less file? Could we reuse colors from our patternfly theme?", + "revId": "8281cfc6faea50ee609cc8f01a397692ff7fa4e1", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "3f79a3b5_9b3be834", + "filename": "src/js/components/ui/reduxForm/AceEditorInput.js", + "patchSetId": 4 + }, + "lineNbr": 81, + "author": { + "id": 20970 + }, + "writtenOn": "2018-12-04T17:59:17Z", + "side": 1, + "message": "I would prefer a light-color theme. Kind of like GitHub.", + "revId": "8281cfc6faea50ee609cc8f01a397692ff7fa4e1", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + } + ] +} \ No newline at end of file