Update patch set 4
Patch Set 4: Code-Review-1 (4 comments) Patch-set: 4 Label: Code-Review=-1
This commit is contained in:
parent
0b86ffce6c
commit
b5a1a76877
72
8281cfc6faea50ee609cc8f01a397692ff7fa4e1
Normal file
72
8281cfc6faea50ee609cc8f01a397692ff7fa4e1
Normal file
@ -0,0 +1,72 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_3b99747f",
|
||||
"filename": "src/js/components/containerImages/ContainerImagePrepareParameterForm.js",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 56,
|
||||
"author": {
|
||||
"id": 20970
|
||||
},
|
||||
"writtenOn": "2018-12-04T17:59:17Z",
|
||||
"side": 1,
|
||||
"message": "What\u0027s this magic number?",
|
||||
"revId": "8281cfc6faea50ee609cc8f01a397692ff7fa4e1",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_bbc7c466",
|
||||
"filename": "src/js/components/containerImages/ContainerImagePrepareParameterForm.js",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 87,
|
||||
"author": {
|
||||
"id": 20970
|
||||
},
|
||||
"writtenOn": "2018-12-04T17:59:17Z",
|
||||
"side": 1,
|
||||
"message": "i18l, and maybe say \"Invalid YAML syntax\"",
|
||||
"revId": "8281cfc6faea50ee609cc8f01a397692ff7fa4e1",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_7beb6ca4",
|
||||
"filename": "src/js/components/ui/reduxForm/AceEditorInput.js",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 45,
|
||||
"author": {
|
||||
"id": 20970
|
||||
},
|
||||
"writtenOn": "2018-12-04T17:59:17Z",
|
||||
"side": 1,
|
||||
"message": "Could we move this to a less file? Could we reuse colors from our patternfly theme?",
|
||||
"revId": "8281cfc6faea50ee609cc8f01a397692ff7fa4e1",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_9b3be834",
|
||||
"filename": "src/js/components/ui/reduxForm/AceEditorInput.js",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 81,
|
||||
"author": {
|
||||
"id": 20970
|
||||
},
|
||||
"writtenOn": "2018-12-04T17:59:17Z",
|
||||
"side": 1,
|
||||
"message": "I would prefer a light-color theme. Kind of like GitHub.",
|
||||
"revId": "8281cfc6faea50ee609cc8f01a397692ff7fa4e1",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue
Block a user