openstack/tripleo-upgrade
Code Issues Proposed changes

Add else statement when running leapp without SKIP_DEVEL.

Browse Source 
If leapp_unsubscribed is set to false, the condition won't be
met and the environment variable won't be included. However,
Ansible complains that there is no else statement and the task
fails: the inline if-expression on line 2 evaluated to false and n
o else section was defined. Adding the else statemnt to include
an empty string to solve the issue.

Change-Id: I8a52da5ca81e61a9dd5f39997535965a75a5abba
This commit is contained in:
Jose Luis Franco Arza 2019-08-28 10:36:51 +02:00 committed by Jose Luis Franco
parent 25455a5df0
commit 4e30579960
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tasks/upgrade/undercloud_os_upgrade.yaml
View File

@ -41,7 +41,7 @@
- name: Run leapp upgrade (download packages)
shell: |
set -o pipefail
{{ 'LEAPP_DEVEL_SKIP_RHSM=1 sudo -E' if leapp_unsubscribed|bool and upgrade_workarounds|bool }} leapp upgrade --debug 2>&1 | \
{% if leapp_unsubscribed|bool and upgrade_workarounds|bool %} LEAPP_DEVEL_SKIP_RHSM=1 sudo -E {% endif %}leapp upgrade --debug 2>&1 | \
tee {{ working_dir }}/undercloud_leapp_upgrade.log
- name: Reboot the undercloud