[WIP] [update] verify hardcode values for update validations

This is a WIP to help verify results against [1] when merged
and available in next triplo-validations library.

This patch will be abandoned once testing is complete.

[1] https://review.opendev.org/c/openstack/tripleo-validations/+/892168

Change-Id: I305baa5533f2d64c84dca98f6b9183bfa40c7a03
This commit is contained in:
mcgonago 2023-08-21 16:31:30 -04:00
parent cb45c2dd3c
commit 7b09b0ad5c
5 changed files with 344 additions and 4 deletions

View File

@ -0,0 +1,85 @@
---
# validation_group: validation group to execute
# skiplist_validations: comma separated string of the validations to be skipped in a group
# skiplist_validations_stage: comma separated string of the validations to be skipped in a group defined for a stage, added to the list.
# validation_allowed_groups: list of allowed groups to run
# validation_args: string containing extra arguments for the validation command. (defaults to empty string)
- block:
- name: "Retrieve validations for group {{ validation_group }}"
command: "validation list --group {{ validation_group }} -f value -c ID"
register: validations_in_group
- name: Set fact validations_filtered which removes validations from skiplist
set_fact:
validations_filtered: "{{ validations_in_group.stdout_lines | difference( skiplist_validations.split(',') + skiplist_validations_stage.split(',') ) }}"
- name: "Running validations {{ validations_filtered }}"
register: validations_result
shell: |
set -o pipefail
source {{ undercloud_rc }}
validation run --validation \
verify-package,\
undercloud-disabled-services,\
openstack-endpoints,\
undercloud-service-status,\
rabbitmq-limits,\
check-rsyslog,\
ntp,\
service-status,\
validate-selinux,\
stonith-exists,\
overcloud-service-status,\
ceph-health,\
ovs-dpdk-pmd-cpus-check,\
check-kernel-version,\
tls-everywhere-post-deployment,\
check-manila-policy-file,\
tripleo-haproxy,\
container-status,\
controller-token,\
controller-ulimits,\
fips-enabled,\
frr-status,\
pacemaker-status,\
healthcheck-service-status,\
image-serve,\
mysql-open-files-limit,\
neutron-sanity-check,\
nfv-ovsdpdk-zero-packet-loss-check,\
nova-event-callback,\
nova-svirt \
--inventory {{ upgrade_validation_inventory }} \
{{ validations_extra_args }} 2>&1 {{ timestamper_cmd }} >> validation-{{ validation_group }}.log
when:
- "validations_filtered|length > 0"
args:
executable: /usr/bin/bash
- name: Validation group not executed
debug:
msg: "Validation group {{ validation_group }} is skipped."
when:
- "validations_filtered|length == 0"
rescue:
- name: Retrieve the validations results
command: validation history list -f json -c UUID -c Status
register: validation_history
- name: Set fact validation_status with the validations results
set_fact:
validations_failed: "{{ validation_history.stdout|default('')|from_json|json_query(\"[?Status != 'PASSED'].UUID\") }}"
when: validation_history is defined
- name: Log all the validations failed
shell: |
validation show {{ item }} &>> validation-{{ validation_group }}-failed.log
loop: "{{ validations_failed }}"
when:
- "validations_failed|length > 0"
- name: Fail if some validation is not PASSED
fail:
msg: "Validation failed: check the log in validation-{{ validation_group }}-failed.log."
when:
- "validations_failed|length > 0"
- name: Fail if the validations command didn't succeed
fail:
msg: "Validations failed: check the log in validation-{{ validation_group }}.log."
when:
- validations_result is not succeeded
when: "validation_group in validation_allowed_groups"

View File

@ -0,0 +1,77 @@
---
# validation_group: validation group to execute
# skiplist_validations: comma separated string of the validations to be skipped in a group
# skiplist_validations_stage: comma separated string of the validations to be skipped in a group defined for a stage, added to the list.
# validation_allowed_groups: list of allowed groups to run
# validation_args: string containing extra arguments for the validation command. (defaults to empty string)
- block:
- name: "Retrieve validations for group {{ validation_group }}"
command: "validation list --group {{ validation_group }} -f value -c ID"
register: validations_in_group
- name: Set fact validations_filtered which removes validations from skiplist
set_fact:
validations_filtered: "{{ validations_in_group.stdout_lines | difference( skiplist_validations.split(',') + skiplist_validations_stage.split(',') ) }}"
- name: "Running validations {{ validations_filtered }}"
register: validations_result
shell: |
set -o pipefail
source {{ undercloud_rc }}
validation run --validation \
verify-package,\
ceph-health,\
undercloud-disabled-services,\
openstack-endpoints,\
undercloud-service-status,\
rabbitmq-limits,\
check-rsyslog,\
ntp,\
service-status,\
validate-selinux,\
stonith-exists,\
tripleo-haproxy,\
container-status,\
controller-token,\
controller-ulimits,\
fips-enabled,\
healthcheck-service-status,\
image-serve,\
mysql-open-files-limit,\
neutron-sanity-check,\
nova-event-callback,\
nova-svirt \
--inventory {{ upgrade_validation_inventory }} \
{{ validations_extra_args }} 2>&1 {{ timestamper_cmd }} >> validation-{{ validation_group }}.log
when:
- "validations_filtered|length > 0"
args:
executable: /usr/bin/bash
- name: Validation group not executed
debug:
msg: "Validation group {{ validation_group }} is skipped."
when:
- "validations_filtered|length == 0"
rescue:
- name: Retrieve the validations results
command: validation history list -f json -c UUID -c Status
register: validation_history
- name: Set fact validation_status with the validations results
set_fact:
validations_failed: "{{ validation_history.stdout|default('')|from_json|json_query(\"[?Status != 'PASSED'].UUID\") }}"
when: validation_history is defined
- name: Log all the validations failed
shell: |
validation show {{ item }} &>> validation-{{ validation_group }}-failed.log
loop: "{{ validations_failed }}"
when:
- "validations_failed|length > 0"
- name: Fail if some validation is not PASSED
fail:
msg: "Validation failed: check the log in validation-{{ validation_group }}-failed.log."
when:
- "validations_failed|length > 0"
- name: Fail if the validations command didn't succeed
fail:
msg: "Validations failed: check the log in validation-{{ validation_group }}.log."
when:
- validations_result is not succeeded
when: "validation_group in validation_allowed_groups"

View File

@ -0,0 +1,93 @@
---
# validation_group: validation group to execute
# skiplist_validations: comma separated string of the validations to be skipped in a group
# skiplist_validations_stage: comma separated string of the validations to be skipped in a group defined for a stage, added to the list.
# validation_allowed_groups: list of allowed groups to run
# validation_args: string containing extra arguments for the validation command. (defaults to empty string)
- block:
- name: "Retrieve validations for group {{ validation_group }}"
command: "validation list --group {{ validation_group }} -f value -c ID"
register: validations_in_group
- name: Set fact validations_filtered which removes validations from skiplist
set_fact:
validations_filtered: "{{ validations_in_group.stdout_lines | difference( skiplist_validations.split(',') + skiplist_validations_stage.split(',') ) }}"
- name: "Running validations {{ validations_filtered }}"
register: validations_result
shell: |
set -o pipefail
source {{ undercloud_rc }}
validation run --validation \
verify-package,\
undercloud-sysctl,\
package-version,\
undercloud-disabled-services,\
openstack-endpoints,\
undercloud-service-status,\
rabbitmq-limits,\
check-rsyslog,\
ntp,\
service-status,\
validate-selinux,\
stonith-exists,\
overcloud-service-status,\
ceph-health,\
ovs-dpdk-pmd-cpus-check,\
check-kernel-version,\
tls-everywhere-post-deployment,\
check-manila-policy-file,\
tripleo-haproxy,\
container-status,\
controller-token,\
controller-ulimits,\
fips-enabled,\
frr-status,\
pacemaker-status,\
healthcheck-service-status,\
image-serve,\
mysql-open-files-limit,\
neutron-sanity-check,\
nfv-ovsdpdk-zero-packet-loss-check,\
nova-event-callback,\
nova-svirt \
repos,\
check-for-dangling-images,\
check-reboot,\
system-encoding,\
compute-tsx,\
undercloud-ipa-server-check \
--inventory {{ upgrade_validation_inventory }} \
{{ validations_extra_args }} 2>&1 {{ timestamper_cmd }} >> validation-{{ validation_group }}.log
when:
- "validations_filtered|length > 0"
args:
executable: /usr/bin/bash
- name: Validation group not executed
debug:
msg: "Validation group {{ validation_group }} is skipped."
when:
- "validations_filtered|length == 0"
rescue:
- name: Retrieve the validations results
command: validation history list -f json -c UUID -c Status
register: validation_history
- name: Set fact validation_status with the validations results
set_fact:
validations_failed: "{{ validation_history.stdout|default('')|from_json|json_query(\"[?Status != 'PASSED'].UUID\") }}"
when: validation_history is defined
- name: Log all the validations failed
shell: |
validation show {{ item }} &>> validation-{{ validation_group }}-failed.log
loop: "{{ validations_failed }}"
when:
- "validations_failed|length > 0"
- name: Fail if some validation is not PASSED
fail:
msg: "Validation failed: check the log in validation-{{ validation_group }}-failed.log."
when:
- "validations_failed|length > 0"
- name: Fail if the validations command didn't succeed
fail:
msg: "Validations failed: check the log in validation-{{ validation_group }}.log."
when:
- validations_result is not succeeded
when: "validation_group in validation_allowed_groups"

View File

@ -0,0 +1,85 @@
---
# validation_group: validation group to execute
# skiplist_validations: comma separated string of the validations to be skipped in a group
# skiplist_validations_stage: comma separated string of the validations to be skipped in a group defined for a stage, added to the list.
# validation_allowed_groups: list of allowed groups to run
# validation_args: string containing extra arguments for the validation command. (defaults to empty string)
- block:
- name: "Retrieve validations for group {{ validation_group }}"
command: "validation list --group {{ validation_group }} -f value -c ID"
register: validations_in_group
- name: Set fact validations_filtered which removes validations from skiplist
set_fact:
validations_filtered: "{{ validations_in_group.stdout_lines | difference( skiplist_validations.split(',') + skiplist_validations_stage.split(',') ) }}"
- name: "Running validations {{ validations_filtered }}"
register: validations_result
shell: |
set -o pipefail
source {{ undercloud_rc }}
validation run --validation \
verify-package,\
ceph-health,\
undercloud-disabled-services,\
openstack-endpoints,\
undercloud-service-status,\
rabbitmq-limits,\
check-rsyslog,\
ntp,\
service-status,\
validate-selinux,\
stonith-exists,\
tripleo-haproxy,\
container-status,\
controller-token,\
controller-ulimits,\
fips-enabled,\
healthcheck-service-status,\
image-serve,\
mysql-open-files-limit,\
neutron-sanity-check,\
nova-event-callback,\
nova-svirt, \
undercloud-sysctl,\
package-version,\
repos,\
check-for-dangling-images,\
check-reboot,\
system-encoding,\
compute-tsx,\
undercloud-ipa-server-check \
--inventory {{ upgrade_validation_inventory }} \
{{ validations_extra_args }} 2>&1 {{ timestamper_cmd }} >> validation-{{ validation_group }}.log
when:
- "validations_filtered|length > 0"
args:
executable: /usr/bin/bash
- name: Validation group not executed
debug:
msg: "Validation group {{ validation_group }} is skipped."
when:
- "validations_filtered|length == 0"
rescue:
- name: Retrieve the validations results
command: validation history list -f json -c UUID -c Status
register: validation_history
- name: Set fact validation_status with the validations results
set_fact:
validations_failed: "{{ validation_history.stdout|default('')|from_json|json_query(\"[?Status != 'PASSED'].UUID\") }}"
when: validation_history is defined
- name: Log all the validations failed
shell: |
validation show {{ item }} &>> validation-{{ validation_group }}-failed.log
loop: "{{ validations_failed }}"
when:
- "validations_failed|length > 0"
- name: Fail if some validation is not PASSED
fail:
msg: "Validation failed: check the log in validation-{{ validation_group }}-failed.log."
when:
- "validations_failed|length > 0"
- name: Fail if the validations command didn't succeed
fail:
msg: "Validations failed: check the log in validation-{{ validation_group }}.log."
when:
- validations_result is not succeeded
when: "validation_group in validation_allowed_groups"

View File

@ -27,7 +27,7 @@
import_tasks: ../common/undercloud_prerequisites.yaml
- name: run pre-update validation
import_tasks: ../common/validation_group_run.yaml
import_tasks: ../common/validation_group_run_pre_update_blue.yaml
vars:
validation_group: "pre-update"
validation_allowed_groups: "{{ updates_validations_groups }}"
@ -95,7 +95,7 @@
- overcloud_update_prepare
- name: run pre-update-prepare validation
import_tasks: ../common/validation_group_run.yaml
import_tasks: ../common/validation_group_run_pre_update_blue.yaml
vars:
validation_group: "pre-update-prepare"
validation_allowed_groups: "{{ updates_validations_groups }}"
@ -186,7 +186,7 @@
- overcloud_update_run
- name: run pre-update-run validation
import_tasks: ../common/validation_group_run.yaml
import_tasks: ../common/validation_group_run_pre_update_blue.yaml
vars:
validation_group: "pre-update-run"
validation_allowed_groups: "{{ updates_validations_groups }}"
@ -269,7 +269,7 @@
- log_stages|bool
- name: run post-update validation
import_tasks: ../common/validation_group_run.yaml
import_tasks: ../common/validation_group_run_post_update_blue.yaml
vars:
validation_group: "post-update"
validation_allowed_groups: "{{ updates_validations_groups }}"