Adjust roles_data also for updates.

During the update prepare process, if
some of the services defined in the roles
data where deprecated in the version to
update to, an error will be retrieved during
container image downloading as the service
is not present anymore. This patch enables
the roles_data adjusting, which was run in
upgrades, also in updates.

Change-Id: I1e1fc6471525855fb09280131e7847f21b1a74d8
Related-Bug: #1784624

tasks/common/adjust-roles-data.yaml

@@ -5,6 +5,7 @@
     path: "{{ roles_data }}"
     regexp: '(\s+)- OS::TripleO::Services::FluentdClient$'
     replace: '\1- OS::TripleO::Services::Fluentd'
+  when: overcloud_upgrade|bool
 
 - name: remove ManilaBackendGeneric resource
   # https://bugzilla.redhat.com/show_bug.cgi?id=1541382

tasks/update/overcloud_update_prepare.yml

@@ -1,4 +1,8 @@
 ---
+- name: adjust role-data for Pike update
+  include: ../common/adjust-roles-data.yaml
+  when: custom_roles_used|bool
+
 - name: setup HEAT outputs via update prepare
   shell: |
     set -o pipefail

tasks/upgrade/overcloud_upgrade_prepare.yml

@@ -1,6 +1,6 @@
 ---
 - name: adjust role-data for P->Q upgrade
-  include: adjust-roles-data.yaml
+  include: ../common/adjust-roles-data.yaml
   when: custom_roles_used|bool
 
 - name: add upgrade init script to upgrade prepare params