tripleo-upgrade/3e56c2a88aab5e741756f2d596a5168ec7a52f17

{
  "comments": [
    {
      "unresolved": false,
      "key": {
        "uuid": "8afe3770_ece5170e",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 1
      },
      "lineNbr": 0,
      "author": {
        "id": 26343
      },
      "writtenOn": "2021-10-14T09:29:00Z",
      "side": 1,
      "message": "I\u0027m confused...I don\u0027t understand very well what are the differences between this patch and https://review.opendev.org/c/openstack/tripleo-upgrade/+/803236/7/templates/node_upgrade_pre.sh.j2 as the changes are more the less the same. Won\u0027t you have a conflict when trying to merge them both?",
      "revId": "3e56c2a88aab5e741756f2d596a5168ec7a52f17",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "e6f7ad4a_ade709b8",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 1
      },
      "lineNbr": 0,
      "author": {
        "id": 20171
      },
      "writtenOn": "2021-10-14T10:31:30Z",
      "side": 1,
      "message": "Lets deal with this one first, if needed will manually rebase the patch",
      "parentUuid": "8afe3770_ece5170e",
      "revId": "3e56c2a88aab5e741756f2d596a5168ec7a52f17",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "04715d35_216d0feb",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 1
      },
      "lineNbr": 0,
      "author": {
        "id": 26343
      },
      "writtenOn": "2021-10-14T12:58:17Z",
      "side": 1,
      "message": "Well, I think there is a missunderstanding on the git workflow here. The benefit of git is that it allows us isolate changes per commit, so if something goes wrong we can remove the conflicting piece. However, this patch is including changes from another patch, plus most of the changes submitted here are not even in the description (because they belong to another patch). I think this patch should contain only the differences with https://review.opendev.org/c/openstack/tripleo-upgrade/+/803236",
      "parentUuid": "e6f7ad4a_ade709b8",
      "revId": "3e56c2a88aab5e741756f2d596a5168ec7a52f17",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "8d8e5026_6510cf1d",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 1
      },
      "lineNbr": 0,
      "author": {
        "id": 20171
      },
      "writtenOn": "2021-10-17T11:03:52Z",
      "side": 1,
      "message": "Ack",
      "parentUuid": "04715d35_216d0feb",
      "revId": "3e56c2a88aab5e741756f2d596a5168ec7a52f17",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "25476ed9_2d7d25a3",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 1
      },
      "lineNbr": 0,
      "author": {
        "id": 31245
      },
      "writtenOn": "2023-04-28T12:56:07Z",
      "side": 1,
      "message": "No more updated in almost two years now, we can probably abodon this patch.",
      "revId": "3e56c2a88aab5e741756f2d596a5168ec7a52f17",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "1018a12d_840df37a",
        "filename": "infrared_plugin/main.yml",
        "patchSetId": 1
      },
      "lineNbr": 142,
      "author": {
        "id": 26343
      },
      "writtenOn": "2021-10-14T09:29:00Z",
      "side": 1,
      "message": "Careful with this, as the timeout is an integer and not a boolean if you pass a timeout of 0 it won\u0027t set the parameter. I think, in this case you can leave the - install.upgrade.compute.migration.timeout out of the when: and simply assign it, as infrared will default the value to 120. A similar example is what you can find in line 30 with workload memory. As it is a number, not a boolean it simply assigns it.\nAnyway, the other condition (groups[compute_group] | length \u003e 1) can remain there.",
      "revId": "3e56c2a88aab5e741756f2d596a5168ec7a52f17",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "552d2f1a_b4ef6672",
        "filename": "infrared_plugin/main.yml",
        "patchSetId": 1
      },
      "lineNbr": 142,
      "author": {
        "id": 20171
      },
      "writtenOn": "2021-10-14T10:31:30Z",
      "side": 1,
      "message": "That was cherry picked from master, what would you recommend to do?",
      "parentUuid": "1018a12d_840df37a",
      "revId": "3e56c2a88aab5e741756f2d596a5168ec7a52f17",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "42b2df64_2e2da754",
        "filename": "infrared_plugin/main.yml",
        "patchSetId": 1
      },
      "lineNbr": 142,
      "author": {
        "id": 11090
      },
      "writtenOn": "2021-10-15T10:04:24Z",
      "side": 1,
      "message": "Fix master, then update this request (squash)",
      "parentUuid": "552d2f1a_b4ef6672",
      "revId": "3e56c2a88aab5e741756f2d596a5168ec7a52f17",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "4ee27739_3b542f4e",
        "filename": "infrared_plugin/main.yml",
        "patchSetId": 1
      },
      "lineNbr": 142,
      "author": {
        "id": 20171
      },
      "writtenOn": "2021-10-17T11:03:52Z",
      "side": 1,
      "message": "Ack",
      "parentUuid": "42b2df64_2e2da754",
      "revId": "3e56c2a88aab5e741756f2d596a5168ec7a52f17",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "540eab0c_4799c616",
        "filename": "infrared_plugin/main.yml",
        "patchSetId": 1
      },
      "lineNbr": 142,
      "author": {
        "id": 11090
      },
      "writtenOn": "2021-11-08T11:18:35Z",
      "side": 1,
      "message": "(install.upgrade.compute.migration.timeout \u003e 0) or \n(install.upgrade.compute.migration.timeout|int \u003e 0)",
      "parentUuid": "4ee27739_3b542f4e",
      "revId": "3e56c2a88aab5e741756f2d596a5168ec7a52f17",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}