openstack/tripleo-validations
Code Issues Proposed changes

Add new metadata keys to the validation playbooks

Browse Source 
This patch adds two new metadata keys to the validation playbooks:
- categories: A list of technical tags
- products: A list of targeted products (here mainly TripleO)

This patch is also part of the Validation Metadata Evolution for the
Validations Framework.

Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
Change-Id: I80c6b0ffb07b6311f13d7a3b83031317cd0d38de
(cherry picked from commit 39a846ca6b)
This commit is contained in:
Gael Chamoulaud (Strider) 2021-06-16 15:17:54 +02:00
parent 23a2ec2164
commit 9b853e6b82
No known key found for this signature in database
GPG Key ID: 4119D0305C651D66
57 changed files with 402 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
playbooks/ceph-dependencies-installed.yaml
View File

@ -8,6 +8,11 @@
groups:
- pre-deployment
- pre-ceph
categories:
- storage
products:
- tripleo
- ceph
fail_without_deps: true
tripleo_delegate_to: "{{ groups['allovercloud'] | default([]) }}"
packages:

5
playbooks/ceph-health.yaml
View File

@ -10,6 +10,11 @@
- backup-and-restore
- post-deployment
- post-ceph
categories:
- storage
products:
- tripleo
- ceph
tripleo_delegate_to: "{{ groups['ceph_mon'] | default([]) }}"
osd_percentage_min: 0
tasks:

5
playbooks/ceph-pg.yaml
View File

@ -15,6 +15,11 @@
is running but before the pools are created to realize the deployment
will fail.
groups: []
categories:
- storage
products:
- tripleo
- ceph
tasks:
- include_role:
name: ceph

4
playbooks/check-for-dangling-images.yaml
View File

@ -8,6 +8,10 @@
Make sure before update we do not have any dangling images.
groups:
- pre-update
categories:
- container
products:
- tripleo
check_for_dangling_images_debug: false
roles:
- check_for_dangling_images

6
playbooks/check-kernel-version.yaml
View File

@ -9,5 +9,11 @@
el8 is in kernel (uname -r) version string
groups:
- post-deployment
categories:
- os
- kernel
- system
products:
- tripleo
roles:
- check_kernel_version

5
playbooks/check-network-gateway.yaml
View File

@ -8,5 +8,10 @@
verify that the gateway exists and is reachable.
groups:
- pre-introspection
categories:
- networking
- undercloud-config
products:
- tripleo
roles:
- check_network_gateway

8
playbooks/check-rhsm-version.yaml
View File

@ -11,6 +11,14 @@
groups:
- pre-undercloud-upgrade
- pre-overcloud-upgrade
categories:
- rhel
- os
- system
- subscription_management
products:
- tripleo
- rhsm
check_rhsm_version_debug: false
roles:
- check_rhsm_version

5
playbooks/check-uc-hostname.yaml
View File

@ -9,6 +9,11 @@
points to the right UC hostname
groups:
- pre-overcloud-upgrade
categories:
- container
- undercloud-config
products:
- tripleo
check_uc_hostname_debug: false
roles:
- check_uc_hostname

6
playbooks/check-undercloud-conf.yaml
View File

@ -5,11 +5,15 @@
name: Verify undercloud.conf correctness
description: |
This validation verifies that no deprecated, invalid or
incompatible parameters are being passwed in the Undercloud's
incompatible parameters are being passed in the Undercloud's
undercloud.conf configuration file.
groups:
- prep
- pre-undercloud-upgrade
categories:
- undercloud-config
products:
- tripleo
check_undercloud_conf_debug: false
roles:
- check_undercloud_conf

7
playbooks/collect-flavors-and-verify-profiles.yaml
View File

@ -9,5 +9,12 @@
groups:
- pre-deployment
- pre-upgrade
categories:
- compute
- baremetal
- provisioning
- undercloud
products:
- tripleo
roles:
- collect_flavors_and_verify_profiles

10
playbooks/compute-tsx.yaml
View File

@ -25,6 +25,16 @@
- pre-update-prepare
- pre-update-run
- pre-update-converge
categories:
- os
- kernel
- system
- tsx
products:
- tripleo
- rhel
- centos
- intel
compute_tsx_debug: false
compute_tsx_warning: false
roles:

7
playbooks/container-status.yaml
View File

@ -11,5 +11,12 @@
- pre-update
- post-deployment
- post-upgrade
categories:
- container
- undercloud
- overcloud
- undercloud-config
products:
- tripleo
roles:
- container_status

7
playbooks/controller-token.yaml
View File

@ -10,6 +10,13 @@
undercloud and overcloud controller after deployment.
groups:
- post-deployment
categories:
- keystone
- identity
- undercloud
- controller
products:
- tripleo
keystone_conf_file: "/var/lib/config-data/puppet-generated/keystone/etc/keystone/keystone.conf"
roles:
- controller_token

8
playbooks/controller-ulimits.yaml
View File

@ -7,6 +7,14 @@
This will check the ulimits of each controller.
groups:
- post-deployment
categories:
- os
- system
- resources
- overcloud
- controller
products:
- tripleo
nofiles_min: 1024
nproc_min: 2048
roles:

6
playbooks/ctlplane-ip-range.yaml
View File

@ -8,6 +8,12 @@
`dhcp_end` fields in `undercloud.conf` is not too low.
groups:
- pre-introspection
categories:
- networking
- dhcp
- undercloud
products:
- tripleo
ctlplane_iprange_min_size: 20
roles:
- ctlplane_ip_range

7
playbooks/default-node-count.yaml
View File

@ -8,5 +8,12 @@
add up.
groups:
- pre-deployment
categories:
- compute
- roles
- baremetal
- undercloud
products:
- tripleo
roles:
- default_node_count

8
playbooks/dhcp-introspection.yaml
View File

@ -12,6 +12,14 @@
interface specified in ironic-inspector.conf.
groups:
- pre-introspection
categories:
- networking
- dhcp
- dnsmasq
- undercloud
- baremetal
products:
- tripleo
tasks:
- include_role:
name: dhcp_validations

7
playbooks/dhcp-provisioning.yaml
View File

@ -13,6 +13,13 @@
are any.
groups:
- pre-deployment
categories:
- networking
- dhcp
- undercloud
- undercloud-config
products:
- tripleo
tasks:
- include_role:
name: dhcp_validations

8
playbooks/frr-status.yaml
View File

@ -10,5 +10,13 @@
daemon is not operational.
groups:
- post-deployment
categories:
- container
- frrouting
- iprouting
- undercloud
- overcloud
products:
- tripleo
roles:
- frr_status

10
playbooks/healthcheck-service-status.yaml
View File

@ -8,6 +8,16 @@
groups:
- backup-and-restore
- post-deployment
categories:
- os
- system
- systemd
- healthcheck
- services
- undercloud
- overcloud
products:
- tripleo
retries_number: 1
delay_number: 1
inflight_healthcheck_services: []

7
playbooks/image-serve.yaml
View File

@ -10,5 +10,12 @@
- pre-upgrade
- post-deployment
- post-upgrade
categories:
- httpd
- container
- registry
- undercloud
products:
- tripleo
roles:
- image_serve

6
playbooks/ironic-boot-configuration.yaml
View File

@ -8,5 +8,11 @@
groups:
- pre-deployment
- pre-upgrade
categories:
- baremetal
- provisioning
- undercloud
products:
- tripleo
roles:
- ironic_boot_configuration

8
playbooks/mysql-open-files-limit.yaml
View File

@ -11,6 +11,14 @@
https://access.redhat.com/solutions/1598733
groups:
- post-deployment
categories:
- database
- overcloud
- controller
products:
- tripleo
- mysql
- galera
min_open_files_limit: 16384
roles:
- mysql_open_files_limit

7
playbooks/network-environment.yaml
View File

@ -14,6 +14,13 @@
http://tripleo.org/advanced_deployment/network_isolation.html
groups:
- pre-deployment
categories:
- networking
- undercloud
- network_isolation
- undercloud
products:
- tripleo
network_environment_path: environments/network-environment.yaml
plan_env_path: plan-environment.yaml
ip_pools_path: environments/ips-from-pool-all.yaml

11
playbooks/neutron-sanity-check.yaml
View File

@ -10,10 +10,17 @@
The tool expects all the configuration files that are passed
to the Neutron services.
groups:
- backup-and-restore
- post-deployment
categories:
- networking
- neutron
- overcloud
- controller
- undercloud-config
- container
products:
- tripleo
roles:
- neutron_sanity_check

7
playbooks/nfv-ovsdpdk-zero-packet-loss-check.yaml
View File

@ -9,6 +9,11 @@
The tool expects all the configuration files that are passed.
groups:
- post-deployment
categories:
- networking
- compute
- nfv
products:
- tripleo
roles:
- check_nfv_ovsdpdk_zero_packet_loss

8
playbooks/node-disks.yaml
View File

@ -7,6 +7,14 @@
Check node disk numbers and sizes and whether root device hints are set.
groups:
- pre-deployment
categories:
- baremetal
- provisioning
- compute
- introspection
- undercloud
products:
- tripleo
ironic_conf_file: "/var/lib/config-data/puppet-generated/ironic/etc/ironic/ironic.conf"
roles:
- node_disks

8
playbooks/node-health.yaml
View File

@ -8,5 +8,13 @@
scale-up or an upgrade.
groups:
- pre-upgrade
categories:
- icmp
- compute
- baremetal
- provisioning
- undercloud
products:
- tripleo
roles:
- node_health

4
playbooks/nova-status.yaml
View File

@ -19,5 +19,9 @@
groups:
- backup-and-restore
- pre-upgrade
categories:
- compute
products:
- tripleo
roles:
- nova_status

6
playbooks/nova-svirt.yaml
View File

@ -9,5 +9,11 @@
groups:
- post-deployment
- post-upgrade
categories:
- compute
- selinux
- security
products:
- tripleo
roles:
- nova_svirt

7
playbooks/openshift-hw-requirements.yaml
View File

@ -13,6 +13,13 @@
- Are there sufficient compute resources available for a default setup? (1 Master node, 1 Infra node, 2 App nodes)
groups:
- openshift-on-openstack
categories:
- hardware
- provisioning
- compute
- storage
products:
- tripleo
min_total_ram_testing: 16384 # 4 per node
min_total_vcpus_testing: 4 # 1 per node
min_total_disk_testing: 93 # Master: 40, others: 17 per node

4
playbooks/openshift-nw-requirements.yaml
View File

@ -8,6 +8,10 @@
required for an OpenShift deployment on top of OpenStack.
groups:
- openshift-on-openstack
categories:
- networking
products:
- tripleo
tasks:
- include_role:
name: openshift_on_openstack

6
playbooks/openstack-endpoints.yaml
View File

@ -13,5 +13,11 @@
- post-upgrade
- pre-update
- post-update
categories:
- ui
- connectivity
- undercloud
products:
- tripleo
roles:
- openstack_endpoints

11
playbooks/oslo-config-validator.yaml
View File

@ -18,6 +18,17 @@
- post-system-upgrade
- post-update
- post-upgrade
categories:
- undercloud
- overcloud
- oslo
- compute
- storage
- baremetal
- networking
- identity
products:
- tripleo
# Debug log level
oslo_config_validator_debug: false

8
playbooks/overcloud-service-status.yaml
View File

@ -13,6 +13,14 @@
- post-upgrade
- post-overcloud-upgrade
- post-overcloud-converge
categories:
- api
- compute
- storage
- undercloud
- overcloud
products:
- tripleo
overcloud_service_status_debug: false
overcloud_service_api:
- nova

6
playbooks/ovs-dpdk-pmd-cpus-check.yaml
View File

@ -10,5 +10,11 @@
configured correctly.
groups:
- post-deployment
categories:
- networking
- compute
- nfv
products:
- tripleo
roles:
- ovs_dpdk_pmd

8
playbooks/pacemaker-status.yaml
View File

@ -14,5 +14,13 @@
groups:
- backup-and-restore
- post-deployment
categories:
- ha
- clustering
- system
- os
products:
- tripleo
- pacemaker
roles:
- pacemaker_status

7
playbooks/package-version.yaml
View File

@ -17,6 +17,13 @@
- pre-overcloud-upgrade
- pre-overcloud-converge
- pre-ceph
categories:
- rpm
- os
- system
- packaging
products:
- tripleo
package_version_debug: false
roles:
- package_version

7
playbooks/rabbitmq-limits.yaml
View File

@ -7,6 +7,13 @@
Make sure the rabbitmq file descriptor limits are set to reasonable values.
groups:
- post-deployment
categories:
- container
- messaging
- broker
products:
- tripleo
- rabbitmq
min_fd_limit: 16384
roles:
- rabbitmq_limits

8
playbooks/repos.yaml
View File

@ -13,5 +13,13 @@
groups:
- pre-upgrade
- pre-update
categories:
- os
- system
- packaging
- rpm
- repository
products:
- tripleo
roles:
- repos

6
playbooks/stack-health.yaml
View File

@ -9,5 +9,11 @@
groups:
- pre-upgrade
- post-upgrade
categories:
- orchestration
- healthcheck
- stack
products:
- tripleo
roles:
- stack_health

8
playbooks/stonith-exists.yaml
View File

@ -11,5 +11,13 @@
https://access.redhat.com/documentation/en/red-hat-openstack-platform/8/paged/director-installation-and-usage/86-fencing-the-controller-nodes
groups:
- post-deployment
categories:
- ha
- clustering
- os
- system
products:
- tripleo
- pacemaker
roles:
- stonith_exists

9
playbooks/switch-vlans.yaml
View File

@ -12,6 +12,15 @@
not on a particular switch port.
groups:
- pre-deployment
categories:
- networking
- vlans
- lldp
- introspection
- baremetal
- provisioning
products:
- tripleo
network_environment_path: environments/network-environment.yaml
ironic_inspector_conf_file: "/var/lib/config-data/puppet-generated/ironic_inspector/etc/ironic-inspector/inspector.conf"
roles:

6
playbooks/system-encoding.yaml
View File

@ -9,6 +9,12 @@
- pre-deployment
- pre-upgrade
- pre-update
categories:
- os
- system
- encoding
products:
- tripleo
system_encoding_debug: false
roles:
- system_encoding

9
playbooks/tls-everywhere-post-deployment.yaml
View File

@ -9,6 +9,15 @@
MONITORING state.
groups:
- post-deployment
categories:
- security
- tls-everywhere
- identity
- dns
- kerberos
products:
- tripleo
- freeipa
tasks:
- include_role:
name: tls_everywhere

9
playbooks/tls-everywhere-pre-deployment.yaml
View File

@ -8,6 +8,15 @@
that we are ready to do the overcloud deploy with tls-everywhere.
groups:
- pre-deployment
categories:
- security
- tls-everywhere
- identity
- dns
- kerberos
products:
- tripleo
- freeipa
tasks:
- include_role:
name: tls_everywhere

9
playbooks/tls-everywhere-prep.yaml
View File

@ -8,6 +8,15 @@
to register to IdM as a client as part of undercloud-install.
groups:
- prep
categories:
- security
- tls-everywhere
- identity
- dns
- kerberos
products:
- tripleo
- freeipa
tasks:
- include_role:
name: tls_everywhere

7
playbooks/tripleo-latest-packages-version.yaml
View File

@ -9,6 +9,13 @@
before starting an upgrade.
groups:
- pre-upgrade
categories:
- os
- system
- packaging
- rpm
products:
- tripleo
packages_list:
- python3-tripleoclient
roles:

7
playbooks/undercloud-debug.yaml
View File

@ -10,6 +10,13 @@
is not a good thing.
groups:
- pre-deployment
categories:
- compute
- networking
- telemetry
- baremetal
products:
- tripleo
debug_check: "True"
roles:
- undercloud_debug

7
playbooks/undercloud-disk-space-pre-upgrade.yaml
View File

@ -10,6 +10,13 @@
http://tripleo.org/install/environments/baremetal.html#minimum-system-requirements
groups:
- pre-upgrade
categories:
- storage
- disk
- os
- system
products:
- tripleo
volumes:
- {mount: /var/lib/docker, min_size: 10}
- {mount: /var/lib/config-data, min_size: 3}

7
playbooks/undercloud-disk-space.yaml
View File

@ -11,6 +11,13 @@
groups:
- prep
- pre-introspection
categories:
- storage
- disk
- os
- system
products:
- tripleo
volumes:
- {mount: /var/lib/docker, min_size: 10}
- {mount: /var/lib/config-data, min_size: 3}

7
playbooks/undercloud-heat-purge-deleted.yaml
View File

@ -11,6 +11,13 @@
- pre-upgrade
- pre-update
- pre-deployment
categories:
- orchestration
- os
- system
- cron
products:
- tripleo
cron_check: "heat-manage purge_deleted"
roles:
- undercloud_heat_purge_deleted

9
playbooks/undercloud-ipa-server-check.yaml
View File

@ -19,6 +19,15 @@
groups:
- pre-upgrade
- pre-update
categories:
- security
- tls-everywhere
- identity
- dns
- kerberos
products:
- tripleo
- freeipa
tasks:
- include_role:
name: tls_everywhere

9
playbooks/undercloud-neutron-sanity-check.yaml
View File

@ -12,6 +12,15 @@
groups:
- pre-introspection
categories:
- networking
- neutron
- overcloud
- controller
- undercloud-config
- container
products:
- tripleo
# The list of Neutron configuration files and directories that
# will be passed to the Neutron services. The order is important

5
playbooks/undercloud-process-count.yaml
View File

@ -10,6 +10,11 @@
to crashes due to OOMKiller.
groups:
- pre-deployment
categories:
- os
- system
products:
- tripleo
max_process_count: 8
roles:
- undercloud_process_count

7
playbooks/undercloud-service-status.yaml
View File

@ -11,5 +11,12 @@
- pre-upgrade
- post-update
- pre-update
categories:
- os
- system
- systemd
- services
products:
- tripleo
roles:
- undercloud_service_status

7
playbooks/undercloud-tokenflush.yaml
View File

@ -9,6 +9,13 @@
the keystone token_flush crontab has been set up.
groups:
- pre-introspection
categories:
- os
- system
- identity
- cron
products:
- tripleo
cron_check: "keystone-manage token_flush"
roles:
- undercloud_tokenflush