Browse Source

Merge "Optimize linters executions from tox and pre-commit" into stable/train

changes/75/825275/1
Zuul 4 months ago committed by Gerrit Code Review
parent
commit
9bd40474de
  1. 2
      .pre-commit-config.yaml
  2. 1
      LICENSE
  3. 1
      babel.cfg
  4. 1
      doc/source/modules.rst
  5. 1
      doc/source/modules/modules-ceph_pools_pg_protection.rst
  6. 1
      doc/source/modules/modules-check_cpus_aligned_with_dpdk_nics.rst
  7. 1
      doc/source/modules/modules-check_flavors.rst
  8. 1
      doc/source/modules/modules-check_ironic_boot_config.rst
  9. 1
      doc/source/modules/modules-check_other_processes_pmd_usage.rst
  10. 1
      doc/source/modules/modules-convert_range_to_numbers_list.rst
  11. 1
      doc/source/modules/modules-docker_facts.rst
  12. 1
      doc/source/modules/modules-get_dpdk_nics_numa_info.rst
  13. 1
      doc/source/modules/modules-icmp_ping.rst
  14. 1
      doc/source/modules/modules-ip_range.rst
  15. 1
      doc/source/modules/modules-network_environment.rst
  16. 1
      doc/source/modules/modules-node_disks.rst
  17. 1
      doc/source/modules/modules-overcloudrc.rst
  18. 1
      doc/source/modules/modules-ovs_dpdk_pmd_cpus_check.rst
  19. 1
      doc/source/modules/modules-pacemaker.rst
  20. 1
      doc/source/modules/modules-pmd_threads_siblings_check.rst
  21. 1
      doc/source/modules/modules-switch_vlans.rst
  22. 1
      doc/source/modules/modules-verify_profiles.rst
  23. 1
      doc/source/roles.rst
  24. 1
      doc/source/roles/role-ceilometerdb_size.rst
  25. 1
      doc/source/roles/role-ceph.rst
  26. 1
      doc/source/roles/role-check_network_gateway.rst
  27. 1
      doc/source/roles/role-collect_flavors_and_verify_profiles.rst
  28. 1
      doc/source/roles/role-compute_tsx.rst
  29. 1
      doc/source/roles/role-containerized_undercloud_docker.rst
  30. 1
      doc/source/roles/role-controller_token.rst
  31. 1
      doc/source/roles/role-controller_ulimits.rst
  32. 1
      doc/source/roles/role-ctlplane_ip_range.rst
  33. 1
      doc/source/roles/role-default_node_count.rst
  34. 1
      doc/source/roles/role-dhcp_validations.rst
  35. 1
      doc/source/roles/role-image_serve.rst
  36. 1
      doc/source/roles/role-ironic_boot_configuration.rst
  37. 1
      doc/source/roles/role-mysql_open_files_limit.rst
  38. 1
      doc/source/roles/role-network_environment.rst
  39. 1
      doc/source/roles/role-neutron_sanity_check.rst
  40. 1
      doc/source/roles/role-node_disks.rst
  41. 1
      doc/source/roles/role-node_health.rst
  42. 1
      doc/source/roles/role-nova_event_callback.rst
  43. 1
      doc/source/roles/role-nova_status.rst
  44. 1
      doc/source/roles/role-openshift_on_openstack.rst
  45. 1
      doc/source/roles/role-openstack_endpoints.rst
  46. 1
      doc/source/roles/role-overcloud_service_status.rst
  47. 1
      doc/source/roles/role-ovs_dpdk_pmd.rst
  48. 1
      doc/source/roles/role-pacemaker_status.rst
  49. 1
      doc/source/roles/role-rabbitmq_limits.rst
  50. 1
      doc/source/roles/role-repos.rst
  51. 1
      doc/source/roles/role-stack_health.rst
  52. 1
      doc/source/roles/role-stonith_exists.rst
  53. 1
      doc/source/roles/role-switch_vlans.rst
  54. 1
      doc/source/roles/role-tls_everywhere.rst
  55. 1
      doc/source/roles/role-undercloud_debug.rst
  56. 1
      doc/source/roles/role-undercloud_disk_space.rst
  57. 1
      doc/source/roles/role-undercloud_heat_purge_deleted.rst
  58. 1
      doc/source/roles/role-undercloud_process_count.rst
  59. 1
      doc/source/roles/role-undercloud_service_status.rst
  60. 2
      releasenotes/notes/add-ceph-health-check-000bab9581c759d3.yaml
  61. 2
      tests/hosts.ini
  62. 47
      tox.ini

2
.pre-commit-config.yaml

@ -12,8 +12,6 @@ repos:
- id: debug-statements
- id: flake8
entry: flake8 --ignore=E24,E121,E122,E123,E124,E126,E226,E265,E305,E402,F401,F405,E501,E704,F403,F841,W503,W605
- id: check-yaml
files: .*\.(yaml|yml)$
- repo: https://github.com/adrienverge/yamllint.git
rev: v1.15.0
hooks:

1
LICENSE

@ -173,4 +173,3 @@
defend, and hold each Contributor harmless for any liability
incurred by, or claims asserted against, such Contributor by reason
of your accepting any such warranty or additional liability.

1
babel.cfg

@ -1,2 +1 @@
[python: **.py]

1
doc/source/modules.rst

@ -7,4 +7,3 @@ Contents:
:glob:
modules/*

1
doc/source/modules/modules-ceph_pools_pg_protection.rst

@ -12,4 +12,3 @@ This module provides for the following ansible plugin:
:module: library/ceph_pools_pg_protection.py
:documentation: true
:examples: true

1
doc/source/modules/modules-check_cpus_aligned_with_dpdk_nics.rst

@ -12,4 +12,3 @@ This module provides for the following ansible plugin:
:module: library/check_cpus_aligned_with_dpdk_nics.py
:documentation: true
:examples: true

1
doc/source/modules/modules-check_flavors.rst

@ -12,4 +12,3 @@ This module provides for the following ansible plugin:
:module: library/check_flavors.py
:documentation: true
:examples: true

1
doc/source/modules/modules-check_ironic_boot_config.rst

@ -12,4 +12,3 @@ This module provides for the following ansible plugin:
:module: library/check_ironic_boot_config.py
:documentation: true
:examples: true

1
doc/source/modules/modules-check_other_processes_pmd_usage.rst

@ -12,4 +12,3 @@ This module provides for the following ansible plugin:
:module: library/check_other_processes_pmd_usage.py
:documentation: true
:examples: true

1
doc/source/modules/modules-convert_range_to_numbers_list.rst

@ -12,4 +12,3 @@ This module provides for the following ansible plugin:
:module: library/convert_range_to_numbers_list.py
:documentation: true
:examples: true

1
doc/source/modules/modules-docker_facts.rst

@ -12,4 +12,3 @@ This module provides for the following ansible plugin:
:module: library/docker_facts.py
:documentation: true
:examples: true

1
doc/source/modules/modules-get_dpdk_nics_numa_info.rst

@ -12,4 +12,3 @@ This module provides for the following ansible plugin:
:module: library/get_dpdk_nics_numa_info.py
:documentation: true
:examples: true

1
doc/source/modules/modules-icmp_ping.rst

@ -12,4 +12,3 @@ This module provides for the following ansible plugin:
:module: library/icmp_ping.py
:documentation: true
:examples: true

1
doc/source/modules/modules-ip_range.rst

@ -12,4 +12,3 @@ This module provides for the following ansible plugin:
:module: library/ip_range.py
:documentation: true
:examples: true

1
doc/source/modules/modules-network_environment.rst

@ -12,4 +12,3 @@ This module provides for the following ansible plugin:
:module: library/network_environment.py
:documentation: true
:examples: true

1
doc/source/modules/modules-node_disks.rst

@ -12,4 +12,3 @@ This module provides for the following ansible plugin:
:module: library/node_disks.py
:documentation: true
:examples: true

1
doc/source/modules/modules-overcloudrc.rst

@ -12,4 +12,3 @@ This module provides for the following ansible plugin:
:module: library/overcloudrc.py
:documentation: true
:examples: true

1
doc/source/modules/modules-ovs_dpdk_pmd_cpus_check.rst

@ -12,4 +12,3 @@ This module provides for the following ansible plugin:
:module: library/ovs_dpdk_pmd_cpus_check.py
:documentation: true
:examples: true

1
doc/source/modules/modules-pacemaker.rst

@ -12,4 +12,3 @@ This module provides for the following ansible plugin:
:module: library/pacemaker.py
:documentation: true
:examples: true

1
doc/source/modules/modules-pmd_threads_siblings_check.rst

@ -12,4 +12,3 @@ This module provides for the following ansible plugin:
:module: library/pmd_threads_siblings_check.py
:documentation: true
:examples: true

1
doc/source/modules/modules-switch_vlans.rst

@ -12,4 +12,3 @@ This module provides for the following ansible plugin:
:module: library/switch_vlans.py
:documentation: true
:examples: true

1
doc/source/modules/modules-verify_profiles.rst

@ -12,4 +12,3 @@ This module provides for the following ansible plugin:
:module: library/verify_profiles.py
:documentation: true
:examples: true

1
doc/source/roles.rst

@ -7,4 +7,3 @@ Contents:
:glob:
roles/*

1
doc/source/roles/role-ceilometerdb_size.rst

@ -4,4 +4,3 @@ ceilometerdb_size
.. ansibleautoplugin::
:role: roles/ceilometerdb_size

1
doc/source/roles/role-ceph.rst

@ -4,4 +4,3 @@ ceph
.. ansibleautoplugin::
:role: roles/ceph

1
doc/source/roles/role-check_network_gateway.rst

@ -4,4 +4,3 @@ check_network_gateway
.. ansibleautoplugin::
:role: roles/check_network_gateway

1
doc/source/roles/role-collect_flavors_and_verify_profiles.rst

@ -4,4 +4,3 @@ collect_flavors_and_verify_profiles
.. ansibleautoplugin::
:role: roles/collect_flavors_and_verify_profiles

1
doc/source/roles/role-compute_tsx.rst

@ -6,4 +6,3 @@ compute_tsx
.. ansibleautoplugin::
:role: roles/compute_tsx

1
doc/source/roles/role-containerized_undercloud_docker.rst

@ -4,4 +4,3 @@ containerized_undercloud_docker
.. ansibleautoplugin::
:role: roles/containerized_undercloud_docker

1
doc/source/roles/role-controller_token.rst

@ -4,4 +4,3 @@ controller_token
.. ansibleautoplugin::
:role: roles/controller_token

1
doc/source/roles/role-controller_ulimits.rst

@ -4,4 +4,3 @@ controller_ulimits
.. ansibleautoplugin::
:role: roles/controller_ulimits

1
doc/source/roles/role-ctlplane_ip_range.rst

@ -4,4 +4,3 @@ ctlplane_ip_range
.. ansibleautoplugin::
:role: roles/ctlplane_ip_range

1
doc/source/roles/role-default_node_count.rst

@ -4,4 +4,3 @@ default_node_count
.. ansibleautoplugin::
:role: roles/default_node_count

1
doc/source/roles/role-dhcp_validations.rst

@ -4,4 +4,3 @@ dhcp_validations
.. ansibleautoplugin::
:role: roles/dhcp_validations

1
doc/source/roles/role-image_serve.rst

@ -4,4 +4,3 @@ image_serve
.. ansibleautoplugin::
:role: roles/image_serve

1
doc/source/roles/role-ironic_boot_configuration.rst

@ -4,4 +4,3 @@ ironic_boot_configuration
.. ansibleautoplugin::
:role: roles/ironic_boot_configuration

1
doc/source/roles/role-mysql_open_files_limit.rst

@ -4,4 +4,3 @@ mysql_open_files_limit
.. ansibleautoplugin::
:role: roles/mysql_open_files_limit

1
doc/source/roles/role-network_environment.rst

@ -4,4 +4,3 @@ network_environment
.. ansibleautoplugin::
:role: roles/network_environment

1
doc/source/roles/role-neutron_sanity_check.rst

@ -4,4 +4,3 @@ neutron_sanity_check
.. ansibleautoplugin::
:role: roles/neutron_sanity_check

1
doc/source/roles/role-node_disks.rst

@ -4,4 +4,3 @@ node_disks
.. ansibleautoplugin::
:role: roles/node_disks

1
doc/source/roles/role-node_health.rst

@ -4,4 +4,3 @@ node_health
.. ansibleautoplugin::
:role: roles/node_health

1
doc/source/roles/role-nova_event_callback.rst

@ -46,4 +46,3 @@ Full Description
.. ansibleautoplugin::
:role: roles/nova_event_callback

1
doc/source/roles/role-nova_status.rst

@ -4,4 +4,3 @@ nova_status
.. ansibleautoplugin::
:role: roles/nova_status

1
doc/source/roles/role-openshift_on_openstack.rst

@ -4,4 +4,3 @@ openshift_on_openstack
.. ansibleautoplugin::
:role: roles/openshift_on_openstack

1
doc/source/roles/role-openstack_endpoints.rst

@ -4,4 +4,3 @@ openstack_endpoints
.. ansibleautoplugin::
:role: roles/openstack_endpoints

1
doc/source/roles/role-overcloud_service_status.rst

@ -4,4 +4,3 @@ overcloud_service_status
.. ansibleautoplugin::
:role: roles/overcloud_service_status

1
doc/source/roles/role-ovs_dpdk_pmd.rst

@ -4,4 +4,3 @@ ovs_dpdk_pmd
.. ansibleautoplugin::
:role: roles/ovs_dpdk_pmd

1
doc/source/roles/role-pacemaker_status.rst

@ -4,4 +4,3 @@ pacemaker_status
.. ansibleautoplugin::
:role: roles/pacemaker_status

1
doc/source/roles/role-rabbitmq_limits.rst

@ -4,4 +4,3 @@ rabbitmq_limits
.. ansibleautoplugin::
:role: roles/rabbitmq_limits

1
doc/source/roles/role-repos.rst

@ -4,4 +4,3 @@ repos
.. ansibleautoplugin::
:role: roles/repos

1
doc/source/roles/role-stack_health.rst

@ -4,4 +4,3 @@ stack_health
.. ansibleautoplugin::
:role: roles/stack_health

1
doc/source/roles/role-stonith_exists.rst

@ -4,4 +4,3 @@ stonith_exists
.. ansibleautoplugin::
:role: roles/stonith_exists

1
doc/source/roles/role-switch_vlans.rst

@ -4,4 +4,3 @@ switch_vlans
.. ansibleautoplugin::
:role: roles/switch_vlans

1
doc/source/roles/role-tls_everywhere.rst

@ -4,4 +4,3 @@ tls_everywhere
.. ansibleautoplugin::
:role: roles/tls_everywhere

1
doc/source/roles/role-undercloud_debug.rst

@ -4,4 +4,3 @@ undercloud_debug
.. ansibleautoplugin::
:role: roles/undercloud_debug

1
doc/source/roles/role-undercloud_disk_space.rst

@ -4,4 +4,3 @@ undercloud_disk_space
.. ansibleautoplugin::
:role: roles/undercloud_disk_space

1
doc/source/roles/role-undercloud_heat_purge_deleted.rst

@ -4,4 +4,3 @@ undercloud_heat_purge_deleted
.. ansibleautoplugin::
:role: roles/undercloud_heat_purge_deleted

1
doc/source/roles/role-undercloud_process_count.rst

@ -4,4 +4,3 @@ undercloud_process_count
.. ansibleautoplugin::
:role: roles/undercloud_process_count

1
doc/source/roles/role-undercloud_service_status.rst

@ -4,4 +4,3 @@ undercloud_service_status
.. ansibleautoplugin::
:role: roles/undercloud_service_status

2
releasenotes/notes/add-ceph-health-check-000bab9581c759d3.yaml

@ -2,4 +2,4 @@
features:
- |
Adds a ceph-health check which prints a warning message if Ceph cluster
is in HEALTH_WARN state at the end of the Overcloud deployment
is in HEALTH_WARN state at the end of the Overcloud deployment

2
tests/hosts.ini

@ -1 +1 @@
test ansible_connection=local ansible_host=localhost
test ansible_connection=local ansible_host=localhost

47
tox.ini

@ -28,7 +28,8 @@ deps =
-r {toxinidir}/requirements.txt
-r {toxinidir}/test-requirements.txt
-r {toxinidir}/molecule-requirements.txt
whitelist_externals = bash
whitelist_externals =
bash
[testenv:bindep]
# Do not install any requirements. We want this to be fast and work even if
@ -41,44 +42,6 @@ commands = bindep test
[testenv:debug]
commands = oslo_debug_helper {posargs}
[testenv:pep8]
envdir = {toxworkdir}/linters
commands =
python -m pre_commit run flake8 -a
[testenv:ansible-lint]
envdir = {toxworkdir}/linters
deps =
{[testenv:linters]deps}
commands =
bash -c "ANSIBLE_ROLES_PATH='{toxinidir}/roles'"
bash -c "ANSIBLE_LIBRARY='{toxinidir}/library'"
python -m pre_commit run ansible-lint -a
[testenv:yamllint]
envdir = {toxworkdir}/linters
deps = {[testenv:linters]deps}
commands =
python -m pre_commit run yamllint -a
[testenv:bashate]
envdir = {toxworkdir}/linters
deps = {[testenv:linters]deps}
commands =
python -m pre_commit run bashate -a
[testenv:whitespace]
envdir = {toxworkdir}/linters
deps = {[testenv:linters]deps}
commands =
python -m pre_commit run trailing-whitespace -a
[testenv:shebangs]
envdir = {toxworkdir}/linters
deps = {[testenv:linters]deps}
commands =
python -m pre_commit run check-executables-have-shebangs -a
[testenv:linters]
deps =
-r {toxinidir}/requirements.txt
@ -86,11 +49,7 @@ deps =
-r {toxinidir}/molecule-requirements.txt
commands =
python '{toxinidir}/tools/validate-files.py' .
{[testenv:ansible-lint]commands}
{[testenv:yamllint]commands}
{[testenv:bashate]commands}
{[testenv:whitespace]commands}
{[testenv:shebangs]commands}
python -m pre_commit run -a
[testenv:releasenotes]
deps = -r{toxinidir}/doc/requirements.txt

Loading…
Cancel
Save