From a1d01a941fe4c0e6259da3244e14a78d08bc3711 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Jeanneret?= Date: Thu, 25 Jul 2019 16:32:28 +0200 Subject: [PATCH] Add Molecule tests for check-network-gateway Change-Id: I3923fb89ac6e43de3e24b8c649dcfd30a72682b6 (cherry picked from commit 6dffc61d946ae220855a950dde4c9a3aee071933) --- .../molecule/default/Dockerfile.j2 | 37 ++++++++++ .../molecule/default/molecule.yml | 47 +++++++++++++ .../molecule/default/playbook.yml | 68 +++++++++++++++++++ .../molecule/default/prepare.yml | 54 +++++++++++++++ zuul.d/molecule.yaml | 9 +++ 5 files changed, 215 insertions(+) create mode 100644 roles/check-network-gateway/molecule/default/Dockerfile.j2 create mode 100644 roles/check-network-gateway/molecule/default/molecule.yml create mode 100644 roles/check-network-gateway/molecule/default/playbook.yml create mode 100644 roles/check-network-gateway/molecule/default/prepare.yml diff --git a/roles/check-network-gateway/molecule/default/Dockerfile.j2 b/roles/check-network-gateway/molecule/default/Dockerfile.j2 new file mode 100644 index 000000000..1b91a0e0b --- /dev/null +++ b/roles/check-network-gateway/molecule/default/Dockerfile.j2 @@ -0,0 +1,37 @@ +# Molecule managed +# Copyright 2019 Red Hat, Inc. +# All Rights Reserved. +# +# Licensed under the Apache License, Version 2.0 (the "License"); you may +# not use this file except in compliance with the License. You may obtain +# a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. + + +{% if item.registry is defined %} +FROM {{ item.registry.url }}/{{ item.image }} +{% else %} +FROM {{ item.image }} +{% endif %} + +RUN if [ $(command -v apt-get) ]; then apt-get update && apt-get install -y python sudo bash ca-certificates && apt-get clean; \ + elif [ $(command -v dnf) ]; then dnf makecache && dnf --assumeyes install python sudo python-devel python*-dnf bash {{ item.pkg_extras | default('') }} && dnf clean all; \ + elif [ $(command -v yum) ]; then yum makecache fast && yum install -y python sudo yum-plugin-ovl python-setuptools bash {{ item.pkg_extras | default('') }} && sed -i 's/plugins=0/plugins=1/g' /etc/yum.conf && yum clean all; \ + elif [ $(command -v zypper) ]; then zypper refresh && zypper install -y python sudo bash python-xml {{ item.pkg_extras | default('') }} && zypper clean -a; \ + elif [ $(command -v apk) ]; then apk update && apk add --no-cache python sudo bash ca-certificates {{ item.pkg_extras | default('') }}; \ + elif [ $(command -v xbps-install) ]; then xbps-install -Syu && xbps-install -y python sudo bash ca-certificates {{ item.pkg_extras | default('') }} && xbps-remove -O; fi + +{% for pkg in item.easy_install | default([]) %} +# install pip for centos where there is no python-pip rpm in default repos +RUN easy_install {{ pkg }} +{% endfor %} + + +CMD ["sh", "-c", "while true; do sleep 10000; done"] diff --git a/roles/check-network-gateway/molecule/default/molecule.yml b/roles/check-network-gateway/molecule/default/molecule.yml new file mode 100644 index 000000000..603587918 --- /dev/null +++ b/roles/check-network-gateway/molecule/default/molecule.yml @@ -0,0 +1,47 @@ +--- +driver: + name: docker + +log: true + +platforms: + - name: centos7 + hostname: centos7 + image: centos:7 + pkg_extras: python-setuptools python-enum34 python-netaddr epel-release ruby + easy_install: + - pip + environment: &env + http_proxy: "{{ lookup('env', 'http_proxy') }}" + https_proxy: "{{ lookup('env', 'https_proxy') }}" + + - name: fedora28 + hostname: fedora28 + image: fedora:28 + pkg_extras: python*-setuptools python*-enum python*-netaddr ruby iputils + environment: + <<: *env + +provisioner: + name: ansible + log: true + env: + ANSIBLE_STDOUT_CALLBACK: yaml + ANSIBLE_LIBRARY: "../../../../library" + +scenario: + test_sequence: + - destroy + - create + - prepare + - converge + - verify + - destroy + +lint: + enabled: false + +verifier: + name: testinfra + lint: + name: flake8 diff --git a/roles/check-network-gateway/molecule/default/playbook.yml b/roles/check-network-gateway/molecule/default/playbook.yml new file mode 100644 index 000000000..e017708aa --- /dev/null +++ b/roles/check-network-gateway/molecule/default/playbook.yml @@ -0,0 +1,68 @@ +--- +# Copyright 2019 Red Hat, Inc. +# All Rights Reserved. +# +# Licensed under the Apache License, Version 2.0 (the "License"); you may +# not use this file except in compliance with the License. You may obtain +# a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. + + +- name: Converge + hosts: all + gather_facts: no + + tasks: + - name: successful check with ctlplane-subnet + include_role: + name: check-network-gateway + + - name: override undercloud.conf + copy: + dest: /undercloud.conf + content: | + [DEFAULT] + local_subnet = 192.168.254.0/24 + [192.168.254.0/24] + gateway = 8.8.8.8 + + - name: successful check with local_ip + include_role: + name: check-network-gateway + + - name: fail the validation + block: + - name: override undercloud.conf + copy: + dest: /undercloud.conf + content: | + [ctlplane-subnet] + gateway = 192.168.254.254 + + - name: run the validation + include_role: + name: check-network-gateway + + rescue: + - name: Clear host error + meta: clear_host_errors + + - name: Validation output + debug: + msg: The validation works! End the playbook run + + - name: End play + meta: end_play + + - name: Fail the test + fail: + msg: | + The check-network-gateway validation didn't properly detect faulty + gateway! diff --git a/roles/check-network-gateway/molecule/default/prepare.yml b/roles/check-network-gateway/molecule/default/prepare.yml new file mode 100644 index 000000000..ab488467a --- /dev/null +++ b/roles/check-network-gateway/molecule/default/prepare.yml @@ -0,0 +1,54 @@ +--- +# Copyright 2019 Red Hat, Inc. +# All Rights Reserved. +# +# Licensed under the Apache License, Version 2.0 (the "License"); you may +# not use this file except in compliance with the License. You may obtain +# a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. + + +- name: Prepare + hosts: all + gather_facts: no + + tasks: + - name: install hiera + package: + name: hiera + + - name: create hiera tree + file: + path: /etc/puppet + state: directory + + - name: populate hiera.yaml + copy: + dest: /etc/puppet/hiera.yaml + content: | + :backends: + - yaml + :yaml: + :datadir: "/etc/puppet/" + :hierarchy: + - "common" + + - name: populate hiera content + copy: + dest: /etc/puppet/common.yaml + content: | + tripleo_undercloud_conf_file: /undercloud.conf + + - name: populate undercloud.conf + copy: + dest: /undercloud.conf + content: | + [ctlplane-subnet] + gateway = 8.8.8.8 diff --git a/zuul.d/molecule.yaml b/zuul.d/molecule.yaml index d7adcbe0a..0a822535b 100644 --- a/zuul.d/molecule.yaml +++ b/zuul.d/molecule.yaml @@ -17,6 +17,7 @@ - tripleo-validations-centos-7-molecule-no-op-firewall-nova-driver - tripleo-validations-centos-7-molecule-nova-status - tripleo-validations-centos-7-molecule-image-serve + - tripleo-validations-centos-7-molecule-check-network-gateway gate: queue: integrated jobs: @@ -34,6 +35,7 @@ - tripleo-validations-centos-7-molecule-no-op-firewall-nova-driver - tripleo-validations-centos-7-molecule-nova-status - tripleo-validations-centos-7-molecule-image-serve + - tripleo-validations-centos-7-molecule-check-network-gateway name: tripleo-validations-molecule-jobs - job: files: @@ -134,3 +136,10 @@ parent: tripleo-validations-centos-7-base vars: tripleo_validations_role_name: image-serve +- job: + files: + - ^roles/check-network-gateway/.* + name: tripleo-validations-centos-7-molecule-check-network-gateway + parent: tripleo-validations-centos-7-base + vars: + tripleo_validations_role_name: check-network-gateway