From d5b5458e46c38fedbf8c30835dc1a6e36c9f5434 Mon Sep 17 00:00:00 2001 From: Jiri Podivin Date: Wed, 20 Jul 2022 11:53:45 +0200 Subject: [PATCH] Removing undercloud-heat-purge-deleted from validation groups The validation relies on dependencies unmet in Wallaby and later releases, it's inclusion in the dedicated TripleO groups is thus no longer needed or beneficial. Notes regarding the change were added to docs. resolves: rhbz#2105291 Signed-off-by: Jiri Podivin Change-Id: If887c798f6c18278204ba7b11f01fc2f2450bb76 --- doc/source/roles/role-undercloud_heat_purge_deleted.rst | 4 ++++ playbooks/undercloud-heat-purge-deleted.yaml | 8 ++++---- roles/undercloud_heat_purge_deleted/vars/main.yaml | 7 ++++--- 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/doc/source/roles/role-undercloud_heat_purge_deleted.rst b/doc/source/roles/role-undercloud_heat_purge_deleted.rst index 81f36d59b..cc6a6f6a4 100644 --- a/doc/source/roles/role-undercloud_heat_purge_deleted.rst +++ b/doc/source/roles/role-undercloud_heat_purge_deleted.rst @@ -2,6 +2,10 @@ undercloud_heat_purge_deleted ============================= +.. warning:: + This role is not suited for Wallaby and more recent releases. + As it expects presence 'heat_api_cron'. + An Ansible role to check if `heat-manage purge_deleted` is enabled in the crontab diff --git a/playbooks/undercloud-heat-purge-deleted.yaml b/playbooks/undercloud-heat-purge-deleted.yaml index 4bb2cd8fc..03217e643 100644 --- a/playbooks/undercloud-heat-purge-deleted.yaml +++ b/playbooks/undercloud-heat-purge-deleted.yaml @@ -7,10 +7,10 @@ Without a purge_deleted crontab enabled, the heat database can grow very large. This validation checks that the purge_deleted crontab has been set up. - groups: - - pre-upgrade - - pre-update - - pre-deployment + This validation should only be used on systems using 'heat_api_cron'. + Starting from Wallaby, the 'heat_api_cron' is no longer installed by + default, and the role may behave upredictably. + groups: [] categories: - orchestration - os diff --git a/roles/undercloud_heat_purge_deleted/vars/main.yaml b/roles/undercloud_heat_purge_deleted/vars/main.yaml index 558c3b0c2..8beb1e030 100644 --- a/roles/undercloud_heat_purge_deleted/vars/main.yaml +++ b/roles/undercloud_heat_purge_deleted/vars/main.yaml @@ -5,6 +5,7 @@ metadata: Without a purge_deleted crontab enabled, the heat database can grow very large. This validation checks that the purge_deleted crontab has been set up. - groups: - - pre-upgrade - - pre-deployment + This role should only be used on systems using 'heat_api_cron'. + Starting from Wallaby, the 'heat_api_cron' is no longer installed by + default, and the role may behave upredictably. + groups: []