Browse Source

Merge "Basic tests for check_flavors module"

changes/19/794719/1
Zuul 5 months ago
committed by Gerrit Code Review
parent
commit
e7ff743f39
  1. 66
      tripleo_validations/tests/fakes.py
  2. 67
      tripleo_validations/tests/library/test_check_flavors.py

66
tripleo_validations/tests/fakes.py

@ -33,3 +33,69 @@ MOCK_CPUS_RET_VALUE = (
{'numa_node': 1, 'thread_siblings': [5, 7], 'cpu': 5},
{'numa_node': 1, 'thread_siblings': [9, 11], 'cpu': 9}
])
MOCK_ROLES_INFO = [
{
'name': 'foo',
'flavor': 'bar',
'count': 9999}]
MOCK_FLAVORS = {
'ok': {
'bar': {
'keys': {
'resources:fizz': 'fizz',
'resources:buzz': 'buzz',
'resources:DISK_GB': 1,
'MEMORY_MB': 10,
'VCPU': 100
}
}
},
'fail_NOVCPU': {
'bar': {
'keys': {
'resources:fizz': 'fizz',
'resources:buzz': 'buzz',
'resources:DISK_GB': 1,
'MEMORY_MB': 10
}
}
}
}
MOCK_FLAVORS_CHECK_EXPECTED = {
'ok': (
{'bar': (
({'keys': {
'resources:fizz': 'fizz',
'resources:buzz': 'buzz',
'resources:DISK_GB': 1,
'MEMORY_MB': 10,
'VCPU': 100
}},
9999)
)},
[],
[
'Flavor bar does not have a custom resource class associated with it',
'Flavor bar has to have scheduling based on standard properties disabled by setting resources:VCPU=0 resources:MEMORY_MB=0 resources:DISK_GB=0 in the flavor property'
]
),
'fail_NOVCPU': (
{'bar': (
({'keys': {
'resources:fizz': 'fizz',
'resources:buzz': 'buzz',
'resources:DISK_GB': 1,
'MEMORY_MB': 10,
}},
9999)
)},
[],
[
'Flavor bar does not have a custom resource class associated with it',
'Flavor bar has to have scheduling based on standard properties disabled by setting resources:VCPU=0 resources:MEMORY_MB=0 resources:DISK_GB=0 in the flavor property'
]
)
}

67
tripleo_validations/tests/library/test_check_flavors.py

@ -0,0 +1,67 @@
# -*- coding: utf-8 -*-
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
"""
test_check_flavors
--------------
Tests for the `check_flavors` module.
"""
try:
from unittest import mock
except ImportError:
import mock
from tripleo_validations.tests import base
from tripleo_validations.tests import fakes
from library import check_flavors
class TestCheckFlavors(base.TestCase):
def setUp(self):
self.tested_module = check_flavors
return super().setUp()
def test_module_init(self):
expepect_attrs = set(
[
'DOCUMENTATION',
'EXAMPLES',
'main'])
actual_attrs = set(dir(self.tested_module))
self.assertTrue(expepect_attrs.issubset(actual_attrs))
def test_validate_roles_and_flavors(self):
expected_values = fakes.MOCK_FLAVORS_CHECK_EXPECTED['ok']
return_value = self.tested_module.validate_roles_and_flavors(
fakes.MOCK_ROLES_INFO,
fakes.MOCK_FLAVORS['ok'])
self.assertEqual(expected_values, return_value)
def test_validate_roles_and_flavors_nocpu(self):
"""Tests situation when the 'VCPU' key doesn't have associated value.
'DISK_GB' and 'MEMORY_MB' behave the same way,
so we don't need to test them. For now at least.
"""
expected_values = fakes.MOCK_FLAVORS_CHECK_EXPECTED['fail_NOVCPU']
return_value = self.tested_module.validate_roles_and_flavors(
fakes.MOCK_ROLES_INFO,
fakes.MOCK_FLAVORS['fail_NOVCPU'])
self.assertEqual(expected_values, return_value)
Loading…
Cancel
Save