openstack
/
tripleo-validations
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(3 comments)

Patch-set: 5
CC: Gerrit User 27427 <27427@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 27427 2023-11-20 11:49:57 +00:00 committed by Gerrit Code Review
parent 22a0cd576b
commit f25f250071
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
eb00c0fc9db34e0c0406c5237260c6d3819e4709 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "ebeb9d8e_932ace73",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 27427
},
"writtenOn": "2023-11-20T11:49:57Z",
"side": 1,
"message": "Thanks for this Jiri. The changes look good to me, minus minor comments on the two files that I believe were edited perhaps in error.\n\nPlease check that, then we should be good to go. :-)",
"revId": "eb00c0fc9db34e0c0406c5237260c6d3819e4709",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c88e897c_a7ba8305",
"filename": "roles/overcloud_service_status/resources/playbooks/prepare.yml",
"patchSetId": 5
},
"lineNbr": 6,
"author": {
"id": 27427
},
"writtenOn": "2023-11-20T11:49:57Z",
"side": 1,
"message": "This looks like indentation only, is this correct, and expected? Or just you changed editor configuration?",
"revId": "eb00c0fc9db34e0c0406c5237260c6d3819e4709",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "77ca828f_a7eaed27",
"filename": "roles/validation_init/files/_skeleton_role_/molecule/default/verify.yml",
"patchSetId": 5
},
"lineNbr": 21,
"author": {
"id": 27427
},
"writtenOn": "2023-11-20T11:49:57Z",
"side": 1,
"message": "Indent only, as per other comment.",
"revId": "eb00c0fc9db34e0c0406c5237260c6d3819e4709",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}