When running pre-upgrade, it triggers a failed validation during FFU
Because undercloud is 16.2 and the overcloud is still running on 13.
Change-Id: Ia3d9ea6c3a69392975046518d5728496a3bec998
(cherry picked from commit 1271bb838c)
Make sure before update we do not have any dangling images.
Basically - make sure the command:
$ podman images --filter "dangling=true" -q --no-trunc
returns empty.
Co-authored-by: Daniel Bengtsson <dbengt@redhat.com>
Change-Id: I70acd9cef9e84d2c68b7bd3d82dcbd0f99c79fb9
(cherry picked from commit a1295519a1)
One of the issues identified in the FFU testing was that the
configured DockerInsecureRegistryAddress parameter was not pointing at
the right UC hostname.
Causing issues when retrieving the containers.
This validation retrieve the value for DockerInsecureRegistryAddress
configured in containers-prepare-parameter.yaml file and matches it to
the UC hostname configured in the undercloud.conf.
Co-Authored-By: Daniel Bengtsson <dbengt@redhat.com>
Co-Authored-By: Gaël Chamoulaud <gchamoul@redhat.com>
Change-Id: Iab2e8823996d305d6d8807bb93f4d2f6e1c96906
(cherry picked from commit 2a875fd240)
This patch adds the `groups.yaml` to the list of files which triggers
the documentation build.
This patch also adds some words in the documentation in order to notify
the user that he/she/it will have to add a new entry in the doc
index.rst file when adding a new validations group.
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
Change-Id: Ib4a92f98821bcecd4e2f84ee0b6d3445152ee8ce
This will aloow openstack tripleo-validator run subcommand to override them
and they will be displayed in the show subcommand.
Change-Id: I6901792427ce3045841a31f8cc230c2f909a848f
It was erroneous to use the admin endpoint as it's not accessible from
the undercloud anymore.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1921114
Change-Id: I2cf2280e4a4599f60c0cce550358f9cf3a20f802
Via [1] we cannot rely on ansible_* vars anymore. So let's switch to
ansible_facts. This should fix the following error:
2021-04-22 22:08:36,708 p=36100 u=mistral n=ansible | fatal:
[undercloud]: FAILED! => {"msg": "The task includes an option with an
undefined variable. The error was: {{ tls_everywhere_undercloud_fqdn |
default(ansible_fqdn) }}: 'ansible_fqdn' is undefined\n\nThe error
appears to be in
'/usr/share/ansible/roles/tls_everywhere/tasks/ipa-server-check.yaml':
line 59, column 7, but may\nbe elsewhere in the file depending on the
exact syntax problem.\n\nThe offending line appears to be:\n\n\n -
name: kinit as the host entity\n ^ here\n"}
Closes-Bug: #1925999
[1] 4e79336d69
Change-Id: If23c41d343678dcbbd0b4aae10ca6281a33e385f
There's no reason to forbid --list and --static-yaml-inventory
Also, we should return an error if both --list and --host are
defined.
Change-Id: I94393de4a71a92c12f8d427748853d7ff2ce5a02
Tests now include check of run function and
required module attributes.
Closes-Bug: #1922726
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: Id21cd63fff6e8cd2f0aad452ad8f1a5d8ce87930
Patch prepares ground for further work on tripleo_validations
unit tests.
Datastructures used for testing were factored out.
__init__.py files for lookup plugins and library tests were added.
Together with minimal docstring.
.gitingore was updated to ignore stestr files.
test-requirements.txt and requirements.txt were updated to include
all necessary dependencies
Depends-On: https://review.rdoproject.org/r/c/openstack/tripleo-validations-distgit/+/32545
Closes-Bug: #1922726
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: If67992bec97831cc45b46e33af234a9444c5ae4c
Exceptions were too general, potentially swallowing
unexpected issues and hiding them from the view of maintainers.
All of the problematic except blocks were refactored
to only consider exceptions directly related to their try blocks.
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: I48b237d1a8f3bab3b0817db5edb9aade0a941e42
The --branches arg of the initial coverage binary call
was unnecessary, due to presence of the relevant setting in
the .coveragerc settings file.
Therefore it was removed.
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: I59600d3b68febc1de195640aacfe2bcf50012069
* using multinode jobs for validations is too heavy
and uses too much resources
* remove standalone004 - worthless sans rpm build
* add a validations job that targets validations
Change-Id: Ifef837dc884c7338f9396214e36a197cdbb060c6
Python 3.6 is the oldest version of python
supported by the package, and newer, supported,
minor versions do not break any substantial functionality
by design, while introducing new features.
Therefore we do not need to run unit tests for
each minor version. As all possible issues affecting
versions >3.6 would necessarily be related to features
introduced in versions >3.6.
Wallaby Zuul test template was removed from layout.yaml.
The pep8 test environment was folded into linters in tox.ini.
Zuul is now explicitly running tests only in one, oldest supported,
python environment, Python 3.6.
PEP387: https://www.python.org/dev/peps/pep-0387/https://docs.python.org/3/whatsnew/3.7.html#porting-to-python-37https://docs.python.org/3/whatsnew/3.8.html#porting-to-python-3-8
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: If8e31e72b215dcdb0db897b03403e8d28a2545b3
This should have been in the initial patch, arguably.
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: I765218b61f761ce1df387abea33e35f2c96a1ec6
This brings coverage measuring in line with
the standard tox testing process.
Closes-bug: #1922726
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: I6bf27ffe88ff55b62e202678340a324058d30051
As this rule has been merged upstream, we don't need it anymore locally.
This patch also bumps the ansible-lint release from v4.3.5 to v5.0.3
It also mocks the following modules and roles coming from
validations-common to pass the --syntax-check:
- hiera, validations_read_ini and warn customs libs
- check_latest_packages_version role
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
Change-Id: Idc560dd4c459228da43a1e7b3dc089d379b9dccb
This patch adds a new TripleO specific playbook which will call the
check_latest_packages_version role hosted in validations-common. This
playbook will test if the python3-tripleoclient package is at its latest
version on the Undercloud before starting an upgrade.
Note1: The check-latest-packages-versions validation hosted in
validations-common will be refactored to only test non TripleO packages.
Note2: The documentation automation has been modified to point to the
external role official documentation.
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: I606f650029dd4daad7dc7aac248c388130e9d503
This patch adds basic configuration for tox-ansible[1].
Tox-ansible is a plugin for tox which auto-generates tox environments
for running quality assurance tools like ansible-test or molecule. This
tool is rather tightly integrated for the official Molecule testing tool
that integrates with Ansible.
At first, it will allow us to list very quickly all the Ansible Molecule
tests for each roles with their scenario(s):
Example:
$ tox -l
...
roles-ceph-ceph-ansible-installed
roles-ceph-default
roles-check_kernel_version-default
roles-check_network_gateway-default
roles-check_rhsm_version-default
roles-check_rhsm_version-rhsm_mismatch
roles-check_undercloud_conf-config_OK
roles-check_undercloud_conf-default
roles-check_undercloud_conf-deprecated_drivers
roles-check_undercloud_conf-deprecated_params
roles-check_undercloud_conf-required_missing
...
However, we won't be able to execute them as it for now without to make
some small manual modifications in the molecule.yml file first before to
execute them. This will be covered as soon as possible in a following-patch.
[1] - https://github.com/ansible-community/tox-ansible
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
Change-Id: Ia1606db814f37a11e48508139b90cdd43c083f6b
David Vallee Delisle