From 389b464bf87128e38fe76310e26d7a5823a5eaa5 Mon Sep 17 00:00:00 2001 From: Amrith Kumar Date: Wed, 22 Jun 2016 13:27:41 -0400 Subject: [PATCH] Document house rules for approving changes Document house rules for approving changes and a relaxation that we will adopt for the newton release cycle. Change-Id: Icc9b62740bcf5a604c492b5e36a970c93b7e8fc9 --- CONTRIBUTING.rst | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index 66791a5b7b..14b7b7bdf1 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -87,6 +87,34 @@ Other references: - http://docs.openstack.org/developer/hacking/ - https://review.openstack.org/#/c/116176/ +Approving changes +================= + +The Trove project follows the conventions below in approving changes. + +1. In general, two core reviewers must +2 a change before it can be + approved. In practice this means that coreA can +2 the change, then + coreB can +2/+A the change and it can be merged. + +2. coreA and coreB should belong to different organizations. + +3. For requirements changes proposed by the Proposal Bot or + translations proposed by Zanata, a single core reviewer can review + and approve the change. + +NOTE: + +For the remainder of the Newton release cycle, we will relax the above +conventions. These relaxations apply to the master branch only. + +We will adopt a practice of lazy consensus for approving all changes +and a single core reviewer can review and approve a change. This could +be done, for example, by allowing all reviewers know that he or she +intends to approve some change or set of changes if there are no +additional negative comments by a certain time definite. + +We will however still require that at least one other person review +(and +1 or +2) the change before it can be +A'ed. Trove Documentation ===================