openstack
/
trove
Code Issues Proposed changes

Replace assertEqual(None, *) with assertIsNone in tests 

Replace assertEqual(None, *) with assertIsNone in tests to have
more clear messages in case of failure.

Change-Id: I40c4d43673d5643a4e4cd50fd6abe21559222749
Closes-bug: #1280522
This commit is contained in:
Shuquan Huang 2015-12-17 22:12:10 +08:00
parent 55e6457c4e
commit 5e5cc3260f
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
trove/tests/unittests/secgroups/test_security_group.py
View File

@ -133,9 +133,9 @@ class SecurityGroupDeleteTest(trove_testtools.TestCase):
def test_failed_to_get_assoc_on_delete(self):
sec_mod.SecurityGroupInstanceAssociation.find_by = self.fException
self.assertEqual(None,
sec_mod.SecurityGroup.delete_for_instance(
uuid.uuid4(), self.context))
self.assertIsNone(
sec_mod.SecurityGroup.delete_for_instance(
uuid.uuid4(), self.context))
def test_get_security_group_from_assoc_with_db_exception(self):
@ -154,9 +154,9 @@ class SecurityGroupDeleteTest(trove_testtools.TestCase):
sec_mod.SecurityGroupInstanceAssociation.find_by = Mock(
return_value=new_fake_RemoteSecGrAssoc())
self.assertEqual(None,
sec_mod.SecurityGroup.delete_for_instance(
i_id, self.context))
self.assertIsNone(
sec_mod.SecurityGroup.delete_for_instance(
i_id, self.context))
def test_delete_secgr_assoc_with_db_exception(self):
@ -169,6 +169,6 @@ class SecurityGroupDeleteTest(trove_testtools.TestCase):
self.assertTrue(hasattr(sec_mod.SecurityGroupInstanceAssociation.
find_by(i_id, deleted=False).
get_security_group(), 'delete'))
self.assertEqual(None,
sec_mod.SecurityGroup.delete_for_instance(
i_id, self.context))
self.assertIsNone(
sec_mod.SecurityGroup.delete_for_instance(
i_id, self.context))