From 970d23ff2ae5449786e95b482dff344d4a48b323 Mon Sep 17 00:00:00 2001 From: Peter Stachowski Date: Mon, 9 May 2016 20:32:31 +0000 Subject: [PATCH] Unsupported module driver not logged correctly If an invalid module driver is found, the method is erroneously printed out instead of the actual 'type.' This is due to missing parenthesis in the logging call. This has been fixed. Change-Id: I6fb23b3dbbec98de9ee1e2731bcfc56ab3c0ca42 Closes-Bug: #1579900 --- .../notes/fix_module_driver_logging-666601f411db784a.yaml | 4 ++++ trove/guestagent/module/driver_manager.py | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/fix_module_driver_logging-666601f411db784a.yaml diff --git a/releasenotes/notes/fix_module_driver_logging-666601f411db784a.yaml b/releasenotes/notes/fix_module_driver_logging-666601f411db784a.yaml new file mode 100644 index 0000000000..2d18ea49d1 --- /dev/null +++ b/releasenotes/notes/fix_module_driver_logging-666601f411db784a.yaml @@ -0,0 +1,4 @@ +--- +fixes: + - An invalid module driver is now logged correctly. + Bug 1579900 diff --git a/trove/guestagent/module/driver_manager.py b/trove/guestagent/module/driver_manager.py index a25dfbfa29..a9258793c0 100644 --- a/trove/guestagent/module/driver_manager.py +++ b/trove/guestagent/module/driver_manager.py @@ -69,7 +69,7 @@ class ModuleDriverManager(object): supported = True else: LOG.info(_("Driver '%s' not supported, skipping"), - driver.get_type) + driver.get_type()) except AttributeError as ex: LOG.exception(_("Exception loading module driver: %s"), encodeutils.exception_to_unicode(ex))