openstack/trove
Code Issues Proposed changes

Change assertTrue(isinstance()) by optimal assert

Browse Source 
Some of tests use different method of assertTrue(isinstance(A, B))
The correct way is to use assertIsInstance(A,B) provided by testtools

Closes-bug: #1268480

Change-Id: Ic52071ac03aeb7f9d5baa59208778ed75237f196
This commit is contained in:
yangyapeng
2016-01-04 17:24:24 -05:00
parent b5c83633ec
commit e2bddfcf93
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
trove/tests/unittests/cluster/test_cluster_models.py
View File

@@ -35,4 +35,4 @@ class TestClusterModel(trove_testtools.TestCase):
dsv.manager = 'mongodb'
mock_load_dsv_by_uuid.return_value = dsv
cluster = models.Cluster.load(context, id)
self.assertTrue(isinstance(cluster, MongoDbCluster))
self.assertIsInstance(cluster, MongoDbCluster)

2
trove/tests/unittests/cluster/test_cluster_views.py
View File

@@ -73,7 +73,7 @@ class ClusterViewTest(trove_testtools.TestCase):
cluster = Mock()
cluster.datastore_version.manager = 'mongodb'
view = load_view(cluster, Mock())
self.assertTrue(isinstance(view, MongoDbClusterView))
self.assertIsInstance(view, MongoDbClusterView)
def test__build_instances(self, *args):
cluster = Mock()

6
trove/tests/unittests/taskmanager/test_api.py
View File

@@ -111,6 +111,6 @@ class TestAPI(trove_testtools.TestCase):
context = Mock()
manager = 'mongodb'
self.assertTrue(isinstance(task_api.load(context), task_api.API))
self.assertTrue(isinstance(task_api.load(context, manager),
MongoDbTaskManagerAPI))
self.assertIsInstance(task_api.load(context), task_api.API)
self.assertIsInstance(task_api.load(context, manager),
MongoDbTaskManagerAPI)