Peter Stachowski
187725fafb
In order to allow replication sets to be all on the same hypervisor (affinity) or all on different hypervisors (anti-affinity) a new argument (locality) needed to be added to the Trove create API. This changeset addresses the Trove server part of this feature. 'locality' can now be added to the ReST payload for a create command and it is passed along as a scheduler hint to Nova. The replication scenario tests were enhanced to test that 'affinity' works and 'anti-affinity' fails (since devstack sets up a single hypervisor by default). A check for the existance (and lack of) server-groups was added. This is to ensure that not only is the server-group created properly, but also that it has been deleted after all the related instances are gone. DocImpact: New functionality Partially implements: blueprint replication-cluster-locality Depends-On: I18f242983775526a7f1e2644302ebdc0dac025cf Change-Id: I7d924c25d832f9ff4386e9497bfd214f1b2b3503
112 lines
4.7 KiB
Python
112 lines
4.7 KiB
Python
# Copyright 2016 Tesora, Inc.
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
|
|
import copy
|
|
from mock import Mock, patch
|
|
|
|
from trove.common import server_group as srv_grp
|
|
from trove.tests.unittests import trove_testtools
|
|
|
|
|
|
class TestServerGroup(trove_testtools.TestCase):
|
|
|
|
def setUp(self):
|
|
super(TestServerGroup, self).setUp()
|
|
self.ServerGroup = srv_grp.ServerGroup()
|
|
self.context = trove_testtools.TroveTestContext(self)
|
|
self.sg_id = 'sg-1234'
|
|
self.locality = 'affinity'
|
|
self.expected_hints = {'group': self.sg_id}
|
|
self.server_group = Mock()
|
|
self.server_group.id = self.sg_id
|
|
self.server_group.policies = [self.locality]
|
|
self.server_group.members = ['id-1', 'id-2']
|
|
self.empty_server_group = copy.copy(self.server_group)
|
|
self.empty_server_group.members = ['id-1']
|
|
|
|
@patch.object(srv_grp, 'create_nova_client')
|
|
def test_create(self, mock_client):
|
|
mock_create = Mock(return_value=self.server_group)
|
|
mock_client.return_value.server_groups.create = mock_create
|
|
server_group = self.ServerGroup.create(
|
|
self.context, self.locality, "name_suffix")
|
|
mock_create.assert_called_with(name="locality_name_suffix",
|
|
policies=[self.locality])
|
|
self.assertEqual(self.server_group, server_group)
|
|
|
|
@patch.object(srv_grp, 'create_nova_client')
|
|
def test_delete(self, mock_client):
|
|
mock_delete = Mock()
|
|
mock_client.return_value.server_groups.delete = mock_delete
|
|
self.ServerGroup.delete(self.context, self.empty_server_group)
|
|
mock_delete.assert_called_with(self.sg_id)
|
|
|
|
@patch.object(srv_grp, 'create_nova_client')
|
|
def test_delete_non_empty(self, mock_client):
|
|
mock_delete = Mock()
|
|
mock_client.return_value.server_groups.delete = mock_delete
|
|
srv_grp.ServerGroup.delete(self.context, self.server_group)
|
|
mock_delete.assert_not_called()
|
|
|
|
@patch.object(srv_grp, 'create_nova_client')
|
|
def test_delete_force(self, mock_client):
|
|
mock_delete = Mock()
|
|
mock_client.return_value.server_groups.delete = mock_delete
|
|
self.ServerGroup.delete(self.context, self.server_group, force=True)
|
|
mock_delete.assert_called_with(self.sg_id)
|
|
|
|
def test_convert_to_hint(self):
|
|
hint = srv_grp.ServerGroup.convert_to_hint(self.server_group)
|
|
self.assertEqual(self.expected_hints, hint, "Unexpected hint")
|
|
|
|
def test_convert_to_hints(self):
|
|
hints = {'hint': 'myhint'}
|
|
hints = srv_grp.ServerGroup.convert_to_hint(self.server_group, hints)
|
|
self.expected_hints.update(hints)
|
|
self.assertEqual(self.expected_hints, hints, "Unexpected hints")
|
|
|
|
def test_convert_to_hint_none(self):
|
|
self.assertIsNone(srv_grp.ServerGroup.convert_to_hint(None))
|
|
|
|
@patch.object(srv_grp, 'create_nova_client')
|
|
def test_build_scheduler_hint(self, mock_client):
|
|
mock_create = Mock(return_value=self.server_group)
|
|
mock_client.return_value.server_groups.create = mock_create
|
|
expected_hint = {'get_back': 'same_dict'}
|
|
scheduler_hint = self.ServerGroup.build_scheduler_hint(
|
|
self.context, expected_hint, "name_suffix")
|
|
self.assertEqual(expected_hint, scheduler_hint, "Unexpected hint")
|
|
|
|
@patch.object(srv_grp, 'create_nova_client')
|
|
def test_build_scheduler_hint_from_locality(self, mock_client):
|
|
mock_create = Mock(return_value=self.server_group)
|
|
mock_client.return_value.server_groups.create = mock_create
|
|
expected_hint = {'group': 'sg-1234'}
|
|
scheduler_hint = self.ServerGroup.build_scheduler_hint(
|
|
self.context, self.locality, "name_suffix")
|
|
self.assertEqual(expected_hint, scheduler_hint, "Unexpected hint")
|
|
|
|
def test_build_scheduler_hint_none(self):
|
|
self.assertIsNone(srv_grp.ServerGroup.build_scheduler_hint(
|
|
self.context, None, None))
|
|
|
|
def test_get_locality(self):
|
|
locality = srv_grp.ServerGroup.get_locality(self.server_group)
|
|
self.assertEqual(self.locality, locality, "Unexpected locality")
|
|
|
|
def test_get_locality_none(self):
|
|
self.assertIsNone(srv_grp.ServerGroup.get_locality(None))
|