From 6b1167798717faeac2e91cc5ad9cdc87b3924acd Mon Sep 17 00:00:00 2001
From: Jiri Podivin <jpodivin@redhat.com>
Date: Wed, 17 Feb 2021 11:40:56 +0100
Subject: [PATCH] Validations now gather only the subset of facts they need

The default facts gathering is set to false.

Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: I2ac937df59f91b566029b0260e804d2972362f97
---
 validations_common/playbooks/check-cpu.yaml           |  2 +-
 .../playbooks/check-latest-packages-version.yaml      |  2 +-
 validations_common/playbooks/check-ram.yaml           |  2 +-
 validations_common/playbooks/check-selinux-mode.yaml  |  2 +-
 validations_common/roles/check_cpu/tasks/main.yml     |  7 +++++++
 .../check_latest_packages_version/tasks/main.yml      | 11 +++++++++++
 validations_common/roles/check_ram/tasks/main.yml     |  7 +++++++
 7 files changed, 29 insertions(+), 4 deletions(-)

diff --git a/validations_common/playbooks/check-cpu.yaml b/validations_common/playbooks/check-cpu.yaml
index ea2d40f..29266a5 100644
--- a/validations_common/playbooks/check-cpu.yaml
+++ b/validations_common/playbooks/check-cpu.yaml
@@ -1,6 +1,6 @@
 ---
 - hosts: all
-  gather_facts: true
+  gather_facts: false
   vars:
     metadata:
       name: Verify if the server fits the CPU core requirements
diff --git a/validations_common/playbooks/check-latest-packages-version.yaml b/validations_common/playbooks/check-latest-packages-version.yaml
index c6f80f9..a9eab1b 100644
--- a/validations_common/playbooks/check-latest-packages-version.yaml
+++ b/validations_common/playbooks/check-latest-packages-version.yaml
@@ -1,6 +1,6 @@
 ---
 - hosts: localhost
-  gather_facts: true
+  gather_facts: false
   vars:
     metadata:
       name: Check if latest version of packages is installed
diff --git a/validations_common/playbooks/check-ram.yaml b/validations_common/playbooks/check-ram.yaml
index fe32cdd..47fe69d 100644
--- a/validations_common/playbooks/check-ram.yaml
+++ b/validations_common/playbooks/check-ram.yaml
@@ -1,6 +1,6 @@
 ---
 - hosts: all
-  gather_facts: true
+  gather_facts: false
   vars:
     metadata:
       name: Verify the server fits the RAM requirements
diff --git a/validations_common/playbooks/check-selinux-mode.yaml b/validations_common/playbooks/check-selinux-mode.yaml
index 0bfcda4..4d719e8 100644
--- a/validations_common/playbooks/check-selinux-mode.yaml
+++ b/validations_common/playbooks/check-selinux-mode.yaml
@@ -1,6 +1,6 @@
 ---
 - hosts: all
-  gather_facts: true
+  gather_facts: false
   vars:
     metadata:
       name: SELinux Enforcing Mode Check
diff --git a/validations_common/roles/check_cpu/tasks/main.yml b/validations_common/roles/check_cpu/tasks/main.yml
index f10defc..acfa0de 100644
--- a/validations_common/roles/check_cpu/tasks/main.yml
+++ b/validations_common/roles/check_cpu/tasks/main.yml
@@ -1,4 +1,11 @@
 ---
+- name: Gather facts
+  setup:
+    gather_subset:
+      - processor_count
+      - '!all'
+      - '!min'
+
 - name: Verify the number of CPU cores
   fail:
     msg: >-
diff --git a/validations_common/roles/check_latest_packages_version/tasks/main.yml b/validations_common/roles/check_latest_packages_version/tasks/main.yml
index dd782ea..6fa5965 100644
--- a/validations_common/roles/check_latest_packages_version/tasks/main.yml
+++ b/validations_common/roles/check_latest_packages_version/tasks/main.yml
@@ -1,4 +1,15 @@
 ---
+- name: Gather facts
+  setup:
+    gather_subset:
+      - '!all'
+      - '!min'
+      - pkg_mgr
+
+- name: Gather package facts
+  package_facts:
+    manager: auto
+
 - name: Get available updates for packages
   check_package_update:
     package: "{{ item }}"
diff --git a/validations_common/roles/check_ram/tasks/main.yml b/validations_common/roles/check_ram/tasks/main.yml
index 1f17644..8da4e9a 100644
--- a/validations_common/roles/check_ram/tasks/main.yml
+++ b/validations_common/roles/check_ram/tasks/main.yml
@@ -1,4 +1,11 @@
 ---
+- name: Gather facts
+  setup:
+    gather_subset:
+      - hardware
+      - '!all'
+      - '!min'
+
 - name: Verify the RAM requirements
   fail:
     msg: >-