From 0249d81e08a8d6754cd3e5ea429c89a37eacf7ac Mon Sep 17 00:00:00 2001 From: Jiri Podivin Date: Wed, 24 Mar 2021 15:04:51 +0100 Subject: [PATCH] packages var renamed to packages_list Original name packages collided with ansible variable of the same name. Causing, amongst other issues, extreme delays in validation execution. Signed-off-by: Jiri Podivin Change-Id: I4f665b3479aa7d315d12d9d76cbb1acfc067a21b --- .../roles/check_latest_packages_version/defaults/main.yml | 2 +- .../molecule/default/converge.yml | 4 ++-- .../roles/check_latest_packages_version/tasks/main.yml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/validations_common/roles/check_latest_packages_version/defaults/main.yml b/validations_common/roles/check_latest_packages_version/defaults/main.yml index e8e9d2e..c20e5ba 100644 --- a/validations_common/roles/check_latest_packages_version/defaults/main.yml +++ b/validations_common/roles/check_latest_packages_version/defaults/main.yml @@ -6,5 +6,5 @@ tripleoclient: >- python2-tripleoclient {%- endif -%} -packages: +packages_list: - "{{ tripleoclient }}" diff --git a/validations_common/roles/check_latest_packages_version/molecule/default/converge.yml b/validations_common/roles/check_latest_packages_version/molecule/default/converge.yml index db4a659..79e3662 100644 --- a/validations_common/roles/check_latest_packages_version/molecule/default/converge.yml +++ b/validations_common/roles/check_latest_packages_version/molecule/default/converge.yml @@ -23,7 +23,7 @@ include_role: name: check_latest_packages_version vars: - packages: + packages_list: - patch - name: Working Detection of Update for Pam package @@ -31,7 +31,7 @@ - include_role: name: check_latest_packages_version vars: - packages: + packages_list: - pam rescue: diff --git a/validations_common/roles/check_latest_packages_version/tasks/main.yml b/validations_common/roles/check_latest_packages_version/tasks/main.yml index 6fa5965..5750710 100644 --- a/validations_common/roles/check_latest_packages_version/tasks/main.yml +++ b/validations_common/roles/check_latest_packages_version/tasks/main.yml @@ -14,7 +14,7 @@ check_package_update: package: "{{ item }}" pkg_mgr: "{{ ansible_pkg_mgr }}" - with_items: "{{ packages }}" + with_items: "{{ packages_list }}" register: updates - name: Check if current version is the latest one